Repository navigation
✨ dashboard: 12px text floor for the Activity monitor on phones - #17180
Conversation
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from Read this against the v5 tree rather than just the diff; it looks correct to me. What I verified
Red Sequencing note for whoever merges: #17198 also edits Minor: #17164's acceptance text says Review findings from docs-currency review at head
Advisory (not blocking): #17164 asks for 390×844 + 1280 screenshots in the PR; none are attached (body/comments), though Review findings from Intent alignment (#17164) — reviewed head
Also noted: the Review findings from Style/maintainability review at 92bff15 — two small in-scope fixes, one advisory.
Advisory (no change needed): the PR body and changelog describe only the text remap, but the diff also adds Could not run |
93545fd to
2d5810e
Compare
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
hive/ci-triage: the 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
runtime-tests failure root-caused: this PR adds the 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
…text-floor probes, re-pin TRUSTED_SCRIPTS_TREE Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Read at head 514371b against v5 (merge-base 8e55232). The CSS itself is still correct, but this head's red mobile-shots is caused by this PR, not by v5: the 12px floor pushes the card-per-row layout from #17198 over its height budget.
Evidence
mobile-shotsrun 42447214267 fails onlytracker-phone-card: "card rows must have median height ≤ 96px with ≥ 6 rows in view at 390x844", on every phone viewport (390×844, 375×667, 430×932, light and dark). The newtracker-text-floorprobe passes.- #17198 (which added that probe and the card layout) passed
mobile-shotsat its own head6532b1c— run 42446431101. - Between
6532b1c/v5and this head, the only change inside#activity-monitor-sectionisresponsive.css:44:#activity-monitor-section { --fs-2xs: var(--fs-sm); --fs-xs: var(--fs-sm); --ham-odo-digit: var(--fs-sm); }. Row text that goes through those tokens —.ham-chip(tracker.css:31),.ham-meta(:84),.ham-since(:164) — grows from ~10.9px to 12px per line, and the card probe (tracker-phone-card.js:12,MAX_MEDIAN_ROW_HEIGHT = 96) measures.ham-rowheight.
So the two requirements now conflict on the same rows: 12px text (this PR / #17164) and ≤ 96px median card height (#17198). Merging as-is would leave v5's mobile-shots red. The fix belongs here: either tighten the card's vertical spacing/wrapping so 12px text fits in 96px, or raise MAX_MEDIAN_ROW_HEIGHT with the rationale in #17198's terms (≥ 6 rows in view at 390×844 is the real constraint). I could not read the exact medians — gh run download is not permitted from this lane — so the *-activity-probes.json artifact on that run is the place to confirm the numbers.
Unchanged from earlier reviews: the TRUSTED_SCRIPTS_TREE re-pin at integration-governance.cjs:12 (066d4e1e → 75a61a7a) equals git rev-parse 514371b:src/scripts, which is what the guard's own error text (:103) prescribes, and the only src/scripts delta is the probe name at dashboard-mobile-shots.mjs:270. That is still a .github/scripts edit for @clubanderson to confirm, as the previous rounds said.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
…ext floor After #17198 (card-per-row Activity monitor layout) merged into v5, the tracker-phone-card probe measured a median .ham-row height of 97px against the 96px cap once combined with this PR's 12px text floor. Trim the phone-tier .ham-row vertical padding by 1px top and bottom (2px per card); every phone font-size stays at or above 12px. Regenerated static/index.html. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Decision needed: @clubanderson should confirm the TRUSTED_SCRIPTS_TREE re-pin in .github/scripts/integration-governance.cjs:12 (066d4e1e → 75a61a7a) is acceptable; it equals this head's src/scripts tree and the only src/scripts change is one probe name at dashboard-mobile-shots.mjs:270.
Read at head 30554b2 against v5. mobile-shots is now green at this head (all phone probes including tracker-phone-card and tracker-text-floor pass), but the commit that fixed it — 30554b2, "keep phone card rows at the 96px median" — introduces a raw 1px literal into the phone card tier and that breaks two existing guards. This is the PR's own change, not v5 drift.
What fails and why
src/pkg/dashboard/static-src/css/tracker.css:992(and the generatedstatic/index.html:2335):#activity-monitor-section .ham-row { padding-block: calc(var(--sp-4) - 1px); }.src/pkg/dashboard/stage_tracker_activity.test.js:682assertsdoesNotMatch(card…, /#[0-9a-fA-F]{3,8}\b|\d+px/, 'card tier uses tokens only')over the whole phone-card media block — the1pxmatches\d+px. That is thenot ok 123 — phone card per row …failure inruntime-tests, andTestStageTrackerActivityJavaScript(dashboard 2/4, dashboard shuffle 3/3) is the Go wrapper over the same JS suite.src/pkg/dashboard/webstatic/style_ratchet_test.go:237counts the newpadding-block:declaration viapaddingRE(line 63): operatorstatic/index.htmlis now at 205 raw padding declarations against the 204 baseline (line 32). The same run also reports raw colors at 134, below the 135 baseline (line 30) — so the baseline needs editing to 134 at this head regardless.
Suggested fix: express the row padding through tokens the card tier already uses (e.g. a --sp-* value or a new --ham-row-pad-phone token declared in tokens.css, rather than - 1px inline), then regenerate static/index.html; update styleRatchetBaselines["operator static/index.html"].rawColors to 134 in the same PR. If the padding tweak genuinely needs a non-token value, the guard at stage_tracker_activity.test.js:682 is deliberate (#17161), so that is a conversation to have rather than a regex to widen.
Trust-surface note (.github/scripts/integration-governance.cjs:12): TRUSTED_SCRIPTS_TREE moves 066d4e1e → 75a61a7a. I checked: 75a61a7a… is exactly src/scripts at this head, and the only src/scripts change in the diff is the added 'tracker-text-floor' probe name at dashboard-mobile-shots.mjs:270. Mechanical, but it is a verifier pin, so it stays a maintainer's call.
Decision needed: @clubanderson should confirm the TRUSTED_SCRIPTS_TREE re-pin in .github/scripts/integration-governance.cjs:12 (066d4e1e → 75a61a7a) is acceptable; it equals this head's src/scripts tree and the only src/scripts change is one probe name at dashboard-mobile-shots.mjs:270.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
…rs 134 The 1px trim landed as calc(var(--sp-4) - 1px), which carries a raw px literal: the card-tier tokens-only assertion in stage_tracker_activity.test.js and TestStyleRatchet's raw-padding count both rejected it. --sp-3 (6px) keeps every card at or under the 96px median cap without a literal. The ratchet also reports this branch at 134 raw colors, one below the operator baseline, so the baseline follows it down. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Read at head 30554b2 against v5. The 12px remap itself is still correct and mobile-shots is now green, but the line added at this head to fix the card-height conflict is what turns v2 Tests red — two separate guards reject it.
Finding (high) — src/pkg/dashboard/static-src/css/tracker.css:992 (mirrored at static/index.html:2335)
#activity-monitor-section .ham-row { padding-block: calc(var(--sp-4) - 1px); }stage_tracker_activity.test.js:682asserts the phone card tier contains no\d+pxliteral after its first{('card tier uses tokens only'). The- 1pxfails it, soTestStageTrackerActivityJavaScript(stage_tracker_activity_test.go:200) fails intest (dashboard 2/4)andtest (dashboard shuffle 3/3), on all re-runs — run 42448342897, subtestnot ok 26 - phone card per row ….style_ratchet_test.go:88:operator static/index.htmlraw padding went 204 → 205, above the baseline, soTestStyleRatchetfails intest (rest 3/4). That is the same declaration.
Consequence: merging as-is leaves v5 red on the dashboard and rest lanes. Fix: express the row padding through tokens only (e.g. a --sp-* step, or a new token in tokens.css if the card budget genuinely needs the odd pixel) and regenerate static/index.html.
Open question (not a defect from this diff): the same TestStyleRatchet run also reports raw colors at 134, below the 135 baseline. This PR touches no color literal, so that likely rode in with the v5 merge; whoever lands first should lower styleRatchetBaselines["operator static/index.html"].rawColors to 134.
Also verified
.github/scripts/integration-governance.cjs:12—TRUSTED_SCRIPTS_TREE75a61a7a…equalsgit rev-parse 30554b2:src/scripts; the onlysrc/scriptschange is the probe name atdashboard-mobile-shots.mjs:270. Same re-pin mechanism the earlier reviews routed to @clubanderson; nothing new there.responsive.css:44remap andactivity_monitor_phone_text_floor_test.go:17guard are unchanged from the previously reviewed heads.- The
.ham-rowpadding change is not mentioned in the PR body or in thedashboard-design-system.mdsection this PR adds; worth a sentence once it is reworked, since it is the one line that interacts with #17198's ≤96px card budget.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
clubanderson
left a comment
There was a problem hiding this comment.
Owner review: scoped token remap (--fs-2xs/--fs-xs/--ham-odo-digit → --fs-sm) inside #activity-monitor-section in the existing phone tier only; desktop untouched; ratchet count adjusted; probe + Go guard added. mobile-shots green on 92bff15.
/approve
/lgtm
|
LGTM label has been added. DetailsGit tree hash: 9aa15ed62f9077dacac593f9ac4fbfa638a0f520 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
At 390×844 the Activity monitor rendered 240 text nodes below 11px (--fs-xs / --fs-2xs on chips, since, stage, column headers).
In the existing phone tier, #activity-monitor-section now remaps --fs-2xs and --fs-xs to --fs-sm (12px). Inputs stay at --fs-touch; desktop is unchanged.
Adds a Go guard test, a 390×844 tracker-text-floor probe in dashboard-mobile-shots (text size + no horizontal overflow), design-system docs, and a changelog fragment. static/index.html is updated to match the generated output.
Closes #17164
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson