Skip to content

πŸ› fix(pr-title): proposals use the πŸ“– prefix the PR Type gate accepts - #17110

Merged
hivecommons-hive[bot] merged 11 commits into
v5from
scanner/fix-17105
Nov 8, 2026
Merged

hivecommons-hive[bot] merged 11 commits into
v5from
scanner/fix-17105

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

The documented πŸ“ proposal: prefix has never been mergeable: the pinned PR Type verifier accepts only the kubebuilder emoji set (⚠ ✨ πŸ› πŸ“– πŸš€ 🌱). Simplest additive fix: normalise proposals/RFCs to πŸ“–, update CONTRIBUTING/AGENTS/lane prompt, and keep RFC-PR classification recognising both πŸ“ and πŸ“– so existing titles still classify. Closes #17105

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Closes #17113 β€” reviewDocsEmojiPrefixes keeps the literal πŸ“ so already-open legacy proposal titles stay in the docs tier (commit e249910).

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 7, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17171 πŸ› fix: unclaimed proposal / kind/design issues derive stage/018-open-for-discussion same files CONTRIBUTING.md

@hivecommons-hive

hivecommons-hive Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: pushed the P3 review follow-up (stale test comment naming πŸ“ the proposal emoji). CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: d1d57823e

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

Review findings from adjudicator-3 (folded here because this head already carries its hive review):

Correctness review at head c6c6d44. Core change matches the decision in #17105: PRTitleEmojiProposal = "πŸ“–" (src/pkg/github/pr_title.go:53) makes NormalizePRTitleEmoji rewrite πŸ“ proposal:/πŸ“ rfc: to πŸ“– via prTitleTypeEmoji (pr_title.go:63), tests updated (pr_title_test.go:103-106), and IsRFCPR plus reviewDocsEmojiPrefixes keep accepting legacy πŸ“ (rfcnotify.go:196-200, review_priority.go:76). CI (build-go, contract-tests) is green. No blocker.

Advisory, low:

  • IsRFCPR prefix widening β€” src/pkg/rfcnotify/rfcnotify.go:196-200 now matches any lowercased title starting with πŸ“– rfc. Under the old convention only πŸ“ carried that risk; πŸ“– is now also the docs emoji, so a docs PR titled e.g. πŸ“– rfcnotify: fix typo (non-conventional subject, no docs: type) is announced as RFC doc proposed. Conventional πŸ“– docs(rfcnotify): … titles are unaffected. Tightening to πŸ“– rfc:/πŸ“– rfc (space or colon after rfc) would close it; fine to defer.
  • Stale comment: src/pkg/github/pr_request_watcher_test.go:476 still says "πŸ“ is the proposal emoji".

Review findings from ci-maintainer (folded here because this head already carries its hive review):

Style review (head 1156540) β€” the constant flip is sound (prTitleTypeEmoji uses it as a value, pr_title.go:60-67, so no duplicate-key issue), but it leaves one consumer and two comments behind:

  1. src/pkg/github/review_priority.go:74 β€” reviewDocsEmojiPrefixes = []string{PRTitleEmojiDocs, PRTitleEmojiProposal, "πŸ—", "β™»"} now expands to {"πŸ“–", "πŸ“–", …}: a duplicate entry, and the legacy πŸ“ emoji match is silently gone. πŸ“ proposal: still classifies via the "proposal" word prefix (:78), but πŸ“ rfc: does not (rfc is not in reviewDocsWordPrefixes), so an existing πŸ“ rfc: PR falls through to label-only classification. [scanner] PR Type gate rejects the documented πŸ“ proposal: title prefix; hive normaliser rewrites titles into itΒ #17105 asks that existing πŸ“ titles still classify. Suggested fix: []string{PRTitleEmojiDocs, "πŸ“" /* legacy proposal emoji, #17105 */, "πŸ—", "β™»"}.
  2. src/pkg/github/review_priority.go:64 β€” comment still lists πŸ“ proposal as the convention.
  3. src/pkg/github/pr_request_watcher_test.go:476 β€” comment still says "πŸ“ is the proposal emoji, docs is πŸ“–"; the equivalent comment in gh_auth_instructions_test.go:117 was updated, this one was missed.

Reviewed by reviewer-2 β€” no findings.

Reviewer notes

Read against the tree at 57d3da8. Looks correct to me.

  • src/pkg/github/pr_title.go:60-66 β€” prTitleTypeEmoji is keyed by type, not emoji, so PRTitleEmojiProposal == PRTitleEmojiDocs introduces no duplicate key; NormalizePRTitleEmoji (pr_title.go:86-99) now rewrites πŸ“ proposal:/πŸ“ rfc: β†’ πŸ“– … exactly as the new table rows in pr_title_test.go:103-106 expect.
  • src/pkg/rfcnotify/rfcnotify.go:196-200 keeps accepting the legacy πŸ“ prefix, so already-open πŸ“ RFC PRs remain RFC documents for the announcer; review_priority.go:76 keeps the literal πŸ“ for the same reason.
  • Matches the decision written in [scanner] PR Type gate rejects the documented πŸ“ proposal: title prefix; hive normaliser rewrites titles into itΒ #17105 (proposals use the gate's πŸ“–), and the PR Type check is green on this head.

No findings.

Reviewed by reviewer β€” no findings.

Reviewer notes

Read against the v5 tree, not just the diff. This looks correct to me and matches the decision written down in #17105.

  • PRTitleEmojiProposal becoming equal to PRTitleEmojiDocs is safe: prTitleTypeEmoji (src/pkg/github/pr_title.go:58) uses the constants as map values, and NormalizePRTitleEmoji only compares the leading emoji against PRTitleEmojiFor(type), so πŸ“ proposal: β†’ πŸ“– proposal: and πŸ“– proposal: is left alone, as the new test cases assert.
  • review_priority.go:76 keeps the literal πŸ“ in reviewDocsEmojiPrefixes, and rfcnotify.IsRFCPR accepts both πŸ“/πŸ“– + proposal:/rfc, so pre-existing πŸ“ RFC: … titles still classify and announce β€” the card/thread tests under src/pkg/rfcnotify that still use πŸ“ prefixes remain valid.
  • A code search for πŸ“ proposal under src/pkg finds no consumer this PR missed (rfcnotify.go, review_priority.go, lane_messages.go plus their tests are all touched or still covered).
  • The PR Type check is green on this very PR's πŸ› title; the issue documents πŸ“ failing it on πŸ“ proposal: Nous β†’ Spek β€” the winning experiment as a spek-new sourceΒ #17063/πŸ“ proposal: LLM-ranked knowledge advisor (phase 2 of #17052)Β #17070, which is the behaviour being fixed.

No findings.

Review findings from adjudicator (folded here because this head already carries its hive review):

Correctness review (head 52b1ca4) β€” matches the decision recorded in #17105; no blocker.

One low-severity edge this change widens, advisory only:

  • src/pkg/rfcnotify/rfcnotify.go:197 β€” strings.HasPrefix(t, emoji+" rfc") is unanchored (no :/space after rfc). With πŸ“– now in the loop, an ordinary docs PR titled e.g. πŸ“– rfcnotify: tighten wording or πŸ“– rfc-cards: … is classified as an RFC document and announced (RFC doc proposed: …) in rich mode. Before this PR the same looseness existed for πŸ“, but πŸ“– is the common docs emoji so the exposure grows. Anchoring to " rfc:"/" rfc " (and keeping the πŸ“ rfc - lowercase fixture in pr_test.go:26 in mind) would close it.

Verified: pr_title.go:60-67 only has duplicate values for Docs/Proposal (no duplicate map keys); review_priority.go:76 prefix list tolerates the duplicated πŸ“–; CI build-go/contract-tests green at this head. Could not run go test locally (disabled in this pod).

Evidence bundle `#1711057d3da8` sha256:8f2f83b5cc2312b3a535aee3c2f77b2bba6b0c856b7664bc958e6c8fa170a859 β€” download from the dashboard or `hivectl review evidence #17110`.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off stage/050-review-pending Review swarm requested; awaiting a verdict for the current head role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) labels Nov 7, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent alignment (head 1156540): the diff implements exactly the decision recorded in #17105 β€” PRTitleEmojiProposal = "πŸ“–" (src/pkg/github/pr_title.go:54), CONTRIBUTING.md:335 / AGENTS.md:14 / lane_messages.go:229-231 updated, and IsRFCPR keeps accepting both πŸ“ and πŸ“– (src/pkg/rfcnotify/rfcnotify.go:196-200). One gap between the body and the diff:

  • review_priority.go silently loses legacy πŸ“ recognition. reviewDocsEmojiPrefixes = []string{PRTitleEmojiDocs, PRTitleEmojiProposal, "πŸ—", "β™»"} (src/pkg/github/review_priority.go:74) now expands to {πŸ“–, πŸ“–, πŸ—, β™»} β€” πŸ“ is gone from the title-emoji pass. πŸ“ proposal: … still lands on docs via the "proposal" word prefix (review_priority.go:78,143-147), but πŸ“ RFC: … / πŸ“ adr: … (neither word is in reviewDocsWordPrefixes) now fall through to labels or ReviewClassUnknown, where before the change they triaged as docs. The PR body promises "existing titles still classify"; this caller was not updated and no test in review_priority_test.go covers a πŸ“ title, so CI won't catch it. Fix: add a literal "πŸ“" to reviewDocsEmojiPrefixes (mirroring the {"πŸ“","πŸ“–"} loop in rfcnotify.go:196) and refresh the comment at review_priority.go:64, which still says πŸ“ proposal.

β€” hive: agent=adjudicator-5 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 7, 2026
With PRTitleEmojiProposal now πŸ“–, the docs-tier slice derived from the two
constants lost the literal πŸ“, so pre-existing "πŸ“ RFC: …" / "πŸ“ Epic: …"
titles (no word-prefix match) fell through to labels/paths. Add πŸ“ back
and cover it in the classifier table test.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Nov 7, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read at c6c6d44. Looks correct to me; no defects found.

What I verified against the tree:

  • src/pkg/github/pr_title.go:64 β€” proposal/rfc/adr map to PRTitleEmojiProposal, and NormalizePRTitleEmoji (pr_title.go:91-104) compares the leading emoji against that constant via prTitleEmojiEqual. With the constant now πŸ“–, πŸ“ proposal: is rewritten to πŸ“– proposal: and πŸ“– proposal: is a no-op β€” exactly what the new cases in pr_title_test.go:103-106 pin.
  • src/pkg/github/review_priority.go:76 β€” reviewDocsEmojiPrefixes keeps a literal πŸ“ so pre-existing πŸ“ RFC: / πŸ“ Epic: titles (no word-prefix match) still classify as ReviewClassRefactorDocs; review_priority_test.go:27 covers it. The list now contains πŸ“– twice (PRTitleEmojiDocs and PRTitleEmojiProposal), which is harmless.
  • src/pkg/rfcnotify/rfcnotify.go:196-200 β€” IsRFCPR accepts both emoji, so the announcer keeps recognising already-open πŸ“ proposal: PRs (src/cmd/hive/rfcnotify_wire_test.go:343,459-501 still use πŸ“ titles and pass).
  • src/pkg/scheduler/lane_messages.go:228-231 and gh_auth_instructions_test.go:120 agree on πŸ“– proposal; CONTRIBUTING.md:335 / AGENTS.md:14 are the only remaining πŸ“ mentions outside RFC docs and both now say it fails the gate.

Body matches the diff (additive, backward-compatible, Closes #17105). CI is green except tide, which is waiting on a human approval.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

Review follow-ups (below review.backlog.min_severity: P2)

Non-blocking findings below the backlog filing line are listed here instead of as issues, one comment per PR, updated in place. Tick them off as they are fixed; set review.backlog.min_severity: P3 to file every finding.

  • P3 info correctness β€” Stale test comment still names πŸ“ as the proposal emoji (src/pkg/github/pr_request_watcher_test.go:476): The doc comment on TestPRRequestWatcher_CorrectsTitleEmojiToConvention says "πŸ“ is the proposal emoji, docs is πŸ“–", which contradicts the convention this PR establishes (pr_title.go:46-53). Test behavi…
  • P3 low intent-alignment β€” Stale comment still calls πŸ“ the proposal emoji (src/pkg/github/pr_request_watcher_test.go:476): src/pkg/github/pr_request_watcher_test.go:475-476 still reads 'πŸ“ is the proposal emoji, docs is πŸ“–', which contradicts the convention this PR establishes (PRTitleEmojiProposal = "πŸ“–" at src/pkg/github/…

The test comment still described πŸ“ as the proposal emoji after this
PR moved proposals to πŸ“– (review follow-up on #17110).

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against the tree at 556af42 (src/pkg/github/pr_title.go, review_priority.go, src/pkg/rfcnotify/rfcnotify.go, the lane prompt and the docs). This looks correct to me and matches the decision recorded in #17105 ("proposals use πŸ“–; keep recognising a leading πŸ“").

What I verified:

  • pr_title.go:53-54 β€” PRTitleEmojiDocs and PRTitleEmojiProposal are now both πŸ“–. NormalizePRTitleEmoji (pr_title.go:92-105) only compares the leading emoji against PRTitleEmojiFor(type) via prTitleEmojiEqual, so the duplicate value is harmless: πŸ“ proposal: / πŸ“ rfc: β†’ πŸ“– …, πŸ“– proposal: unchanged, docs behaviour unaffected. The only other consumer of the constant is review_priority.go:76, where the explicit "πŸ“" literal keeps legacy πŸ“ RFC: / πŸ“ Epic: titles in the docs tier (covered by the new review_priority_test.go case).
  • rfcnotify.go:195-200 β€” IsRFCPR loops both emoji, so already-open πŸ“ proposal: PRs still announce; pr_test.go covers both prefixes.
  • lane_messages.go:229-231 drops the "πŸ“ is for proposals only" wording and gh_auth_instructions_test.go is updated to match; AGENTS.md / CONTRIBUTING.md / notifications.md say the same thing as the code.
  • No remaining non-test πŸ“ in src/ outside the deliberate legacy-recognition literals; changelog.d/fixed-17105.md present.

CI is green apart from tide pending. Nothing blocking from my side.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against the tree at 497f480, plus every consumer of PRTitleEmojiProposal and the literal πŸ“. Looks correct to me; nothing blocking.

What I verified:

  • src/pkg/github/pr_title.go:54 β€” PRTitleEmojiProposal = "πŸ“–" is only ever used as a value in prTitleTypeEmoji (pr_title.go:64), so collapsing it onto PRTitleEmojiDocs cannot collide with anything; NormalizePRTitleEmoji now rewrites πŸ“ proposal:/πŸ“ rfc: β†’ πŸ“– … and leaves πŸ“– proposal: alone, which is exactly what pr_title_test.go:103-106 pins.
  • src/pkg/github/review_priority.go:76 β€” the docs tier keeps a literal πŸ“, so already-open πŸ“ RFC: … titles still classify as ReviewClassRefactorDocs (review_priority_test.go:27). The duplicate πŸ“– in that slice is harmless (prefix check). This is the #17113 follow-up and it is in this head.
  • src/pkg/rfcnotify/rfcnotify.go:196 β€” IsRFCPR accepts both emoji; pr_test.go:26 covers both.
  • src/pkg/scheduler/lane_messages.go:228-231 and gh_auth_instructions_test.go:120 agree (πŸ“– docs, πŸ“– proposal, "πŸ“– docs: …" all present in the block).
  • Gate claim: .github/workflows/pr-verifier.yml pins the kubebuilder pr-verifier, whose accepted set is ⚠ ✨ πŸ› πŸ“– πŸš€ 🌱; the PR Type check is green on this πŸ› title, and #17105 quotes the red run for πŸ“.
  • Docs: CONTRIBUTING.md, AGENTS.md, src/docs/notifications.md:330 and the changelog fragment all updated. CHANGELOG.md:243/1232 still mention πŸ“ proposal but those are historical release entries, not current guidance β€” correctly left alone.

Matches the decision recorded in #17105 (proposals β†’ πŸ“–, additive, legacy πŸ“ still recognised). Every behaviour change has a test that would fail without it.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read pr_title.go, review_priority.go, rfcnotify.go at the base, and .github/workflows/pr-verifier.yml. Looks correct to me.

The premise holds: the PR Type context comes from the pinned kubebuilder pr-verifier image, whose type parser recognises only ⚠ ✨ πŸ› πŸ“– πŸš€ 🌱, so πŸ“ has never passed it. Making PRTitleEmojiProposal = "πŸ“–" means prTitleTypeEmoji (pr_title.go:59) now routes proposal/rfc/adr to πŸ“– and NormalizePRTitleEmoji rewrites legacy πŸ“ proposal: titles at the hive-open-pr choke point, which the new test cases cover. Keeping the literal πŸ“ in reviewDocsEmojiPrefixes (review_priority.go:76) and in IsRFCPR is what preserves classification of already-open titles β€” I checked there are no other πŸ“ proposal/πŸ“ RFC emitters left in src/ after this diff (the πŸ“ mentions remaining in gfi.go and notifications.md:306 are about issue titles, which the gate does not read).

One behaviour change worth knowing: πŸ“– rfc: … used to be rewritten to πŸ“ rfc: …; it now stays πŸ“–. That is the intended direction.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the full tree at the head (52b1ca4), not just the diff. Looks correct to me.

What I verified:

  • src/pkg/github/pr_title.go:50-57 β€” PRTitleEmojiProposal keeps its name and now equals πŸ“–; prTitleTypeEmoji (:61-68) still maps proposal/rfc/adr through it, so NormalizePRTitleEmoji rewrites πŸ“ proposal:/πŸ“ rfc: β†’ πŸ“– … and leaves πŸ“– proposal: alone. The three updated cases in pr_title_test.go:103-106 pin exactly that, including the reversed rfc case that previously asserted the opposite direction.
  • src/pkg/github/review_priority.go:76 β€” the literal πŸ“ stays in reviewDocsEmojiPrefixes, so already-open πŸ“ RFC:/πŸ“ Epic: titles (no word-prefix match) still land in the docs tier; review_priority_test.go:27 covers it. (πŸ“– now appears twice in that slice via both constants β€” harmless.)
  • src/pkg/rfcnotify/rfcnotify.go:194-200 β€” IsRFCPR accepts both prefixes; issue-side IsRFC is untouched, which is right since issues never hit the PR Type gate.
  • The gate itself is the pinned external verifier (kubebuilder set ⚠ ✨ πŸ› πŸ“– πŸš€ 🌱), not in-tree; PR Type is green on this head, as is every other check β€” only tide is pending.
  • Docs, lane prompt (lane_messages.go:244-247) and the scheduler test asserting its wording all moved together; changelog fragment present.

Per #17105 the choice of πŸ“– over adding πŸ“ to the verifier was already decided in the issue, so no open question from me.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read src/pkg/github/pr_title.go, review_priority.go, rfcnotify.go and scheduler/lane_messages.go at the v5 merge-base alongside the diff. This looks correct to me, and it does what #17105 decided.

What I checked:

  • prTitleTypeEmoji (pr_title.go:57) is keyed by Conventional Commits type, not by emoji, so setting PRTitleEmojiProposal = "πŸ“–" creates no collision; proposal/rfc/adr now resolve to πŸ“– and NormalizePRTitleEmoji leaves πŸ“– proposal: alone via prTitleEmojiEqual. The PRTitleEmojiFor("PROPOSAL") assertion at pr_title_test.go:140 still holds.
  • reviewDocsEmojiPrefixes (review_priority.go:74) keeps a literal πŸ“ so pre-existing πŸ“ RFC:/πŸ“ Epic: titles (no word-prefix match) still classify as docs; the duplicate πŸ“– entry in the slice is harmless.
  • IsRFCPR (rfcnotify.go:194) accepts both leading emoji, so existing RFC-PR titles are still announced.
  • The strings TestGHAuthInstructions_NamesThePRTitleEmojiConvention now asserts (πŸ“– proposal, "πŸ“– docs: …") are all present in the new ghAuthInstructions text.
  • No other non-test Go file depends on PRTitleEmojiProposal being πŸ“ (crux/agentmode and gfi only list πŸ“ as a strippable symbol).

Verified .github/workflows/pr-verifier.yml exists and the issue quotes the gate's own rejection of πŸ“, so the premise holds. Checks are currently SKIPPED/UNSTABLE rather than red; CI remains the verdict on the test edits.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 8112257 into v5 Nov 8, 2026
80 of 81 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-17105 branch November 8, 2026 03:45
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

0 participants