Skip to content

Attempts to fix runaway explosion recursion#12434

Draft
Drulikar wants to merge 14 commits into
cmss13-devs:masterfrom
Drulikar:explosion_stuff
Draft

Attempts to fix runaway explosion recursion#12434
Drulikar wants to merge 14 commits into
cmss13-devs:masterfrom
Drulikar:explosion_stuff

Conversation

@Drulikar

@Drulikar Drulikar commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

About the pull request

This PR does a few things:

  • Explosions that are merged in the same direction combine their exploded_atoms list
  • Explosions that propagate combine their exploded_atoms list
  • /datum/automata_cell/explosion/proc/on_turf_entered had an assumption that it was causing a directionless ex_act call by passing null as direction but this just randomized the direction. Now a direction < 0 is considered directionless and will prevent create_shrapnel and explosion_throw from doing anything on a directionless explosion.
  • reorders a place where exploded_atoms was added to (as in now its considered exploded prior to exploding it)
  • reorders gc_destroyed to be first over exploded_atoms checks because they should be faster
  • early returns on throw_atom if the src is qdeleted because it doesn't make sense to be chucking qdeleted things and just causes problems
  • Explosion cells spawned in the same turf now actually merge (previously they would only merge if the 2nd explosion was the dying explosion rather than the 2nd explosion potentially deleting the existing)
  • WIP: Attempts to delay turf side effects on entry
  • WIP: Fixes (or maybe removes) turfs retaining signals

Explain why it's good for the game

Hopefully no more occurrences of

runtime error: Maximum recursion level reached (perhaps there is an infinite loop)
To avoid this safety check, set world.loop_checks=0.
proc name: getarmor organ (/mob/living/carbon/human/proc/getarmor_organ)
usr: (src)
src: some_guy (/mob/living/carbon/human)
src.loc: the aged igneous (18,124,2) (/turf/open/auto_turf/hybrisa_auto_turf/layer2)
call stack:
some_guy (/mob/living/carbon/human): getarmor organ(the chest (/obj/limb/chest), 16)
some_guy (/mob/living/carbon/human): getarmor(null, 16)
some_guy (/mob/living/carbon/human): ex act(350, null, /datum/cause_data (/datum/cause_data), 0, 0)
ImmediateInvokeAsync(some_guy (/mob/living/carbon/human), "ex_act", 350, null, /datum/cause_data (/datum/cause_data), 0, 0)
/datum/automata_cell/explosion (/datum/automata_cell/explosion): on turf entered(some_guy (/mob/living/carbon/human))
the aged igneous (18,124,2) (/turf/open/auto_turf/hybrisa_auto_turf/layer2): Entered(some_guy (/mob/living/carbon/human), the aged igneous (19,125,2) (/turf/open/auto_turf/hybrisa_auto_turf/layer2))
some_guy (/mob/living/carbon/human): Move(the aged igneous (18,124,2) (/turf/open/auto_turf/hybrisa_auto_turf/layer2), null)
some_guy (/mob/living/carbon/human): Move(the aged igneous (18,124,2) (/turf/open/auto_turf/hybrisa_auto_turf/layer2), null)
some_guy (/mob/living/carbon/human): Move(the aged igneous (18,124,2) (/turf/open/auto_turf/hybrisa_auto_turf/layer2), null)
some_guy (/mob/living/carbon/human): launch towards(/datum/launch_metadata (/datum/launch_metadata), 0)
...
some_guy (/mob/living/carbon/human): Move( volcanic plate and rock (22,120,2) (/turf/open/auto_turf/hybrisa_auto_turf/layer3), null)
some_guy (/mob/living/carbon/human): Move( volcanic plate and rock (22,120,2) (/turf/open/auto_turf/hybrisa_auto_turf/layer3), null)
some_guy (/mob/living/carbon/human): launch towards(/datum/launch_metadata (/datum/launch_metadata), 0)
some_guy (/mob/living/carbon/human): throw atom( volcanic plate and rock (22,120,2) (/turf/open/auto_turf/hybrisa_auto_turf/layer3), 1, 4, null, 0, 1, 0, null, null, 0)
some_guy (/mob/living/carbon/human): explosion throw(44.8867, 5)
ImmediateInvokeAsync(some_guy (/mob/living/carbon/human), "ex_act", 89.7733, 5, /datum/cause_data (/datum/cause_data), 0, 0)
Cellular Automata (/datum/controller/subsystem/cellauto): fire(1)
Master (/datum/controller/master): RunQueue()
Master (/datum/controller/master): StartProcessing(0)

Should also fix https://runtimes.cm-ss13.com/cm13/issues/196?query=is:unresolved%20null.z

Testing Photographs and Procedure

Screenshots & Videos

Heres a cluster bomb I guess?
image

Changelog

🆑 Drathek
fix: Hopefully fixed runtimes causing infinite explosion recursion (namely explosion entry should more properly be a directionless explosion, and more ways for explosions to merge)
fix: Explosion cells now merge even if the 2nd to spawn should be the survivor
fix: Corrected turf signal retaining behavior
/:cl:

@Drulikar Drulikar added Performance the game sucks and this makes it suck less Runtime bad list x1000 Needs Testing Need to test it on the guinea pigs (production server) labels Jun 13, 2026
@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Jun 13, 2026
@cmss13-ci cmss13-ci Bot added Fix Fix one bug, make ten more size/S Denotes a PR that changes 19-49 lines, ignoring generated files. labels Jun 13, 2026
@cm13-github

cm13-github commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Test merge deployment history:

Test Merge Deployed @ 06/13/2026 02:31:40 +00:00:
Server Instance

CM13 Live

Revision

Origin: 5aea0b8
Pull Request: b1287f9
Server: b0f739ef0b091e654b2103a09795ae2f45be2c01

Test Merge Updated @ 06/13/2026 04:25:52 +00:00:
Server Instance

CM13 Live

Revision

Origin: 0b082b9
Pull Request: b1287f9
Server: 55ab99189bd4c588dc8b691026014b5cecc82b9f

Test Merge Updated @ 06/13/2026 11:58:35 +00:00:
Server Instance

CM13 Live

Revision

Origin: 3e926a4
Pull Request: b1287f9
Server: 625e228dd6c4d0c7dd05846591d7070ec5c648f2

Test Merge Updated @ 06/13/2026 12:29:29 +00:00:
Server Instance

CM13 Live

Revision

Origin: 0363ebf
Pull Request: b1287f9
Server: cecfd5d54318270fa731a6539c6a11269255ff28

Test Merge Updated @ 06/13/2026 16:03:10 +00:00:
Server Instance

CM13 Live

Revision

Origin: 0363ebf
Pull Request: b1287f9
Server: 53090c5ebdc8258684f27b48379df2e7383d6b77

Test Merge Updated @ 06/13/2026 16:50:47 +00:00:
Server Instance

CM13 Live

Revision

Origin: 0363ebf
Pull Request: b1287f9
Server: 652aa35b4b0ae801b2a405739f093f5759475405

Test Merge Updated @ 06/13/2026 17:13:54 +00:00:
Server Instance

CM13 Live

Revision

Origin: 0363ebf
Pull Request: b1287f9
Server: 6cd01c627992e3fe65f118ee4eac896f6cdd982b

Test Merge Updated @ 06/13/2026 17:34:18 +00:00:
Server Instance

CM13 Live

Revision

Origin: 474372f
Pull Request: b1287f9
Server: 4c3f4c79fee91fabee817bee30345b245dd4e712

Test Merge Updated @ 06/13/2026 18:05:10 +00:00:
Server Instance

CM13 Live

Revision

Origin: b9acff5
Pull Request: b1287f9
Server: d1470546a70f762cbfb9f238c369ab389418497f

Test Merge Updated @ 06/13/2026 20:36:35 +00:00:
Server Instance

CM13 Live

Revision

Origin: eb545c3
Pull Request: b1287f9
Server: 1cdc35a

Test Merge Updated @ 06/13/2026 21:07:27 +00:00:
Server Instance

CM13 Live

Revision

Origin: 78b3562
Pull Request: b1287f9
Server: c5bb69b5744f0ef3754ecb210036507d3fd81700

Test Merge Updated @ 06/13/2026 21:44:56 +00:00:
Server Instance

CM13 Live

Revision

Origin: cda695e
Pull Request: b1287f9
Server: 21ed3249f3749925f1dbbe16b5a4b4ef67e2c8c3

Test Merge Updated @ 06/14/2026 01:41:58 +00:00:
Server Instance

CM13 Live

Revision

Origin: cda695e
Pull Request: 0ec0e77
Server: dffc13ad9b99ff88ac62b3322a41c2f684f7b49c

Test Merge Updated @ 06/14/2026 04:40:01 +00:00:
Server Instance

CM13 Live

Revision

Origin: 12a894f
Pull Request: 0ec0e77
Server: cc79207a131761555091359ede752f0ca1ab47fe

Test Merge Updated @ 06/15/2026 14:50:14 +00:00:
Server Instance

CM13 Live

Revision

Origin: 12a894f
Pull Request: 7389db8
Server: 6bd590cd87ed937b31ebd23beabbcc493e230e27

Test Merge Updated @ 06/15/2026 15:21:11 +00:00:
Server Instance

CM13 Live

Revision

Origin: 12a894f
Pull Request: 7389db8
Server: 37612630dde52ed1a655813b1e47b577b691bb3d

Test Merge Updated @ 06/15/2026 19:06:48 +00:00:
Server Instance

CM13 Live

Revision

Origin: 12a894f
Pull Request: 7389db8
Server: 7cd56903229bb732aa6e52c427c79c52d8aa485f

Test Merge Updated @ 06/15/2026 20:53:46 +00:00:
Server Instance

CM13 Live

Revision

Origin: 12a894f
Pull Request: 7389db8
Server: 2dcfec2b828a6f4d841bb0720cbff035d78f613c

Test Merge Updated @ 06/15/2026 21:54:55 +00:00:
Server Instance

CM13 Live

Revision

Origin: 12a894f
Pull Request: 7389db8
Server: cc3d9b5771271e70d80fcddd89a11e2c966bc2cf

Test Merge Updated @ 06/16/2026 02:57:03 +00:00:
Server Instance

CM13 Live

Revision

Origin: 12a894f
Pull Request: 7389db8
Server: db61e022463c328a36b15854a8549337ab5b1b58

Test Merge Updated @ 06/16/2026 06:28:48 +00:00:
Server Instance

CM13 Live

Revision

Origin: a12608c
Pull Request: 7389db8
Server: a1c1cfaaf83314b7f0c411f206e5f7da982cf149

Test Merge Updated @ 06/16/2026 06:57:08 +00:00:
Server Instance

CM13 Live

Revision

Origin: a12608c
Pull Request: 7389db8
Server: 8259fdc0b9c29587ebe37e656de48423c73d4b8a

Test Merge Updated @ 06/16/2026 08:00:01 +00:00:
Server Instance

CM13 Live

Revision

Origin: 01ce6ff
Pull Request: 7389db8
Server: a0d39a265c33d24a8dd141e55da867b3c7f9166b

Test Merge Updated @ 06/16/2026 11:01:46 +00:00:
Server Instance

CM13 Live

Revision

Origin: a9e95fe
Pull Request: 7389db8
Server: b3a66513697dd8034621b18ce505287f30e772ac

Test Merge Updated @ 06/16/2026 11:32:38 +00:00:
Server Instance

CM13 Live

Revision

Origin: b0cd7e5
Pull Request: 7389db8
Server: 1ee4dbafc836ecb6505fcf16b4695e0e32e572eb

Test Merge Updated @ 06/16/2026 12:03:31 +00:00:
Server Instance

CM13 Live

Revision

Origin: c24d75b
Pull Request: 7389db8
Server: 83c058448a5df013cbb066ca56c6b2628e639e85

Test Merge Updated @ 06/16/2026 16:37:49 +00:00:
Server Instance

CM13 Live

Revision

Origin: c24d75b
Pull Request: 7389db8
Server: c66ee6386621842acb9b6a589f9d88ff79712f79

Test Merge Updated @ 06/16/2026 17:39:32 +00:00:
Server Instance

CM13 Live

Revision

Origin: c24d75b
Pull Request: 7389db8
Server: c3b8bbeeaa7ffa6daac59fa9440d1907f8ec0e44

Test Merge Updated @ 06/17/2026 04:46:21 +00:00:
Server Instance

CM13 Live

Revision

Origin: 8f6a78a
Pull Request: 7389db8
Server: b8015c65ad7ec6166290925e705a22aa3b4cd75d

Test Merge Updated @ 06/17/2026 05:06:49 +00:00:
Server Instance

CM13 Live

Revision

Origin: 8f6a78a
Pull Request: 7389db8
Server: d0867494a99643130283d2a703029652e8f7ba61

Test Merge Updated @ 06/18/2026 04:00:21 +00:00:
Server Instance

CM13 Live

Revision

Origin: 8f6a78a
Pull Request: 7389db8
Server: d2a64a04e906b86211e8cd55d089471b08287a63

Test Merge Updated @ 06/18/2026 10:03:21 +00:00:
Server Instance

CM13 Live

Revision

Origin: 1c841ba
Pull Request: 7389db8
Server: f93f25171ed2f8546270dd593a34f22e83fb54d7

Test Merge Updated @ 06/18/2026 10:08:30 +00:00:
Server Instance

CM13 Live

Revision

Origin: 1c841ba
Pull Request: 7389db8
Server: c5f79a3

Test Merge Updated @ 06/19/2026 05:14:06 +00:00:
Server Instance

CM13 Live

Revision

Origin: 5bd69c2
Pull Request: 7389db8
Server: 2a6c76510c1f345e75993eacb7212d0f10f3bd41

Test Merge Updated @ 06/20/2026 01:22:09 +00:00:
Server Instance

CM13 Live

Revision

Origin: 7b89fbf
Pull Request: 7389db8
Server: 21f1ae35f94ae63e4c6eae3c17ea8d29c7988bdc

Test Merge Updated @ 06/20/2026 04:25:00 +00:00:
Server Instance

CM13 Live

Revision

Origin: 01c8e07
Pull Request: 7389db8
Server: 96a65cc1defa68a680a261b9870a473ea5546068

Test Merge Updated @ 06/20/2026 19:16:25 +00:00:
Server Instance

CM13 Live

Revision

Origin: 01c8e07
Pull Request: 7389db8
Server: b62c65e4416f9718730e9214a5f3f9ef4cccd83a

Test Merge Updated @ 06/20/2026 20:28:21 +00:00:
Server Instance

CM13 Live

Revision

Origin: 01c8e07
Pull Request: 7389db8
Server: 5603517cb781080c0f903b164879ab144a04ff63

Test Merge Updated @ 06/21/2026 14:37:05 +00:00:
Server Instance

CM13 Live

Revision

Origin: 167d599
Pull Request: 7389db8
Server: 75028ddcac58cf479d23db343d7180a80f15aa0a

Test Merge Updated @ 06/21/2026 16:09:30 +00:00:
Server Instance

CM13 Live

Revision

Origin: a23eb58
Pull Request: 7389db8
Server: 1c1eecfccf0feeeda24ff726bef9e05027d53e4d

Test Merge Updated @ 06/21/2026 16:40:39 +00:00:
Server Instance

CM13 Live

Revision

Origin: 3dc7108
Pull Request: 7389db8
Server: a561714ff0c93244cd91c5a2b97a8f4393e66f01

Test Merge Updated @ 06/21/2026 21:04:11 +00:00:
Server Instance

CM13 Live

Revision

Origin: 3dc7108
Pull Request: 7389db8
Server: 1828e192ed7f9c4d7f5f7f31da72ba6ac0a1f23b

Test Merge Updated @ 06/22/2026 02:14:38 +00:00:
Server Instance

CM13 Live

Revision

Origin: 1a8adc6
Pull Request: 7389db8
Server: 831a87954b0805c19ff69c16ecf9b8a3e84925c1

Test Merge Updated @ 06/22/2026 03:37:06 +00:00:
Server Instance

CM13 Live

Revision

Origin: dad0a25
Pull Request: 7389db8
Server: 1528ea312d590c6e40ca300e38d124326ce4b5af

Test Merge Updated @ 06/22/2026 04:07:08 +00:00:
Server Instance

CM13 Live

Revision

Origin: 79d17fe
Pull Request: 7389db8
Server: b1aae3712d8496e78dc050b71f032da9820b6b14

Test Merge Updated @ 06/22/2026 05:16:27 +00:00:
Server Instance

CM13 Live

Revision

Origin: 1638a7a
Pull Request: 7389db8
Server: 8ae2cefa40618ce0bb1c1163c274dc2e3b87e1e6

Test Merge Updated @ 06/22/2026 05:47:23 +00:00:
Server Instance

CM13 Live

Revision

Origin: 54aeed9
Pull Request: 7389db8
Server: 2dcfbd0de5d24fd2cb586c3c5f8453e4792aa6c8

Test Merge Updated @ 06/22/2026 06:18:18 +00:00:
Server Instance

CM13 Live

Revision

Origin: be624c9
Pull Request: 7389db8
Server: 5cbd88cdf2d91a25beea510a883e5a8ff458ea0f

Test Merge Updated @ 06/22/2026 06:49:10 +00:00:
Server Instance

CM13 Live

Revision

Origin: 9295194
Pull Request: 7389db8
Server: 385930de914ada415a091bc3aadcf618a60ffe39

Test Merge Updated @ 06/22/2026 07:20:02 +00:00:
Server Instance

CM13 Live

Revision

Origin: 5ab4835
Pull Request: 7389db8
Server: 189c5490be2aca256b86c6dc1cbd1218ac256a73

Test Merge Updated @ 06/22/2026 07:50:55 +00:00:
Server Instance

CM13 Live

Revision

Origin: 400e97d
Pull Request: 7389db8
Server: e6ea39faecd8df7d02459c601fb0c7c836a95fd5

Test Merge Updated @ 06/22/2026 08:21:47 +00:00:
Server Instance

CM13 Live

Revision

Origin: c301ea1
Pull Request: 7389db8
Server: 7b6c5d282b78386c5b1e760fd9ee7fb6c8286743

Test Merge Updated @ 06/22/2026 08:52:46 +00:00:
Server Instance

CM13 Live

Revision

Origin: fef4d8e
Pull Request: 7389db8
Server: 4b6462c9f0204505e39f866325f951c84450670d

Test Merge Updated @ 06/22/2026 09:23:40 +00:00:
Server Instance

CM13 Live

Revision

Origin: 62595c6
Pull Request: 7389db8
Server: c5fdfab07ad63f47cdf89b0b5cb81ebcc6bc2eea

Test Merge Updated @ 06/22/2026 10:24:43 +00:00:
Server Instance

CM13 Live

Revision

Origin: 24d11d9
Pull Request: 7389db8
Server: 8e31d4a0fedf5cc7410a46d4f9d3e52ff0c0bdcb

Test Merge Updated @ 06/22/2026 10:55:34 +00:00:
Server Instance

CM13 Live

Revision

Origin: bdeb8b3
Pull Request: 7389db8
Server: 1436cd580e3ab0944e4b4ff561b06b86d12c4363

Test Merge Updated @ 06/22/2026 12:59:59 +00:00:
Server Instance

CM13 Live

Revision

Origin: 75f73d5
Pull Request: 51f684d
Server: 24ea1e7d03b8c7e82c181e53c07319be667a7cac

Test Merge Updated @ 06/22/2026 13:39:48 +00:00:
Server Instance

CM13 Live

Revision

Origin: 75f73d5
Pull Request: 51f684d
Server: 80feb1fec126b2c6860cba161524a649ddf12e15

Test Merge Updated @ 06/22/2026 14:09:10 +00:00:
Server Instance

CM13 Live

Revision

Origin: 6054eea
Pull Request: 51f684d
Server: 0a58521

Test Merge Updated @ 06/22/2026 14:57:38 +00:00:
Server Instance

CM13 Live

Revision

Origin: 6054eea
Pull Request: 51f684d
Server: 233b9ff

Test Merge Updated @ 06/22/2026 19:49:45 +00:00:
Server Instance

CM13 Live

Revision

Origin: 6054eea
Pull Request: 51f684d
Server: 659c3ca

Test Merge Updated @ 06/22/2026 23:01:12 +00:00:
Server Instance

CM13 Live

Revision

Origin: ff751db
Pull Request: 51f684d
Server: a5eb0a4099358c0fb7edcd969a10312df39a6715

Test Merge Updated @ 06/23/2026 00:51:19 +00:00:
Server Instance

CM13 Live

Revision

Origin: ff751db
Pull Request: 51f684d
Server: d960450

Test Merge Updated @ 06/23/2026 03:03:29 +00:00:
Server Instance

CM13 Live

Revision

Origin: cd7d798
Pull Request: 51f684d
Server: 02e3055877ba566efbeac3a0b60812fa0a0519d1

Test Merge Updated @ 06/23/2026 04:04:44 +00:00:
Server Instance

CM13 Live

Revision

Origin: f4b7e26
Pull Request: 51f684d
Server: 15c2b1815ea6f3da213545aa0a79b1ec9c89e993

Test Merge Updated @ 06/23/2026 04:26:30 +00:00:
Server Instance

CM13 Live

Revision

Origin: 00e8925
Pull Request: 51f684d
Server: 7e05417

Test Merge Updated @ 06/23/2026 04:35:41 +00:00:
Server Instance

CM13 Live

Revision

Origin: 38987b5
Pull Request: 51f684d
Server: 1bc6de978a42a35ac30fe4e4737edb7d9821dce3

Test Merge Updated @ 06/23/2026 05:06:31 +00:00:
Server Instance

CM13 Live

Revision

Origin: ac8db53
Pull Request: 51f684d
Server: 71cd2dffe3b2829028f4cc5d4c684e85ee49dc64

Test Merge Updated @ 06/23/2026 05:37:21 +00:00:
Server Instance

CM13 Live

Revision

Origin: 1e2ad89
Pull Request: 51f684d
Server: 4ec8491111fe8d6deda3e6a26f10d4340b98e2fa

Test Merge Updated @ 06/23/2026 06:33:31 +00:00:
Server Instance

CM13 Live

Revision

Origin: 1e2ad89
Pull Request: 51f684d
Server: e6e1514

Test Merge Updated @ 06/23/2026 12:52:01 +00:00:
Server Instance

CM13 Live

Revision

Origin: 1e2ad89
Pull Request: 51f684d
Server: fc5e63e

Test Merge Updated @ 06/23/2026 13:40:24 +00:00:
Server Instance

CM13 Live

Revision

Origin: 1e2ad89
Pull Request: 51f684d
Server: 41eab73

Test Merge Updated @ 06/23/2026 14:41:58 +00:00:
Server Instance

CM13 Live

Revision

Origin: 1e2ad89
Pull Request: 51f684d
Server: 0fbe9a9

Test Merge Updated @ 06/24/2026 00:52:09 +00:00:
Server Instance

CM13 Live

Revision

Origin: 1e2ad89
Pull Request: 51f684d
Server: 79ed4b7

Test Merge Updated @ 06/24/2026 02:15:57 +00:00:
Server Instance

CM13 Live

Revision

Origin: 157e26b
Pull Request: 51f684d
Server: 03aa7aaf1bfe10e0757702cb988c12211f26a2f2

Test Merge Updated @ 06/24/2026 02:46:48 +00:00:
Server Instance

CM13 Live

Revision

Origin: 38ef1cd
Pull Request: 51f684d
Server: d42705470973d872e4d687ef9d5a6b7d2c4c64d5

Test Merge Updated @ 06/24/2026 03:18:07 +00:00:
Server Instance

CM13 Live

Revision

Origin: f76a23e
Pull Request: 51f684d
Server: d74e9af4aa914226a2ba02acc1da25d9f0415ce7

Test Merge Updated @ 06/24/2026 04:19:11 +00:00:
Server Instance

CM13 Live

Revision

Origin: 8f697ab
Pull Request: 51f684d
Server: d0a013a74080714f774d66b4be174afe09c23746

Test Merge Updated @ 06/24/2026 05:20:20 +00:00:
Server Instance

CM13 Live

Revision

Origin: 92af28e
Pull Request: 51f684d
Server: cd201b0b4ea29aa5f463342e0c7080e040ba105f

Test Merge Updated @ 06/24/2026 05:25:22 +00:00:
Server Instance

CM13 Live

Revision

Origin: 0d7cc8b
Pull Request: 51f684d
Server: 101925d

Test Merge Updated @ 06/24/2026 05:46:18 +00:00:
Server Instance

CM13 Live

Revision

Origin: 0d7cc8b
Pull Request: 51f684d
Server: bfb6d57

Test Merge Updated @ 06/24/2026 06:51:24 +00:00:
Server Instance

CM13 Live

Revision

Origin: 100a166
Pull Request: 51f684d
Server: b6feb72ad40b7af66af241e9ece2db5cc69ce2ab

Test Merge Updated @ 06/24/2026 13:23:44 +00:00:
Server Instance

CM13 Live

Revision

Origin: 100a166
Pull Request: 51f684d
Server: 90c2a89

Test Merge Updated @ 06/24/2026 14:24:57 +00:00:
Server Instance

CM13 Live

Revision

Origin: 100a166
Pull Request: 51f684d
Server: cbfc30b

Test Merge Updated @ 06/24/2026 14:37:46 +00:00:
Server Instance

CM13 Live

Revision

Origin: 100a166
Pull Request: 51f684d
Server: 4cef207

Test Merge Updated @ 06/24/2026 15:07:53 +00:00:
Server Instance

CM13 Live

Revision

Origin: 100a166
Pull Request: 51f684d
Server: 64781ca

Test Merge Updated @ 06/24/2026 15:56:12 +00:00:
Server Instance

CM13 Live

Revision

Origin: 100a166
Pull Request: 51f684d
Server: a042cb9

Test Merge Updated @ 06/24/2026 16:57:13 +00:00:
Server Instance

CM13 Live

Revision

Origin: d667102
Pull Request: 51f684d
Server: 54543ba5a32fd0c36f0484e2ce1c8c2dd5365cb1

Test Merge Updated @ 06/24/2026 17:37:54 +00:00:
Server Instance

CM13 Live

Revision

Origin: d667102
Pull Request: 51f684d
Server: 18fe5d17e6582c94cebbde8c1f47d7d4c3c8f513

Test Merge Updated @ 06/24/2026 21:45:12 +00:00:
Server Instance

CM13 Live

Revision

Origin: 7fc39c0
Pull Request: 51f684d
Server: 9b1bacad35259c5c996d0093e37bff6aa6e4832f

Test Merge Updated @ 06/24/2026 22:26:02 +00:00:
Server Instance

CM13 Live

Revision

Origin: 7fc39c0
Pull Request: 51f684d
Server: e2a284188d963c0b028682b161a47b1ed44b67b4

Test Merge Removed @ 06/25/2026 01:43:34 +00:00:
Server Instance

CM13 Live

@cm13-issue-bot cm13-issue-bot mentioned this pull request Jun 13, 2026
@cmss13-ci cmss13-ci Bot added size/M Denotes a PR that changes 50-199 lines, ignoring generated files. and removed size/S Denotes a PR that changes 19-49 lines, ignoring generated files. labels Jun 13, 2026
fira
fira previously approved these changes Jun 14, 2026

@fira fira left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Detective-Google Detective-Google added this pull request to the merge queue Jun 22, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 22, 2026
@Drulikar Drulikar dismissed stale reviews from fira and realforest2001 via 7e23ca7 June 25, 2026 01:44
@Drulikar Drulikar requested a review from fira June 25, 2026 01:44
@Drulikar Drulikar added the Do Not Merge If you merge this PR, I will annihilate you label Jun 25, 2026
@cmss13-ci cmss13-ci Bot added size/L Denotes a PR that changes 200-799 lines, ignoring generated files. and removed size/M Denotes a PR that changes 50-199 lines, ignoring generated files. labels Jun 25, 2026
@Drulikar

Copy link
Copy Markdown
Contributor Author

DNM while testing commit is still present.

@Drulikar Drulikar added the Do Not Тestmerge I will find you and I will testmerge you into the ground if you even think about testmerging this. label Jun 25, 2026
@Drulikar

Drulikar commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

#12519 is the direction I would prefer for this signal handling, and should fix the flaky issues in this PR. If moving forward with that PR just let me know what all should be reverted here (other than the obvious of the signal stuff) e.g. the invoke next tick stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Тestmerge I will find you and I will testmerge you into the ground if you even think about testmerging this. Do Not Merge If you merge this PR, I will annihilate you Fix Fix one bug, make ten more Needs Testing Need to test it on the guinea pigs (production server) Performance the game sucks and this makes it suck less Runtime bad list x1000 size/L Denotes a PR that changes 200-799 lines, ignoring generated files.

Projects

Status: Partially Approved / Mergeable

Development

Successfully merging this pull request may close these issues.

5 participants