Skip to content

πŸ› fix(mobile-shots): phone-chrome probe credits the fixture note when counting visible rows - #17185

Closed
hivecommons-hive[bot] wants to merge 1 commit into
v5from
scanner/fix-phone-chrome-probe-375
Closed

hivecommons-hive[bot] wants to merge 1 commit into
v5from
scanner/fix-phone-chrome-probe-375

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Since #17176 merged, every dashboard PR fails mobile-shots at 375Γ—667 with tracker-phone-chrome: at least one row is fully visible with the section header at the top of the viewport (#17179, #17181, the #17180 branch, and #17176's own run all show the identical rowsFullyVisible: 0 measurement).

Why: the acceptance fixture prefixes the list with a 108px provenance note that real renders do not have. The probe already subtracts that note from its chrome measurement but not from the row-visibility check. On a 375Γ—667 phone the first fixture row is an issue with two nested PRs (~435px tall); with header + note + chrome above it, its bottom lands ~35px below the viewport purely because of the note. Without the note the row is fully visible, which is the behaviour the probe means to accept.

The fix credits the note back in the visibility check only; the chrome ≀ 160px and sticky + cols ≀ 100px assertions are unchanged, and 390Γ—844 / 430Γ—932 behave as before.

Shared-CI baseline incident for hivecommons/hive mobile-shots; this PR is the repair rather than a per-PR retry.

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Closes #17186

… counting visible rows

The acceptance fixture prefixes the Activity monitor list with a provenance
note that real renders do not have. The probe already subtracts it from the
chrome measurement but not from the row-visibility check, so on a 375Γ—667
phone the ~435px first row (issue with two nested PRs) ends below the
viewport only because of the note, and every PR since #17176 fails
tracker-phone-chrome at that viewport.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 8, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17183 ✨ dashboard: progress pill replaces the chevron strip on phones same files src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js
#17177 ✨ Activity monitor: 44px tap targets, row tools in the header, kebab as a sheet on phones same files src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js
#17191 ✨ dashboard: landscape-phone tier for the Activity monitor same files src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 8, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Superseded by #17189, which merged into v5 and fixes the same tracker-phone-chrome failure at 375Γ—667 (it accepts a tall first fixture row instead of crediting the note). Rebasing this on top would be a redundant edit to the same lines β€” closing rather than resolving the conflict. The tide error here was the merge conflict with #17189.

Incident #17186 is resolved by #17189.

@hivecommons-hive hivecommons-hive Bot closed this Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[shared-ci] mobile-shots failing across hivecommons/hive

0 participants