Repository navigation
π fix(mobile-shots): phone-chrome probe credits the fixture note when counting visible rows - #17185
π fix(mobile-shots): phone-chrome probe credits the fixture note when counting visible rows#17185hivecommons-hive[bot] wants to merge 1 commit into
Conversation
β¦ counting visible rows The acceptance fixture prefixes the Activity monitor list with a provenance note that real renders do not have. The probe already subtracts it from the chrome measurement but not from the row-visibility check, so on a 375Γ667 phone the ~435px first row (issue with two nested PRs) ends below the viewport only because of the note, and every PR since #17176 fails tracker-phone-chrome at that viewport. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Superseded by #17189, which merged into |
Since #17176 merged, every dashboard PR fails
mobile-shotsat 375Γ667 withtracker-phone-chrome: at least one row is fully visible with the section header at the top of the viewport(#17179, #17181, the #17180 branch, and #17176's own run all show the identicalrowsFullyVisible: 0measurement).Why: the acceptance fixture prefixes the list with a 108px provenance note that real renders do not have. The probe already subtracts that note from its
chromemeasurement but not from the row-visibility check. On a 375Γ667 phone the first fixture row is an issue with two nested PRs (~435px tall); with header + note + chrome above it, its bottom lands ~35px below the viewport purely because of the note. Without the note the row is fully visible, which is the behaviour the probe means to accept.The fix credits the note back in the visibility check only; the
chrome β€ 160pxandsticky + cols β€ 100pxassertions are unchanged, and 390Γ844 / 430Γ932 behave as before.Shared-CI baseline incident for hivecommons/hive mobile-shots; this PR is the repair rather than a per-PR retry.
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
Closes #17186