Skip to content

πŸ› mobile-shots: phone-chrome probe accepts a tall first fixture row - #17189

Merged
clubanderson merged 1 commit into
v5from
fix/phone-chrome-probe-tall-row
Nov 8, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/phone-chrome-probe-tall-row

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Why

Since #17176 merged, every dashboard PR to v5 fails mobile-shots with:

Activity browser acceptance failed: 375x667@2 light tracker-phone-chrome; 375x667@2 dark tracker-phone-chrome
failures: ["at least one row is fully visible with the section header at the top of the viewport"]

#17176 itself failed the same way (the job is continue-on-error), as do #17177, #17179, #17180 and #17183. Reproduced on pure origin/v5: the density fixture's first .ham-row is a work-item cluster (parent issue + child PR + decision + notes) measuring ~418px, and only 397px remain below the chrome at 375x667. No row layout can satisfy the assertion as written.

What

Verified locally with node src/scripts/dashboard-mobile-shots.mjs --viewport 375x667@2 --theme light: probe passes (firstRowPeek: 397). testdata/ only β†’ no-changelog.

The tracker-phone-chrome acceptance added in #17176 asserts that a row is
fully visible at 375x667 with the section header at the top. The density
fixture's first .ham-row is a whole work-item cluster (parent issue, child
PR, decision, notes: ~418px) and never fits the 397px left below the chrome,
so every dashboard PR fails mobile-shots at 375x667 regardless of its diff.

Keep the intent (chrome stays short, a row shows without scrolling) but
accept a first row taller than the remaining viewport when at least 120px
of it is visible. Ignore the scratch Chrome profile the harness creates.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson clubanderson added the no-changelog No changelog fragment required label Nov 8, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible β€” a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking β€”
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly β€” that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17183 ✨ dashboard: progress pill replaces the chevron strip on phones same files .gitignore
src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js
#17177 ✨ Activity monitor: 44px tap targets, row tools in the header, kebab as a sheet on phones same files .gitignore
src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js
#17191 ✨ dashboard: landscape-phone tier for the Activity monitor CONFLICT src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js
#17185 πŸ› fix(mobile-shots): phone-chrome probe credits the fixture note when counting visible rows CONFLICT src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether #17189 keeps only its .gitignore hunk and lets #17185 carry the tracker-phone-chrome.js fix, or the reverse β€” both edit the same assertion and cannot merge together.

This overlaps #17185 on src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js β€” same failure, same lines, different fix. They conflict; one must yield.

What I verified (read both diffs in full against v5):

  • Both PRs target the identical rowsFullyVisible >= 1 assertion at tracker-phone-chrome.js:55-56 (base numbering) and the identical post-#17176 failure at 375Γ—667.
  • #17185 (1 line) credits measurements.fixtureNote back in the row-visibility filter: box.bottom - measurements.fixtureNote <= innerHeight + 1. The probe at :49-52 already subtracts that note from chrome because "real renders do not have" it; #17185 extends that same correction to the row check. The "a row is fully visible" criterion is unchanged β€” it just stops counting a fixture-only 108px paragraph against it. Your own measurement (418px row, 397px remaining β†’ 21px short) is well inside that credit.
  • #17189 keeps the assertion but adds an escape: when the first row is taller than the space left, accept firstRowPeek >= 120px. That is correct as written (firstRowTooTall ⇔ row bottom below viewport; peek math is right), but it relaxes the criterion for every render, not only the fixture β€” a future layout whose first row genuinely does not fit would still pass with 120px showing, with only the separate chrome <= 160 check bounding it.

So I'd lean to #17185 for the probe hunk, because it removes the fixture artefact rather than loosening the acceptance; the header-comment rewrite here then also becomes unnecessary. The .gitignore hunk (.chrome-dashboard-mobile-shots/) is independent and worth keeping β€” nothing in #17185 covers it.

Not a defect in either PR; this is a which-one-lands call, so flagging rather than judging. I have not closed anything.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson merged commit fa453b5 into v5 Nov 8, 2026
82 of 89 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/phone-chrome-probe-tall-row branch November 8, 2026 03:11
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

hivecommons-hive Bot added a commit that referenced this pull request Nov 8, 2026
stageTrackerPopSheet called document.querySelector unconditionally, which
broke the Go-driven node harness (stage_tracker_cues_test.go) whose document
stub has no querySelector, failing TestStageTrackerOdometerNode and the
merged-chip tests. Also rebased onto v5 to pick up the phone-chrome probe
fix (#17189) for mobile-shots.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Nov 8, 2026
…n phones (#17181)

* ✨ dashboard: Activity monitor merged and queue lists open as sheets on phones

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>

* πŸ› test(dashboard): celebrate node bundle carries the pop-sheet helpers

stageTrackerMergedPopDraw now consults stageTrackerPopSheet, so every node
test built on stageTrackerCelebrateJS threw ReferenceError before reaching
its assertions.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ› dashboard: pop-sheet lookup tolerates DOM stubs without querySelector

stageTrackerPopSheet called document.querySelector unconditionally, which
broke the Go-driven node harness (stage_tracker_cues_test.go) whose document
stub has no querySelector, failing TestStageTrackerOdometerNode and the
merged-chip tests. Also rebased onto v5 to pick up the phone-chrome probe
fix (#17189) for mobile-shots.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ› dashboard: pop-sheet draw ticks consult state, not the DOM

stageTrackerMergedPopDraw/stageTrackerQueuePopDraw ran a document-wide
querySelector on every draw tick, even with the popover hidden on desktop,
and the Node harness (stage_tracker_cues_test.go) stubs document without
querySelector, failing TestStageTrackerCelebrateNode, OdometerAfterBeeNode,
FlightTargetNode and MergeSessionNode. Open sheets are now registered in
_stageTrackerPopSheets by stageTrackerPopSheetOpen and dropped by the
hiveWireDialog resolve callback; stageTrackerPopSheet reads that map, and
both draw functions early-return when the popover is hidden and no sheet
is open. The querySelector tolerance shim is no longer needed.

#17177 (stageTrackerOpenSheet) is closed unmerged, so there is nothing to
rebase onto.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. no-changelog No changelog fragment required size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant