Repository navigation
π activity monitor: light a needs-decision PR's real stage and carry the ask as a pill - #17457
Conversation
β¦the ask as a pill A PR parked at stage/085-needs-decision whose head is short of merge-ready (checks running, red or unreported; review verdict pending or asking for a person) forced a 'Needs human Β· decision' chevron into the PR in progress column while the CI and Review chevrons spun dim (#17442 under #17426; #17416 read 'Needs human Β· review' the same way). The lit chevron is now the PR's real stage: the CI track (with motion while checks run) or the Review track, wearing an amber ham-human-gated marker; PR in progress is passed and Merge queue stays empty. The ask rides as the needs-decision pill (human icon, question in the hover, decision popover on click) β the server re-adds the modifier once the head's tracks are known, and the page derives it for older payloads β and the lit track's tooltip ends 'Β· needs a person: <question>'. One lit stage per row. Only a merge-ready, queued or merging 085 keeps the gate. Fixes #17453 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
/lgtm |
|
@clubanderson: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mutation testing (advisory)No surviving mutants in changed files (or the run hit its time budget before reporting any). Advisory only; this job never blocks the PR (#17349). |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Correctness review (head The column/lit-track changes match the issue's expected behaviour and the Go β JS mirrors agree on Server adds a second human pill on 085 rows that already carry
|
β¦lds to human pills Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Read the Go and JS sides against v5 at 64320ff. The column move (stageTrackerItemColumn β trackerColumnReview, stageTrackerAnchor β 50), the running/queued change in stageTrackerNotMergeReadyEvidence, the stalled-track and ham-human-gated wiring all read correctly, and the server re-add is safe against the decided projection (applyDecidedProjection at stage_tracker_build.go:528 runs before the loop and moves a decided row off 085, so stageTrackerPersonActsOnPR is false for it).
One thing the Go side and the JS side disagree on, and the server wins:
stageTrackerApplyPersonActsOnPRPill stacks needs-decision behind pills the PR says should stand in for it β src/pkg/dashboard/stage_tracker_vocabulary.go:137-145 (this PR).
- Go only checks
slices.Contains(it.Modifiers, modNeedsDecision); otherwise it appends wheneverstageTrackerPersonActsOnPRis true β which includes theunauthorized:<step>path atstage_tracker_vocabulary.go:117-119(return !stageTrackerMergeReadyEvidence(it)), i.e. exactly the #16524 "rerun shared ci" row. - JS
stageTrackerChipsHtml(tracker-row-strip.js:966-969, this PR) only adds the pill when noSTAGE_TRACKER_HUMAN_MODSentry is present, and the comment + the newTestStageTrackerHoldProvenanceJScase assert "A pill that already names the person owed (unauthorized, hold) stands in: no needs-decision stacked behind it." - But the JS branch only runs on a payload that predates the server change. On a live spoke the modifier arrives from Go already set, so a 085 PR wearing
unauthorizedrenders bothunauthorizedandneeds human decisionpills β the stacking the JS test guards against. - Same disagreement in the other direction for
stalled:STAGE_TRACKER_HUMAN_MODS(tracker-row-strip.js:763) includes'stalled', so JS would not add the pill on a stalled row, while the new Go test (stage_tracker_item_column_test.go,pill.Modifiers = []string{modStalled}β wantsstalled,needs-decision) requires that it does. The Go test clearsReason/UnauthorizedStepso the unauthorized case is never exercised server-side.
Severity: lowβmedium β visual only, but it contradicts the rule this PR states in its own body and test, and it lands on the #16524-shaped rows this lineage of fixes is about. Suggest making Go mirror JS: skip the append when any of stageTrackerHumanMods (stage_tracker_build.go:615, same list as the JS constant) is already present β or, if stalled + pill is the intended reading, drop 'stalled' from the JS guard and say so, and add the unauthorized case to the Go test either way.
Everything else I checked (CSS token use, trackerColumnReview exists, stageTrackerNeedsHuman is per-row boolean so the re-added modifier cannot double-count, docs updated in activity-monitor.md) looks right.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
hive/ci-report β Failing acceptance (job log): Likely cause: the branch now derives the Suggested fix (one of):
The exact per-control findings are in the run's π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
β¦target Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
/lgtm |
|
@clubanderson: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
β¦ heads Signed-off-by: Andrew Anderson <andy@clubanderson.com>
β¦ stacked head Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Correctness β delta re-review at 3414abf (vs 6837568)
The delta (icon-carrying ask pill, .ham-mod-word fold-away in the stacked head, tap-target ::before, test assertion) is clean: stageTrackerDecisionTriggerHtml inserts innerHtml raw (static/index.html:24443), so the SVG + <span class="ham-mod-word"> markup renders rather than escapes; ham-mod-ask is only added when askable (tracker-row-strip.js:1028), so hold/blocked popover pills keep their words; stageTrackerIcon returns aria-hidden SVG when no label is given (index.html:18208), leaving the visually-hidden word span as the button's accessible name.
Still present (in-scope, from the previous review): src/pkg/dashboard/stage_tracker_vocabulary.go:138 β stageTrackerApplyPersonActsOnPRPill only skips when needs-decision is already present, while the client (tracker-row-strip.js:970) skips when any STAGE_TRACKER_HUMAN_MODS entry (hold, unauthorized, blocked, β¦) is present. A 085 PR with an unauthorized or hive hold modifier therefore gets a second human-owed pill (unauthorized +1) from the server that the client-only path would not add. Suggested fix:
if it == nil || !stageTrackerPersonActsOnPR(it) || slices.ContainsFunc(it.Modifiers, func(m string) bool { return slices.Contains(stageTrackerHumanMods, m) }) {
(with stageTrackerHumanMods mirroring the JS list: hold, unauthorized, needs-human, needs-decision, needs-rebase, blocked, stalled), plus a server-side test asserting a Modifiers: []string{"unauthorized"} 085 PR gains no needs-decision.
β hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88
β¦rce guard Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
/lgtm |
|
@clubanderson: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #17453
Problem
A PR parked at
stage/085-needs-decisionwhose head is short of merge-ready (checks running, red or unreported; review verdict pending or asking for a person) forced a Needs human Β· decision chevron into the PR in progress column while the CI and Review chevrons spun dim β #17442 (under #17426) today at 21:37Z with CI 3/9 running; #17416 read Needs human Β· review the same way. Yesterday's #17327 / #17334 fixed the sentinel/hold case only;stageTrackerPersonActsOnPRstill mapped bare 085 to PR in progress, andstage_tracker_build.gostripped theneeds-decisionmodifier ("the chevron says it"), so no pill existed.Fix (owner rule: a human gate is a pill on the real stage, not a stage of its own; one lit stage per row, #17337)
stageTrackerPersonActsOnPRβ CI / Review (GostageTrackerItemColumn, JSstageTrackerAnchor), never PR in progress. GostageTrackerNotMergeReadyEvidencenow counts queued/running CI as "at CI" (mirrors JS).stageTrackerTrackRunning); otherwise the stalled track lights β Review when its verdict ishuman_decision, CI when not green. The lit track wearsham-human-gated(amber outline, tokens only) and its tooltip endsΒ· needs a person: <question>.stageTrackerApplyPersonActsOnPRPillre-addsneeds-decisiononce the head's tracks are known (ordered, never duplicated, not on a merge-ready/queued row);stageTrackerChipsHtmlderives it for older payloads. The existing pill β decision popover / question tooltip is reused.activity-monitor.mdstage table, canonical rule 5, sentinel/unauthorized sections. Changelog fragment at repo root.Tests
TestStageTrackerPersonActsOnPRColumnβ π fix(sec-check): request Dependabot alerts read permission and document itΒ #17442 fixture (085 + CI running + review human_decision β CI / Review), running/queued CI cases, pill hook add / no-dup / no-op;stage_tracker_test.gopr104 now expects the pill.TestStageTrackerRows): π fix(sec-check): request Dependabot alerts read permission and document itΒ #17442 block β one lit chevron, CI trackactive ham-human-gatedwith motion, PR in progressdone, Merge queuetodo,ham-mod-needs-decisionpill, question in the CI tooltip; CI-green twin lights Review; bare-modifier payload still shows the pill. π± chore: v5 β v6 top-up (2026-11-03)Β #16524 and [selfreport] unclassified_error_repeated: rebase attempts exhausted; leaving the conflict to a personΒ #16510 expectations updated to the real-stage rule.TestStageTrackerHoldProvenanceJS: π fix(sec-check): request Dependabot alerts read permission and document itΒ #17442 pill opens the decision popover; no pill on a merge-ready twin.node --test src/pkg/dashboard/*.test.jsgreen locally; the Go-harness node scripts were replayed under node locally with the same pass set as baseline. CI is the verdict.