Repository navigation
🐛 fix: prepare independent ready PRs without completed-refresh FIFO stalls - #16052
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
clubanderson
left a comment
There was a problem hiding this comment.
Pre-commit independent read-only code review identified terminal yielded-ticket handling and fixture/contract issues; these were repaired with regressions before publication. The shared guard now serializes Hive writers of a repository/base on the same durable volume across admission through mutation; it is not proof of serialization against external human/API writers on non-strict bases. Current CI is the executable verdict per AGENTS; no local Go tests/build/lint were run. This COMMENT is not a human approving review or authorization to bypass the requested second maintainer decision. Deployment and cohort timing still need verification; five-minute PR-to-merge remains unproven.
There was a problem hiding this comment.
Style/maintainability review (head 6bf8f22). One concrete defect, two advisory consolidation notes.
1. The "completed owner yielded" log can never fire — src/pkg/github/automerge/automerge_base_preparation.go:187-189
Inside the waiting loop, st.Owner is only assigned at L197 and is immediately followed by break; before that point it is always the zero value (cleared at L155 or already empty at L157). So the condition yielded.Number != 0 && st.Owner.Number == number at L187 is unsatisfiable, and the one log line that would record a successful yield — the headline behavior of #16051 — is dead code. The only trace a successful yield leaves is the generic "selected" line at L198, which does not mention the former owner. Move the check after the loop, next to the rollback at L202:
@@ src/pkg/github/automerge/automerge_base_preparation.go
- if yielded.Number != 0 && st.Owner.Number == number {
- c.info("automerge base preparation completed owner yielded", "repo", owner+"/"+repo, "base", base, "pr", number, "former_owner", yielded.Number, "former_since", yielded.Since)
- }
reason = preparationQueued(next.Number)
break
@@
if yielded.Number != 0 && st.Owner.Number != number {
// A later ambiguous predecessor prevented admission; do not
// relinquish a completed owner's durable priority for nothing.
st.Owner = yielded
st.Waiting = slices.DeleteFunc(st.Waiting, func(w preparationCandidate) bool { return w.Number == yielded.Number })
}
+ if yielded.Number != 0 && st.Owner.Number == number {
+ c.info("automerge base preparation completed owner yielded", "repo", owner+"/"+repo, "base", base, "pr", number, "former_owner", yielded.Number, "former_since", yielded.Since)
+ }2. Guard directory derived three independent ways (advisory)
src/cmd/hive/boot_agents_deps.go:103→Join(stagelabels.DefaultStateDir, "destination-merges")src/pkg/github/automerge/automerge_destination_merge.go:19and:45→Join(Dir(preparationStore().dir), "destination-merges")(the body ofdestinationDirectoryis copy-pasted inline inacquireDestinationMergeinstead of calling it)
They coincide today only because sharedBasePreparation happens to live at DefaultStateDir/base-preparation. The sweep/relay shared-serialization property the PR body relies on silently breaks if either path is moved. Suggest: have acquireDestinationMerge call destinationDirectory(c), make it a method, and derive both the boot wiring and the engine from one exported helper in pkg/github (e.g. DestinationMergeDirectoryFor(stateDir string)) so a future move changes one place.
3. Duplicated claims/dependency block (advisory)
automerge_preparation_readiness.go:125-141 and :186-196 are the same claims + ReadIssueDependencyEvidence loop. A small preparationDependenciesClear(ctx, owner, repo, a, b) bool helper would remove the duplicate and make the "recheck after the slow reads" intent at L178-185 explicit rather than implied by repetition.
— hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. Review findings from intent-alignment (delta re-review at dec860f) — judged against #16051. Prior intent-alignment notes: the unreachable "completed owner yielded" log is fixed ( Still present — queued lane reports destination-guard contention as a (add Not re-listed (already in backlog, unchanged by the delta): the destination guard directory is only configured from boot, so non-boot Review findings from Security perspective — no in-scope blocker. Reviewed head One out-of-scope hardening note (same pattern already exists in Low — merge-guard lock files are world-readable on the shared Review findings from Intent-alignment delta re-review (head Status of prior findings: CI red (correctness) — fixed, all Still present (in-scope): queued-lane sweep reports destination-guard contention as
|
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
docs-currency — delta re-review at dec860f (previous head 6bf8f22)
Both prior docs-currency findings are still present; the delta changed neither file they cite.
-
src/docs/hive-merge.md:400-403still documents the pre-PR rule. It says "Expected pending CI/review keeps ownership … so a genuinely hung owner yields to successors", while head now yields a completed owner whose new head is known-pending (src/pkg/github/automerge/automerge_base_preparation.go:202-206,automerge_preparation_readiness.go:27-36). The audit-log list athive-merge.md:408-409also omits the newautomerge base preparation completed owner yieldedevent (automerge_base_preparation.go:220-222).docs/readiness-preparation.mdis still outsidesrc/docs/and nothing at head links to it.Release occurs on merge, closed/missing/retargeted/draft/conflicting/held heads, failed checks, rejected review, or lost admission. An unresolved refresh or active repair keeps ownership. A completed refresh whose new head has a known pending CI/review verdict can yield to an independently ready successor (see [Readiness-first preparation](../../docs/readiness-preparation.md)); the former owner keeps its ticket and original priority. Pending ownership is still bounded by the existing review-pending dwell (its default when stall detection is disabled), so a genuinely hung owner yields to successors.and add
completed owner yieldedto the audit-log list at line 408. -
docs/readiness-preparation.md:35-36says "Contention parks a caller", but contention surfaces as a sweep error.AcquireDestinationMergereturnsErrDestinationMergeBusy(src/pkg/github/destination_merge.go:88,108);guardedPRpropagates it (automerge_destination_merge.go:20-22) andtrySweepQueuedPRreports it as reason"fetch-pr"with a non-nil error (automerge_sweep_queued.go:19-24) — indistinguishable from a failed GitHub read in sweep logs/metrics. Either make the doc match the behavior, or (preferred) give it its own parked reason:--- a/src/pkg/github/automerge/automerge_sweep_queued.go +++ b/src/pkg/github/automerge/automerge_sweep_queued.go @@ func (c *Engine) trySweepQueuedPR( pr, ctx, unlock, err := c.guardedPR(ctx, owner, repo, number) if err != nil { + if errors.Is(err, hgithub.ErrDestinationMergeBusy) { + return AutoMergeSweepEvent{}, "destination-busy", nil + } if isGitHubStatus(err, http.StatusNotFound) { return AutoMergeSweepEvent{}, "gone", nil } return AutoMergeSweepEvent{}, "fetch-pr", err
and document
destination-busyas the parked reason indocs/readiness-preparation.md:35.
The delta's own doc change (docs/readiness-preparation.md:10-14, unprotected-base pending verdicts) matches automerge_preparation_readiness.go:31-36 and needs no further change.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Final repair update for 4e33461: all eleven protected required context names are now green, verified against the current PR head after the GitHub primary API quota reset. The previous two legacy fixture failures are fixed; the full matrix and unchanged 88% automerge coverage floor pass. The final additions cover actual destination-retarget and failed-fetch lease cleanup, unsupported preparation lanes, absent enforced-review providers, and incomplete file evidence. No production admission guard or coverage floor was relaxed during these fixture repairs. For transparent measurements: I cancelled only verified superseded runs of this feature branch (41216143261 and 41216859894) to release obsolete runner/concurrency occupancy; current-head and unrelated/shared runs were not cancelled. Saved watches stopped temporarily on a user-wide HTTP 403 primary quota exhaustion, then verification resumed after the documented reset without changing credentials. This remains preparation readiness, not merge readiness: no review bypass, protection change, concurrent destination merge, added runner capacity, or paid-budget change. Hive writers sharing the configured durable destination volume are serialized; independent human/external writers are not covered by that lease. @hanthor @Danathar independent maintainer review remains requested. This PR remains held and undeployed; no five-minute end-to-end result is claimed. |
There was a problem hiding this comment.
docs-currency — delta re-review at 4e33461 (previous head dec860f)
The delta is test-only (automerge_destination_merge_test.go, automerge_preparation_readiness_test.go, automerge_sweep_test.go, one line in automerge_contributor_lane_test.go). Nothing in it touches operator-facing text, so both prior docs-currency findings are still present:
src/docs/hive-merge.md:401-403still says pending CI keeps ownership. The operator doc reads "Expected pending CI/review keeps ownership, bounded by the existing review-pending dwell…", butautomerge_base_preparation.gonow lets a completed-refresh owner yield to an independent ready PR and emits a new audit eventautomerge base preparation completed owner yielded(not in the audit-log list athive-merge.md:406-408).docs/readiness-preparation.mddescribes the new behavior buthive-merge.mdis not in the PR's file list and does not link to it. Suggested patch:
--- a/src/docs/hive-merge.md
+++ b/src/docs/hive-merge.md
@@ -400,6 +400,10 @@
-Expected pending CI/review
-keeps ownership, bounded by the existing review-pending dwell (its default when
-stall detection is disabled), so a genuinely hung owner yields to successors.
+Expected pending CI/review keeps ownership against *dependent* successors,
+bounded by the existing review-pending dwell (its default when stall
+detection is disabled). A completed refresh whose new head has known pending
+CI yields to an independent, already-ready PR under the gates described in
+[readiness-preparation.md](readiness-preparation.md); see
+`automerge base preparation completed owner yielded` in the audit log.and add completed owner yielded to the audit-log sentence at :406.
src/pkg/github/automerge/automerge_sweep_queued.go:19-24—guardedPRnow acquires the per-destination merge lease (automerge_destination_merge.go:16,19-33), so lease contention or "merge destination changed while acquiring guard" (:33) surfaces in the queued-lane sweep as reasonfetch-prwith an error, while the doc describes the guard as parking a caller. Either classify the destination-guard errors to a dedicated reason here (as the contributor lane does) or document that queued-lane sweeps report contention underfetch-pr.
— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Resuming this PR at the repository owner’s explicit November 2 request. A dedicated implementation agent is addressing the queued-lane destination-guard contention classification finding, preserving the completed-refresh yielding and serialization safeguards, and refreshing exact-head validation. The deliberate hold is not being mistaken for a code failure or silently removed; any remaining genuine maintainer decision will be surfaced with the actual current diff. |
Merge current v5 while preserving existing preparation commits. Only destination-busy errors receive the preparation merge-guard reason; preserve gone and fetch failure classification with queued-lane regressions. Update operator documentation for completed-owner yielding and guard retry behavior. Signed-off-by: Andy Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether the destination guard (one flock per repo/base held across the entire per-PR sweep evaluation and across relayed merges) is the serialization boundary the hive wants, given that it parks every other writer to that base with ErrDestinationMergeBusy for the duration.
Conclusion: the destination-merge guard is implemented coherently (reentrant via the ctx lease, flock-backed, retarget-safe) and the one concrete defect I found is a reason-classification gap in two lanes. The body explicitly asks for an independent maintainer review and holds the PR; the lock semantics are merge-policy, so routing.
Finding (low) — busy guard misreported as fetch-pr in two lanes
src/pkg/github/automerge/automerge_sweep_trusted.go:20-25(trySweepSelfAuthoredPR) and:579-584(trySweepTrustedAuthorPR) now callc.guardedPR(...), which returnshgithub.ErrDestinationMergeBusywhen another writer holds the base (destination_merge.go:87-88, 104-109). Neither lane checks for it, so contention falls through toreturn AutoMergeSweepEvent{}, "fetch-pr", err.- The queued lane (
automerge_sweep_queued.go:22-24) and contributor lane (automerge_contributor_lane.go:1490-1499) map the same error tobase-preparation:merge-guard, andTestQueuedSweepDestinationGuardReasons(automerge_destination_merge_test.go:27) pins that only for the queued lane. The body says the repair was applied "narrowly" to the queued lane; the self/trusted lanes share the samev5destination with the merge-request watcher (merge_request_watcher.go:425-436), so while a relayed merge holds the lease, those sweeps will log a spurious GitHub fetch failure instead of a guard park. Suggest the sameerrors.Is(err, hgithub.ErrDestinationMergeBusy)branch in both, plus a lane test.
Verified correct
destination_merge.go:67-78— nestedAcquireDestinationMergeon the same leased ctx borrows the lease, so watcher →MergePRVia(pullrequest.go:438-449) and sweep →executeMergeEffect(automerge_sweep_queued.go:613-619) do not self-deadlock; a different destination under an existing lease errors rather than silently reacquiring.automerge_destination_merge.go:19-37—guardedPRacquires on the first fetch's base, refetches under the lease, and rejects a base that moved between fetches (retargetedcase covered atautomerge_destination_merge_test.go:31).VerifyDestinationMerge(destination_merge.go:43-57) re-checks head and base immediately before the mutation; no-op when no lease is held, so non-guarded callers keep prior behaviour.merge_request_watcher.go:431-436— busy returns withoutrecordMergeFailure, so a parked relay request is not counted as a failure attempt.
Not verified by me (scope note, not a finding): the readiness/yield logic in automerge_preparation_readiness.go (204 lines) and the automerge_base_preparation.go ownership changes — I read the guard, store schema, watcher and merge paths only. CI is the executable verdict for those, as the body states.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Owner-requested, agent-assisted decision under @clubanderson's explicit delegation for this batch; this is not a separate independent human review. Reviewed the current diff and surrounding source at the exact commit below. Inspected head: Owner serialization decision: retain the conservative per-repository/base guard across each complete per-PR evaluation for this change, including the relay; it is non-waiting on contention and must not trade fresh evidence or serialized mutation safety for throughput. Narrowing that scope is separate measured work, not required to resolve the present decision. The completed-refresh yielding, durable original priority, dependency/file/rename/head proofs and maximum-three-predecessor bound remain required. Actual remaining code fix at this current head: BOTH trySweepSelfAuthoredPR and trySweepTrustedAuthorPR still map ErrDestinationMergeBusy from guardedPR to fetch-pr. Give both the explicit base-preparation:merge-guard classification already present in the queued path, add positive contention lane regressions, and retain unrelated fetch-error reasons. Also reconcile the already-reported stale pending-owner docs while touching this path. This is an instruction to the EXISTING repair coordinator, not a competing implementation. Required gosec is genuinely FAILURE, separate from the intentional hold-only native-policy red. I read its API-owned CheckRun annotation through GraphQL: “The self-hosted runner lost communication with the server.” That is runner-loss evidence, not proof of OOM or a vulnerability finding; the detailed Scan log is still unavailable under the shared REST quota. Next coordinator should read the actual job log after ordinary quota reset, bring in the already-merged bounded-scanner fix as needed and obtain fresh exact-head security CI without lowering gates. Failure link: https://github.com/hivecommons/hive/actions/runs/41459002036/job/125331848206 . Hold stays; no merge or readiness assertion. This PR is authored by the stored account. I am not submitting an impossible native self-approval or pretending this is a separate human review. |
Merge current v5, preserving #16045 gosec concurrency 4 and its generated integration workflows, #16027 preparation rail, and existing readiness regressions. Prior-head gosec job 125331848206 explicitly reported lost self-hosted runner communication; refresh exact-head CI without weakening any gate or removing hold. Signed-off-by: Andy Anderson <andy@clubanderson.com>
Apply the owner-directed sentinel-only merge-guard reason to self-authored and trusted-author sweeps, retaining gone and unrelated fetch failures. Run the existing five reason-regression scenarios against all three guarded lanes and align pending-review documentation. Preserve the accepted whole-evaluation serialization boundary and deliberate hold. Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
Batch decision follow-through: the existing repair owner has now pushed The earlier gosec failure belongs to fa7d7bc, not this new head. After the ordinary quota reset I attempted the exact failed job log once; GitHub returned 404 BlobNotFound. The provider annotation still establishes runner communication loss only, not a proven OOM or vulnerability finding. Fresh required technical CI is running on the new head; the intentional hold/native-policy failure remains separate. Existing coordinator should obtain all exact-head results and eligible review, then dispose of the hold through the recorded owner direction. No gate/hold was removed and no merge occurred. |
|
Exact-head technical verification is complete for a7e2588: all eleven protected required context names pass; full tests/coverage, build-and-test, security/lint, and all applicable latest image jobs are terminal success/skip. Fresh security run: https://github.com/hivecommons/hive/actions/runs/41469894443 — gosec Scan used the preserved The queued/self-authored/trusted-author busy-guard reason repairs, 15 reason-fixture cases, pending-review docs and unchanged conservative readiness/serialization contract are present. Independent precommit read-only review found no significant issue; CI, not a local test run, supplies the executable verdict. Only verified superseded own-head v2 CI run 41469644597 was cancelled; current-head/shared work was not. The owner serialization decision is recorded and implemented, not reopened. This is agent-assisted status reporting, not an independent human approval. @hanthor @Danathar the actual remaining gate is eligible review/lgtm and authorized release of the deliberate hold. Hold remains; the native-policy held refusal and Tide review labels are separate from the now-green technical CI. No bypass or merge occurred. After genuine release, let the ordinary unlabeled policy event succeed, recheck this exact head, and use a guarded |
|
Precise hold reconciliation at a7e2588: there is no remaining serialization-boundary choice. The scoped owner decision explicitly accepts the conservative whole-evaluation guard: #16052 (comment) . Its requested lane fixes are implemented, and all eleven protected required contexts plus applicable latest technical jobs passed on this head. Native policy is still FAILURE because hold remains; this is not an all-CI-green claim. The existing PR-specific follow-through says “obtain all exact-head results and eligible review, then dispose of the hold through the recorded owner direction”: #16052 (comment) . Thus this is a coordinated experimental hold with a remaining review condition, not a new unresolved owner trust decision or a requirement to ask the owner to choose the same boundary again. I have not borrowed #16026 release authority or silently dropped that explicit condition. Exact remaining request: an eligible non-author reviewer should review this exact head and supply a genuine |
|
/approve High-priority owner-directed disposition at exact head a7e2588. Applying the owner’s instruction that someone else’s review is not required to this owner-authored PR, now explicitly prioritized by the owner. This is an agent-assisted coordinator decision, not an independent human review or fabricated LGTM. The owner’s serialization decision is already implemented. Existing independent precommit agent review and fresh exact-head technical CI cover the repaired queued/self/trusted busy-guard classification, 15 regression cases, conservative per-repo/base serialization, pending-review yielding documentation and preserved four-worker gosec cap. No additional code or empty commit is warranted. Releasing only this PR’s experimental hold. Wait for the ordinary native-policy replacement to pass, recheck all protected required contexts and the unchanged head, then perform a head-matched owner-authorized merge without representing an author comment as another reviewer’s verdict. No repository-wide review configuration, Sentinel, security checks, durable ownership or unrelated holds are changed. This does not claim deployment or a measured five-minute outcome. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Goal
Closes #16051.
Implement the explicitly authorized readiness-first preparation change without weakening merge authority or changing live configuration.
Measured problem
The eight-PR merged cohort had median 41m49.5s PR-open→merge, 17m29s required-green→merge, and 13m53s until a visible exact-head reviewer comment (seven comment observations). In the causal audit, #16014 retained durable preparation ownership 11:53:55–12:33:12 UTC; #16020/#16025 were independently ready but repeatedly queued behind it. Merely sorting owner-free waiting entries would not fix that episode.
Changes
Serialization boundary
The guard serializes Hive writers sharing the durable destination directory. It is not a lock on independent human/external GitHub clients. GitHub performs atomic protected-base updates, but REST offers an expected-head condition, not an expected-base condition. Universal tested-base serialization against external writers requires existing server-side strict protection/merge-queue authority; this PR does not change those policies or claim per-PR deduplication proves cross-PR serialization.
Validation and review
Independent read-only code review completed before DCO commit; its terminal yielded-ticket, shell-contract and fixture findings were addressed. Current
AGENTS.mdprohibits local Go tests/build/vet/lint: formatting was applied, and GitHub CI is the executable verdict.Added coverage for completed/unresolved ownership, repair and legacy evidence, durable restart/cross-process exclusion, concurrent yields, former-owner priority, dependency/ambiguity/read failures, incomplete pagination/counts, rename overlap, head/base movement, late dependencies, missing candidate CI/review, terminal yielded tickets, shared sweep/relay serialization and authoritative branch snapshots.
Current validation / lifecycle (November 2)
Current candidate:
a7e2588e305389f4a1ab4c81fb1eccb765132965. DCO-signed integration commitaa8b4ca5mergesv5at12ad8b3bac878c49a6bb0aa186754b4da77d8c38, preserving all prior preparation commits and the landed #16045 gosec concurrency 4 in the primary and generated integration workflows. The cap and existing coverage floor/gates are unchanged.The queued-lane finding was fixed at
fa7d7bc4; the owner-directed follow-up now applies the same narrowerrors.Is(ErrDestinationMergeBusy)classification to BOTH self-authored and trusted-author sweeps. Busy returnsbase-preparation:merge-guardwith the sentinel error; missing PRs remaingone, and unrelated initial/guarded fetch failures and retargeting retainfetch-pr. The shared five-case fixture now covers all three guarded lanes (15 cases), retaining all prior positive and safety-negative readiness regressions. Operator docs reflect completed pending CI/review yielding, retained original priority, the audit event and contention reasons. Independent read-only precommit reviews found no significant issue in the refresh or lane repair. Per AGENTS, no local tests/build/vet/lint/guards were run.Historical results are not transferred to this head:
4e334612passed the eleven protected required contexts;fa7d7bc4passed tests, coverage, build-and-test and lint but its gosec required context FAILED. The API-owned annotation for job 125331848206 says “The self-hosted runner lost communication with the server.” This establishes runner loss, not an OOM diagnosis or a code finding. After the ordinary REST quota reset, the exact job-log endpoint returned 404 BlobNotFound; API job metadata shows checkout/tool installation completed and communication was lost during Scan. No unavailable log content or OOM cause is inferred. The landed cap is integrated without lowering gates.Fresh exact-head technical validation is complete: all eleven protected required context names are SUCCESS on
a7e2588e, and all applicable latest technical jobs are terminal success/skip (including the ARM64 image). v2 Tests, v2 CI, Go Security Analysis, and image workflow are successful. The capped gosec Scan ran 15:19:49–15:21:19 UTC (90s), and its required job is green; this is not an end-to-end PR latency measurement. The full test matrix, coverage and existing 88% automerge floor pass. Only verified superseded feature-headaa8b4ca5v2 CI run41469644597was cancelled to release obsolete work; no current-head or unrelated run was cancelled.Exact remaining hold / owner gate
The owner-directed November 2 serialization decision is recorded in this PR at 15:11:09 UTC: retain the conservative non-waiting destination guard across the complete per-PR evaluation, including relays; narrowing that boundary is separate measured work. This direction is agent-assisted owner delegation, not an independent human approval. The decision comment's two remaining lane fixes are implemented in the current head; the serialization decision itself is not being silently reopened.
The deliberate operator
holdremains for the genuine eligible-reviewer/lgtm path and authorized release; fresh exact-head technical CI is now satisfied. Requested reviews from @hanthor and @Danathar remain outstanding; noapprovedorlgtmlabel or human approving review has been manufactured. Its expectednative-queue-policyrefusal is a policy gate, not a source defect; no repeat reruns, fabricated approval or bypass. Only an explicit authorized release of that hold should trigger ordinary policy reevaluation, followed by a guarded merge matching the verified head. No live config, deploy, review authority, protection, permissions, cadence or budget changes are included.For honest timing, initial failed-head rest shard execution intervals were 156s and 161s, not successful required-gate wall or PR-to-merge measurements. No deployed before/after PR-to-merge improvement has been demonstrated, and the five-minute target remains unmet. CI-duration work in #16026 remains independent from preparation correctness. Deliberate hold/testing/rework time is separate from ordinary automation latency.