Repository navigation
📖 docs: state Matrix display as an activation precondition for the Matrix channel - #16025
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Evidence bundle `#16025b158baf` sha256:a86b78b5515ebde8470d856a62506f30e40f63cc1340cb661fc472a84d37e11a — download from the dashboard or `hivectl review evidence #16025`. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Read at 483e75f. The Matrix wording is accurate today, but one of the two hunks conflicts with an open PR that already carries a superset of it, and the other is written to go stale the moment its referenced PR merges.
1. src/docs/api-reference/packs-and-acmm.md:20 — conflicts with #16012, which already adds close-read
This hunk inserts "close-read" into the decision enum after "direction". #16012 (78c30d9) rewrites the same table row and already lists …|"close-wontfix"|"close-read"|"close-issue"|…, plus a sentence describing close-read's completed-state semantics that this PR does not add. Same line, different content → this is the conflicts-with-open-pr label. Whichever lands second needs a manual rebase, and if this one lands second the enum ends up listing close-read twice. Suggest dropping this hunk and letting #16012 carry it (it is the more complete fix for #16019), or rebasing after #16012 merges.
2. src/docs/streaming-the-activity-monitor.md:194-196, 212-213 — correct now, stale on #16020 merge
Verified at the merge-base: nothing under src/pkg/dashboard/static-src/ or static/index.html reads view=matrix, so "not yet handled by the front-end" is true. #16020 (e64557d) adds exactly that — boot.js sets window.HIVE_MATRIX = kiosk && view === 'matrix' and starts hiveMatrixStart() — but touches no docs. So once #16020 merges, this page will say the renderer is "pending #16020" about a shipped feature, with nothing queued to flip it back. If this stopgap lands, #16020 (or a follow-up) should restore the present-tense wording; if #16020 is close, the stopgap may not be worth the churn.
Sequencing is the hive's call — flagging the overlap so it is not resolved by merge order alone.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Rebased onto v5: the close-read decision enum is already documented there by #16012, so that hunk is dropped. The Matrix section no longer claims the renderer is pending (#16020 may land without a docs change); instead it states the renderer as a dependency and adds an activation-checklist step to confirm the deployed build serves view=matrix before scale-up, as issue #16003 asks. Fixes #16003 Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
483e75f to
b158baf
Compare
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #16003
src/docs/streaming-the-activity-monitor.mddescribed the Matrix channel in the present tense ("It shows pushed added lines…") although no front-end servedview=matrixat the time, and the activation checklist did not require the renderer before scale-up.This PR states the Matrix display renderer (#15936 / #16020) as a dependency of the channel and adds an activation-checklist step to confirm the deployed build serves
view=matrixbefore scalingmatrix-hive-streamabove zero. The wording stays correct whether or not #16020 has landed, so nothing needs reverting afterwards.Review-fix 1/6: rebased onto
v5; theclose-readdecision-enum hunk was dropped because #16012 (merged) already documents it inpacks-and-acmm.md.