Skip to content

πŸ› fix(dashboard): read a registered contributor's PR as their clanker in the Activity Monitor - #16016

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/tracker-registry-author-kind
Oct 31, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/tracker-registry-author-kind

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #16015

Problem

On hive's spoke, #15998 (@Karibhou) showed a person icon + "Author: human" on the row while the pill read "Adopted by hive Β· @Karibhou ⬑". @Karibhou is a registered contributor-hub clanker owner; the stage engine (pkg/authorkind rule "registry") knew that and adopted the PR, but the dashboard's stageTrackerAuthorKind copy of the rules never consulted the registry, so with no author/<kind> label or β€” hive: trailer it fell through to "human (inferred)", and the row's claimant (derived from the author kind) became person.

Fix

  • stageTrackerRegistryAuthorKind: overlays the existing stageTrackerIsClankerOwner registry lookup on inferred author kinds for PR and issue rows; an author/<kind> label and a hive (App) verdict still win. New author_kind_source: "registry".
  • The claimant, row icon, tooltip and pill holder ("@Karibhou's clanker") all follow that one value β€” no second classifier.
  • Tooltip says "(agent, registered contributor)" for the registry source.
  • Docs: author_kind_source values in docs/dashboard.md; changelog fragment.

Tests

  • TestStageTrackerRegistryAuthorKind (pure overlay table) and TestStageTrackerRegisteredContributorIsClanker (seeded profile β†’ buildStageTracker β†’ PR/issue kind, source and claimant; label/App-authored PRs untouched).
  • Node fixture: tooltip wording for registry / inferred / label sources.
  • static/index.html regenerated via make dashboard-gen; full ./pkg/dashboard suite green.

… in the Activity Monitor

The tracker's author-kind rules lacked pkg/authorkind rule 6 (contributor
registry β†’ clanker), so a relay PR with no author/<kind> label or
attribution trailer read as an inferred person while the stage engine,
which does consult the registry, adopted it as a clanker's. Overlay the
registry on inferred kinds for PR and issue rows (labels and the App login
still win) with author_kind_source "registry"; the claimant, row icon,
tooltip and pill holder all follow that one value.

Fixes #16015

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 31, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16022 πŸ› Activity Monitor: author's force-push after a 071 ask reads pushed, not "no response" same files src/pkg/dashboard/stage_tracker_build.go
#16012 πŸ› fix: offer Close issue on every open tracker issue same files src/pkg/dashboard/static-src/js/tracker-row-strip.js
src/pkg/dashboard/static/index.html
#16011 πŸ› fix: explain human requirements and optional tracker actions same files src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/stage_tracker_build.go
src/pkg/dashboard/static-src/js/tracker-row-strip.js
src/pkg/dashboard/static/index.html
#16020 ✨ feature: add opt-in Matrix Rain and Cascade display same files src/pkg/dashboard/static/index.html
#15890 πŸ› dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html
#16017 πŸ› fix: copy the selected tracker issue or PR link same files src/pkg/dashboard/stage_tracker_ui_rows_test.go
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • docker (contributor)

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

@clubanderson

Copy link
Copy Markdown
Member Author

Investigated the current-head docker (contributor) failure: mirror.gcr.io returned a missing OCI layer while fetching the pinned Go base image, before source compilation. This is a registry-fetch failure, not a demonstrated defect in this PR. Requested one targeted rerun of job 124520961636 on the same head; no empty commit, source change, or merge bypass. Please reconcile the author-push hold against the rerun outcome rather than requiring an unrelated code push.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the overlay against the tree at merge-base c766074 and this looks correct to me.

  • stageTrackerRegistryAuthorKind (src/pkg/dashboard/stage_tracker.go:903-911) reproduces the precedence of pkg/authorkind.Explain (src/pkg/authorkind/authorkind.go:214-243): rules 1–2 (App login, agent/ label) both surface here as kind == hive, which the guard keeps; an explicit author/<kind> label keeps source == label; only an inferred/empty kind is overlaid. Rules 3–5 (origin/trailer/footer β†’ clanker, inferred) collapse to clanker/registry for a registered login, which matches the engine's kind, only the source string differs.
  • Both call sites (stage_tracker_build.go:304 issues, :378 PRs) run before stageTrackerIssueClaimant/PR claimant derivation, and the clanker branch of the claimant switch (stage_tracker_claimant.go:155-159) is what turns the kind into {kind: clanker, login: author} β€” so the pill holder follows the same value, as the body claims. The memoised stageTrackerIsClankerOwner (stage_tracker_claimant.go:212-226) is already the registry lookup used for claimants, so this adds no new per-build disk cost class.
  • Fixture coherence: PR 101 carries author/contributor, which is not an author/<kind> label, so stageTrackerAuthorKind returns human/inferred and the overlay is the path under test; PR 102 (author/hive, App) and PR 103 (zoe, hive-attributed, unregistered) exercise the two stand-fast branches.
  • go build ./pkg/dashboard ./pkg/authorkind is clean at 94ed43c; gofmt -l reports nothing; static/index.html regen is in the diff. CI test shards are all green on this head.

No defects found. (I can't run go test on this host; CI did.)

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read this against the v5 tree, including pkg/authorkind and the fixture the new test leans on. Looks correct to me.

  • Precedence matches the engine where it matters: authorkind.Explain (src/pkg/authorkind/authorkind.go:235) applies RelayKnown β†’ Clanker only after the App-login/agent-label/origin/trailer/footer rules, and stageTrackerRegistryAuthorKind (stage_tracker.go:903) likewise lets a label source or a hive kind stand and only overlays inferred human/clanker/empty kinds. The one divergence β€” the engine's rule 7 would say Unknown for a registered [bot] login while the tracker already reads hive, inferred at stage_tracker_build.go:302 β€” is pre-existing and not reachable in practice.
  • isClankerOwner is the same memoised findContributor closure (stage_tracker_claimant.go:212) the claimant already used, created once per rebuild at stage_tracker_build.go:100, so this adds no lookups and the row kind and claimant genuinely share one source, as the body says.
  • Fixture check: pr 101 / issue 7 are by karibhou with no author/<kind> label, pr 102 carries author/hive, pr 103 is HiveAttributed (stage_tracker_test.go:373–393) β€” so TestStageTrackerRegisteredContributorIsClanker fails without the overlay and exercises both "stronger source wins" branches.
  • static-src/js/tracker-row-strip.js and the generated static/index.html are edited identically; pkg/dashboard and its tests type-check at this head.

Behavioural note for the maintainer, not a defect: a registered contributor who opens a PR by hand (no clanker involved) now also reads as "agent, registered contributor". That is exactly what the stage engine already does when adopting, so the tracker is now consistent rather than newly wrong β€” but it is a visible change for those users.

Evidence bundle `#1601694ed43c` sha256:74a01af59a122dd33ae7128ef61f9621b5690ee0a047a0a02c75f71f05b5ce29 β€” download from the dashboard or `hivectl review evidence #16016`.

@hivecommons-hive
hivecommons-hive Bot merged commit 860fb86 into v5 Oct 31, 2026
94 of 103 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/tracker-registry-author-kind branch October 31, 2026 11:47
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› Activity Monitor: registered contributor's PR reads as a person while the hive adopts it as a clanker's

1 participant