Repository navigation
π fix(dashboard): read a registered contributor's PR as their clanker in the Activity Monitor - #16016
Conversation
β¦ in the Activity Monitor The tracker's author-kind rules lacked pkg/authorkind rule 6 (contributor registry β clanker), so a relay PR with no author/<kind> label or attribution trailer read as an inferred person while the stage engine, which does consult the registry, adopted it as a clanker's. Overlay the registry on inferred kinds for PR and issue rows (labels and the App login still win) with author_kind_source "registry"; the claimant, row icon, tooltip and pill holder all follow that one value. Fixes #16015 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
Investigated the current-head docker (contributor) failure: mirror.gcr.io returned a missing OCI layer while fetching the pinned Go base image, before source compilation. This is a registry-fetch failure, not a demonstrated defect in this PR. Requested one targeted rerun of job 124520961636 on the same head; no empty commit, source change, or merge bypass. Please reconcile the author-push hold against the rerun outcome rather than requiring an unrelated code push. |
There was a problem hiding this comment.
Read the overlay against the tree at merge-base c766074 and this looks correct to me.
stageTrackerRegistryAuthorKind(src/pkg/dashboard/stage_tracker.go:903-911) reproduces the precedence ofpkg/authorkind.Explain(src/pkg/authorkind/authorkind.go:214-243): rules 1β2 (App login,agent/label) both surface here askind == hive, which the guard keeps; an explicitauthor/<kind>label keepssource == label; only an inferred/empty kind is overlaid. Rules 3β5 (origin/trailer/footer β clanker, inferred) collapse to clanker/registry for a registered login, which matches the engine's kind, only the source string differs.- Both call sites (
stage_tracker_build.go:304issues,:378PRs) run beforestageTrackerIssueClaimant/PR claimant derivation, and the clanker branch of the claimant switch (stage_tracker_claimant.go:155-159) is what turns the kind into{kind: clanker, login: author}β so the pill holder follows the same value, as the body claims. The memoisedstageTrackerIsClankerOwner(stage_tracker_claimant.go:212-226) is already the registry lookup used for claimants, so this adds no new per-build disk cost class. - Fixture coherence: PR 101 carries
author/contributor, which is not anauthor/<kind>label, sostageTrackerAuthorKindreturns human/inferred and the overlay is the path under test; PR 102 (author/hive, App) and PR 103 (zoe, hive-attributed, unregistered) exercise the two stand-fast branches. go build ./pkg/dashboard ./pkg/authorkindis clean at94ed43c;gofmt -lreports nothing;static/index.htmlregen is in the diff. CI test shards are all green on this head.
No defects found. (I can't run go test on this host; CI did.)
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Read this against the
Behavioural note for the maintainer, not a defect: a registered contributor who opens a PR by hand (no clanker involved) now also reads as "agent, registered contributor". That is exactly what the stage engine already does when adopting, so the tracker is now consistent rather than newly wrong β but it is a visible change for those users. Evidence bundle `#1601694ed43c` sha256:74a01af59a122dd33ae7128ef61f9621b5690ee0a047a0a02c75f71f05b5ce29 β download from the dashboard or `hivectl review evidence #16016`. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #16015
Problem
On hive's spoke, #15998 (@Karibhou) showed a person icon + "Author: human" on the row while the pill read "Adopted by hive · @Karibhou ⬑". @Karibhou is a registered contributor-hub clanker owner; the stage engine (
pkg/authorkindrule "registry") knew that and adopted the PR, but the dashboard'sstageTrackerAuthorKindcopy of the rules never consulted the registry, so with noauthor/<kind>label orβ hive:trailer it fell through to "human (inferred)", and the row's claimant (derived from the author kind) becameperson.Fix
stageTrackerRegistryAuthorKind: overlays the existingstageTrackerIsClankerOwnerregistry lookup on inferred author kinds for PR and issue rows; anauthor/<kind>label and a hive (App) verdict still win. Newauthor_kind_source: "registry".author_kind_sourcevalues indocs/dashboard.md; changelog fragment.Tests
TestStageTrackerRegistryAuthorKind(pure overlay table) andTestStageTrackerRegisteredContributorIsClanker(seeded profile βbuildStageTrackerβ PR/issue kind, source and claimant; label/App-authored PRs untouched).registry/inferred/labelsources.static/index.htmlregenerated viamake dashboard-gen; full./pkg/dashboardsuite green.