Repository navigation
✨ feature: add opt-in Matrix Rain and Cascade display - #15984
thatguywob wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
There was a problem hiding this comment.
Two things in this diff break CI at head 0540164; both are one-line fixes. I read boot.js, matrix.js, sse-bootstrap.js and the failing jobs' logs.
-
boot.js:32calls barehiveMatrixStart(), which the inline-JS gate rejects.matrix.js:11defines it aswindow.hiveMatrixStart = function(){…}in a later<script>block, socheck-inline-js.jsreportsindex.html:7178:63 (block 0) 'hiveMatrixStart' is not defined [no-undef]and thesyntax-checkjob exits 123. Callingwindow.hiveMatrixStart()(the waysse-bootstrap.js:24already callswindow.hiveMatrixAttach(source)) satisfies the gate and matches the definition. -
matrix.js:201adds a baresetInterval(...), which failsTestDashboardIntervalsAreGuardedOrDocumentedandTestNavbarUpgradeBeeDoesNotAddBareSetIntervalintest (dashboard 3/4)and the shuffle jobs (dashboard_memory_guard_test.go). The repository idiom isdashboardSetInterval('<key>', fn, ms)(history-sparklines.js:21), which gives the ticker an idempotence key; a 30 s pull/label refresh would bedashboardSetInterval('matrix-pull', function(){…}, 30000).
Open question, not a finding: TestEventTriggersRejectInvalidAndUnpersistedRules also fails in test (dashboard 2/4) / (rest 3/4) at this head. Nothing in this diff touches event triggers and the merge-base is current v5, so it may be a flake — worth a re-run once the two fixes above land.
The rest reads as the body describes: everything is gated on window.HIVE_MATRIX (kiosk=1&view=matrix, boot.js:30), the SSE hook only attaches listeners, and #hive-dashboard-root (index.html:7380) exists for matrix.css:1 to hide. I have not changed anything on this PR.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@thatguywob the hive has adopted this PR ( |
|
CI triage for Shared (not this diff): PR-local (needs a push here):
🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Implement the kiosk-only renderer, shared SSE nudge subscription, authorized line pulls, pause and reduced-motion views, and source/freshness labels. Hive-Run: hivecommons#15936 Hive-Plan: hivecommons#15936 Phase 2 browser renderer Hive-Spec: hivecommons#15936#acceptance-criteria Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
0540164 to
18eb67d
Compare
|
hive-base-moved: rebased onto v5 at a19022c 🐝 Hive Agent: |
|
@thatguywob this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you ( |
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
- Guard hiveMatrixStart in boot.js inline script block to satisfy syntax-check no-undef - Route matrix poll timer through dashboardSetInterval to keep bare interval ratchet intact - Use type-scale tokens and scoped CSS properties in matrix.css to satisfy style ratchet Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
|
Addressed CI triage review feedback:
🐝 Hive Agent: |
There was a problem hiding this comment.
Read the renderer and its wiring against v5 at a19022c (static-src/js/{boot,matrix,sse-bootstrap}.js, manifest.txt, css/matrix.css) and the CI logs for head 18eb67d. The runtime wiring is sound — js/matrix.js precedes js/boot.js in manifest.txt:39-40, so window.hiveMatrixStart exists before boot.js:42 schedules it, and sse-bootstrap.js:31 only calls hiveMatrixAttach behind window.HIVE_MATRIX. Line content reaches the DOM only via textContent/canvas, as the body says. Four repo guard tests reject this head, though, and all four are caused by this diff, so it cannot land as-is:
- Dashboard Lint
syntax-check—static/index.html:7236(=boot.js:42):'hiveMatrixStart' is not defined [no-undef].matrix.js:12assigns it as awindow.property, which ESLint does not see as a declaration. Call it aswindow.hiveMatrixStart()(same patternsse-bootstrap.js:31already uses forhiveMatrixAttach). TestDashboardIntervalsAreGuardedOrDocumented(dashboard_memory_guard_test.go:60) — the baresetInterval(...)atmatrix.js:201is neitherdashboardSetInterval(nor has aclearIntervalwithin ±8 lines nor a whitelist entry. Matrix runs in the boot block, beforedashboardSetIntervalis defined inhistory-sparklines.js:21, so the practical fixes are to store the handle andclearIntervalit (e.g. onpagehide), or add a whitelist line with a reason.TestNavbarUpgradeBeeDoesNotAddBareSetInterval(navbar_upgrade_bee_test.go:360) — hard cap of 11setInterval(occurrences inindex.html; this PR makes 12. Same interval as (2); either reuse an existing tick or bump the cap in the same PR, with the reason.TestStyleRatchet(webstatic/style_ratchet_test.go:88) —matrix.cssadds raw literals above baseline: colors 141 > 135, padding 205 > 204, font-size 592 > 591. The ratchet message says to convert to tokens or lower the baselines in the same PR.
Not yours: TestEventTriggersRejectInvalidAndUnpersistedRules also fails in dashboard 1/4 / shuffle 2/3; that is the pre-existing order-dependent test being fixed in #15997.
Open question I could not settle in-tree: on today's v5 /api/matrix/lines does not exist (it is #15977, currently changes_requested). matrix.js:160 maps a 404 to "Matrix mode is not enabled"; if the dashboard answers unknown /api/ paths with the SPA index instead of 404, response.json() throws and the user sees the "unavailable · retrying" notice every 30 s instead. Worth a one-line check when #15977 lands.
I have not changed anything; the fixes above are all in this branch's own files.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Read the diff at Verified
No defects found. I have not approved or merged anything. |
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (3 waiting): fixes are handed out before new work as soon as you have capacity. |
|
CI triage for 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
CI triage @ c034aff (quality lane) — verdict: MERGE_BASE, not a PR-diff fault.
Fix: merge/rebase onto current 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Closes #15936
Adds the experimental Matrix display only at
?kiosk=1&view=matrix, implementing the Rain and Cascade portion of @hanthor's RFC #15862. Normal dashboard and kiosk entry points keep their existing behavior.The renderer pulls authorized lines from
/api/matrix/lines, subscribes tocode-linesnudges on the existing EventSource (including reconnects), and shows explicit disabled/auth/unavailable notices. It includes URL/localStorage preferences, pause and hidden-tab handling, static reduced-motion paging, and persistent source/freshness labels. Line content is rendered only through canvas or text nodes. Includes scoped CSS, generated index, changelog, and static plus Node-backed browser lifecycle regression tests.Validation: regenerated the bundle with
cd src && GOCACHE=/tmp/hive-matrix-go-cache go generate ./pkg/dashboard/webstatic/;gofmt -landgit diff --checkpassed. Tests are left to CI as required by AGENTS.md.Integration: the authorized endpoint and content-free nudge are tracked separately in #15935; until available, Matrix displays its disabled notice. This PR ships renderer source, and does not claim deployment or activation. After merge, the requested @hanthor completion notification should include the merge link and deployment/activation status.
— hive: backend=codex
🐝 Hive Agent:
contributor| SHA:054016406