Repository navigation
π fix: copy the selected tracker issue or PR link - #16017
Conversation
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Read the change against the tree at merge-base
One open question, not a defect I can demonstrate:
|
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
CI investigation: both failing dashboard 2/4 and dashboard shuffle 1/3 jobs in run 41195987700 fail only the new TestStageTrackerCopyLinkTargets fixture: the first expected clipboard write is undefined. CI Node exposes a read-only global navigator, so assignment did not install the clipboard stub. Changed the fixture to a lexical navigator (no production logic changes) and made the success assertion surface the styled error before inspecting writes. Coverage/test aggregate failures were downstream of this same fixture failure. Pushed a new head for full CI; no blind rerun or local suite execution. |
There was a problem hiding this comment.
Correctness review (read at head 9498753; go test is blocked on this pod, so CI is the test verdict)
The copy-target fix itself checks out: stageTrackerCopyLink (tracker-actions.js:2312-2317) gates on kind + number, stageTrackerMenuTargets (tracker-actions.js:780-783) resolves the new data-ham-target-key, and the kebab stays issue-targeted because stageTrackerRowToolsHtml renders outside .ham-head-pr (tracker-actions.js:82-85, tracker-row-layout.js:543-546).
One low-severity side effect of the repo change in stageTrackerLinkedPRItem (tracker-row-layout.js:62-63), advisory only:
-
Nested sub-rows now stamp
data-ham-sub-keyandstageTrackerMoveAttrs(stageTrackerItemKey(pr), ctx)with the URL-derived repo (tracker-row-layout.js:232, 238, 245), butstageTrackerColMap(tracker-motion.js:415) andstageTrackerStateMap(tracker-motion.js:78) still key linked PRs as{ repo: it.repo, kind: 'pr', number }. Before this PR both sides used the issue's repo, so they always agreed; now, for a linked PR whose URL lives in another repo (the cross-repo case this PR deliberately supports βIssueLinkedPR.Repo, pkg/github/client.go:751),ctx.moves[key]and the event-line state lookup miss the sub-row, so stage-move animation / change events for that sub-row silently stop. Cosmetic, cross-repo-only, no data impact.Suggested fix so the motion maps use the same identity as the DOM:
--- a/src/pkg/dashboard/static-src/js/tracker-motion.js +++ b/src/pkg/dashboard/static-src/js/tracker-motion.js @@ -78 +78 @@ - for (const lp of (Array.isArray(it.linked_prs) ? it.linked_prs : [])) if (Number(lp.number) > 0) put(stageTrackerItemKey({ repo: it.repo, kind: 'pr', number: lp.number }), lp); + for (const lp of (Array.isArray(it.linked_prs) ? it.linked_prs : [])) if (Number(lp.number) > 0) put(stageTrackerItemKey(stageTrackerLinkedPRItem(it, lp)), lp); @@ -415 +415 @@ - for (const lp of linked) out[stageTrackerItemKey({ repo: it.repo, kind: 'pr', number: lp.number })] = stageTrackerColIndex({ kind: 'pr', stage: lp.stage || 0 }, stages); + for (const lp of linked) out[stageTrackerItemKey(stageTrackerLinkedPRItem(it, lp))] = stageTrackerColIndex({ kind: 'pr', stage: lp.stage || 0 }, stages);
(
tracker-merged.js:776,787have the samelp.repo || item.reposhape but already fall back todata-ham-prs, so they are unaffected.)
β hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Summary
Validation
Source merge only; no live deployment.