Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@mendezr this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
stage 080-awaiting-merge-admission → 072-returned-to-contributor: optional-check-failing:relative links and anchors resolve |
|
@mendezr this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
Expose historical totals and lowercase per-login counts in contributorPool, render recent adoption details on contributor cards, and document counting semantics. Reuse the minimal profile schema from pending hivecommons#15802; adoption recording remains owned by that PR. Hive-Run: hivecommons#15795 Hive-Plan: contributor-abandoned-status Hive-Spec: hivecommons#15795#acceptance Signed-off-by: mendezr <mendezr@users.noreply.github.com>
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
17408a9 to
b56a80f
Compare
There was a problem hiding this comment.
Not a duplicate of #15802 — this is the consumer layer #15795 asked for and the body says so. One mechanical blocker, verified against both heads:
src/pkg/dashboard/contribute_abandoned.gois created by both PRs: #15802 at 110 lines (type +applyContributorAbandon/mergeContributorAbandons/recordContributorAbandon), this PR at 12 lines (theContributorAbandonRecordtype only, byte-identical to #15802's lines 13-22). Git treats that as an add/add conflict, so whichever merges second will go red on merge. Thecontribute_profiles.go:192-197field hunk is identical in both and will auto-merge.- The display path reads
p.Abandoned/p.AbandonedPRs(api_contribute.gocontributorAbandonedCounts), which nothing writes onv5until #15802 lands — so until then the badge and/api/status.contributorPool.abandonedare always zero. That matches the body's own caveat; just noting it is a real dependency, not a soft one.
Suggested: wait for #15802 to merge, rebase onto it, and drop this PR's contribute_abandoned.go and the duplicated profile fields. No other findings — the aggregation in contributorAbandonedCounts reads the persisted counter rather than len(AbandonedPRs), which is the right choice given #15802 keeps them equal on save.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read the tree at b56a80f. This looks correct to me.
- The card badge reads
c.abandoned/c.abandoned_prs(static-src/js/contributors.js:278-284). I checked the feed:/api/contributors→handleContributorsList(contribute_admin.go:69-99) serialises the fullContributorProfile, so both fields are really present once #15802 writes them. Tooltip goes throughesc(). contributorAbandonedCounts(api_contribute.go:130-142) sumsp.AbandonedoverlistContributorProfiles()with no tier/presence filter, matching the doc claim about offline/revoked profiles. Login keys lowercased.- The
ContributorProfilefields andContributorAbandonRecordhere are byte-identical to #15802's (git diff pr15802 pr15863 -- contribute_profiles.gois 4 deletions, i.e. this PR is a strict subset). So the integration is: merge #15802 first, then resolve by taking #15802'scontribute_abandoned.gowholesale and dropping this PR's 12-line stub. go build ./pkg/dashboard ./cmd/hiveclean at this head.
Not a duplicate of #15802 — different surface (status API + cards vs. recording). The conflicts-with-open-pr label is the expected textual overlap, not a semantic conflict.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@mendezr this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@clubanderson asked the hive to adopt this pull request now, without waiting for its author's hive. The hive opens its own PR carrying the author's commits and sign-off unchanged on the pass now running; this PR closes when that copy merges. |
|
stage 080-awaiting-merge-admission → 072-returned-to-contributor: conflicting |
Fixes #15795
Summary
Integration with #15802
#15802 is still open. This PR includes only its minimal profile fields and ContributorAbandonRecord declaration so it compiles against current v5 and can read persisted adoption data. Recording adoption events, deduplication, and stale-save protection remain owned by #15802. Merge the core PR first, then reconcile the overlapping profile declarations and retain its complete contribute_abandoned.go implementation. This PR does not duplicate adoption emission or recording logic.
Validation
— hive: backend=pi model=openai-codex/gpt-6.1-sol
🐝 Hive Agent:
contributor| SHA:e3ad7bad7