Skip to content

✨ stage tracker: PR sub-row names the other issues it also closes - #15834

Merged
hivecommons-hive[bot] merged 3 commits into
v5from
scanner/fix-15806
Oct 30, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v5from
scanner/fix-15806

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Why

When one PR closes several open issues, the stage tracker draws its strip once (under the lowest-numbered issue) and the other issues point at it with a "↳ #N · under #M" chip. That link only ran one way: someone reading the drawn PR row had no way to tell it also resolves the other listed issues, so a reviewer landing on #15502's row could not see that merging #15759 also clears #15503.

This makes the pairing reciprocal so the row that is drawn carries the whole story.

How

  • Server: the issue's linked_prs[] entry that is drawn here (drawn_under == issue.number) gains also_closes — the PR's other listed open issues, slimmed to number / title / url, lowest first. The "↳ … under …" listing never carries it, so the data lives exactly where the row is drawn.
  • SPA: a gray also closes #15503 pill in the lineage-pill slot beside the PR link (after the lineage / adopted-from chip when both exist) on both PR-drawing paths — the single-covering-PR issue row and the sub-row. Comma-separated for several, truncated to three numbers + +N, every number links to its issue; the hover reads this PR also resolves #15503 (title), ….
  • static-src/js/tracker-row.js and static-src/css/tracker.css are the sources; static/index.html is regenerated byte-for-byte from manifest.txt.
  • Tests: a Go build test asserting also_closes on the drawn listing only (and none on single-issue PRs / the elsewhere listing), and a node test covering the pure chip (escaping, truncation, links) and its placement on the issue row, the sub-rows, and alongside a lineage chip.

Closes #15806

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson

A PR that closes several listed open issues is drawn once, under the
lowest-numbered one; the other issues chip '↳ #N · under #M' at it, but
the drawn row never said it covered them. The listing drawn here now
carries also_closes (number, title, url of the other listed issues) and
the PR's line wears a gray 'also closes #B' pill — three numbers then
+N, every number a link, the hover naming each title.

Closes #15806

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15804 ✨ Show the upgrade animation for every roll (announce + SIGTERM fallback) same files src/pkg/dashboard/static/index.html
#15859 ✨ feature: add abandoned counts to contributor leaderboards same files src/pkg/dashboard/static/index.html
#15792 🐛 fix: classify repeated lane-gate and trusted-author sweep warnings in selfreport same files src/pkg/dashboard/static/index.html
#15842 ✨ Add Apple MLX local inference and first-class ClankeR onboarding same files src/pkg/dashboard/static/index.html
#15853 ✨ Complete native GitHub queue CI and policy integration same files src/pkg/dashboard/static/index.html
#15854 🐛 fix: preserve merge notifications across reloads and show countdown same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#15849 ✨ Show online ClankeR IDs on the Contributors count pill same files src/pkg/dashboard/static/index.html
#15866 ✨ Animate live tracker, contributor and Knowledge count deltas same files src/pkg/dashboard/static/index.html
#15771 🌱 refactor: split tracker row source CONFLICT src/pkg/dashboard/static-src/js/tracker-row.js
#15871 🐛 fix: stage tracker gives immediate Let-hive-decide feedback and says why a human is wanted same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static/index.html

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:build-and-test

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/stalled In its current stage longer than expected labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:Sign-off survives the squash

@hivecommons-hive hivecommons-hive Bot added stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read src/pkg/dashboard/stage_tracker_links.go at a19402d end to end plus the nesting loop it hangs off. Looks correct to me.

What I verified:

  • stage_tracker_links.go:394-396 — AlsoCloses is set only on the listing where pr.NestedUnder == it.Number, after the first pass has finalised NestedUnder (:358-360, lowest issue wins), so the "↳ under #M" listings never carry it and the data lands exactly on the drawn row, as the body says.
  • stage_tracker_links.go:417 — soft links are excluded via stageTrackerLinkSoft (:92, Via != "" && Via != fixes). The reverse-link branch at :363 preserves the PR's own Via when the issue already appears in pr.LinkedIssues, and the appended entry at :365 only arises from the issue side's closing-reference list, so a Refs #N never reads as "also closes". The Via: PRLinkViaRefs case in stage_tracker_also_closes_test.go:49 pins that.
  • tracker-row.js:1113 — !superseded && … ? chips : (lineage || null): ternary binds looser than &&, so a superseded original gets neither pill, matching the comment above it. static/index.html carries the same two hunks as static-src.

No findings; advisory only.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 72f77380e

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit bfbf8d2 into v5 Oct 30, 2026
80 of 82 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15806 branch October 30, 2026 19:47
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#1583472f7738` sha256:312ba5e1b072f014a2d6d241986b217f1231feb7394c14afda70f58faa0928d6 — download from the dashboard or `hivectl review evidence #15834`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet

Projects

None yet

0 participants