Repository navigation
✨ stage tracker: PR sub-row names the other issues it also closes - #15834
Conversation
A PR that closes several listed open issues is drawn once, under the lowest-numbered one; the other issues chip '↳ #N · under #M' at it, but the drawn row never said it covered them. The listing drawn here now carries also_closes (number, title, url of the other listed issues) and the PR's line wears a gray 'also closes #B' pill — three numbers then +N, every number a link, the hover naming each title. Closes #15806 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:build-and-test |
|
stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:Sign-off survives the squash |
There was a problem hiding this comment.
Read src/pkg/dashboard/stage_tracker_links.go at a19402d end to end plus the nesting loop it hangs off. Looks correct to me.
What I verified:
stage_tracker_links.go:394-396—AlsoClosesis set only on the listing wherepr.NestedUnder == it.Number, after the first pass has finalisedNestedUnder(:358-360, lowest issue wins), so the "↳ under #M" listings never carry it and the data lands exactly on the drawn row, as the body says.stage_tracker_links.go:417— soft links are excluded viastageTrackerLinkSoft(:92,Via != "" && Via != fixes). The reverse-link branch at:363preserves the PR's ownViawhen the issue already appears inpr.LinkedIssues, and the appended entry at:365only arises from the issue side's closing-reference list, so aRefs #Nnever reads as "also closes". TheVia: PRLinkViaRefscase instage_tracker_also_closes_test.go:49pins that.tracker-row.js:1113—!superseded && … ? chips : (lineage || null): ternary binds looser than&&, so a superseded original gets neither pill, matching the comment above it.static/index.htmlcarries the same two hunks asstatic-src.
No findings; advisory only.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Why
When one PR closes several open issues, the stage tracker draws its strip once (under the lowest-numbered issue) and the other issues point at it with a "↳ #N · under #M" chip. That link only ran one way: someone reading the drawn PR row had no way to tell it also resolves the other listed issues, so a reviewer landing on #15502's row could not see that merging #15759 also clears #15503.
This makes the pairing reciprocal so the row that is drawn carries the whole story.
How
linked_prs[]entry that is drawn here (drawn_under == issue.number) gainsalso_closes— the PR's other listed open issues, slimmed to number / title / url, lowest first. The "↳ … under …" listing never carries it, so the data lives exactly where the row is drawn.also closes #15503pill in the lineage-pill slot beside the PR link (after the lineage / adopted-from chip when both exist) on both PR-drawing paths — the single-covering-PR issue row and the sub-row. Comma-separated for several, truncated to three numbers ++N, every number links to its issue; the hover readsthis PR also resolves #15503 (title), ….static-src/js/tracker-row.jsandstatic-src/css/tracker.cssare the sources;static/index.htmlis regenerated byte-for-byte frommanifest.txt.also_closeson the drawn listing only (and none on single-issue PRs / the elsewhere listing), and a node test covering the pure chip (escaping, truncation, links) and its placement on the issue row, the sub-rows, and alongside a lineage chip.Closes #15806
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson