Skip to content

πŸ› fix: carry density and shift through the display Copy link - #15993

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-15983
Oct 31, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-15983

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #15983

An operator who opened a wall screen with ?display=1&density=tv&shift=1 lost both flags when using the πŸ”— Copy link control, because the link builder only carried display, am.* and theme. density=tv and shift=1 are rendering-only flags (like theme), so carrying them is safe: they are copied only when present and valid.

  • stageTrackerDisplayLinkUrl now keeps density=tv and shift=1
  • test added in stage_tracker_display.test.js
  • docs: Copy link row in streaming-the-activity-monitor.md updated
  • changelog fragment added

Note: the committed static/index.html was edited with the identical change by hand (tests/build not run locally); if make stale-check fails in CI, regenerate with cd src && go run ./pkg/dashboard/webstatic/gen -src pkg/dashboard/static-src -out pkg/dashboard/static/index.html.

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 31, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15984 ✨ feature: add opt-in Matrix Rain and Cascade display same files src/pkg/dashboard/static/index.html
#15890 πŸ› dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html
#15849 ✨ Show online ClankeR IDs on the Contributors count pill same files src/pkg/dashboard/static/index.html
#15991 πŸ› fix: skeleton preview, plan cache and human reasons for Let hive decide same files src/pkg/dashboard/static/index.html
#15985 πŸ“– docs: document Matrix streaming and add inactive overlay same files src/docs/streaming-the-activity-monitor.md

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read against v5; this looks correct to me.

  • tracker-popout.js:353-354 copies density/shift only on the exact values tv and 1, which is precisely what boot.js:38 accepts (density=...==='tv'?'tv':'', shift=...==='1'), so the copied link reproduces the same rendering and any other value is still dropped along with every unknown param. The token=x assertion in the new test covers the leak boundary the function comment promises.
  • The hand-edited static/index.html is in sync: go run ./pkg/dashboard/webstatic/gen ... -check exits 0 at 4a388d0, and node --test stage_tracker_display.test.js passes 17/17 locally.
  • Docs row in streaming-the-activity-monitor.md:203 now matches the builder.

Scope matches #15983; nothing unrelated in the diff.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 52e69be into v5 Oct 31, 2026
85 of 92 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15983 branch October 31, 2026 08:02
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#159934a388d0` sha256:ae357345c5451312dbe231a42f8dc62c90b04b66d1a0685561a6a2780c94becf β€” download from the dashboard or `hivectl review evidence #15993`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[reviewer] Review backlog (docs-currency): Copy link drops density/shift; new docs table does not say so

0 participants