Repository navigation
π fix: carry density and shift through the display Copy link - #15993
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Read against v5; this looks correct to me.
tracker-popout.js:353-354copiesdensity/shiftonly on the exact valuestvand1, which is precisely whatboot.js:38accepts (density=...==='tv'?'tv':'',shift=...==='1'), so the copied link reproduces the same rendering and any other value is still dropped along with every unknown param. Thetoken=xassertion in the new test covers the leak boundary the function comment promises.- The hand-edited
static/index.htmlis in sync:go run ./pkg/dashboard/webstatic/gen ... -checkexits 0 at4a388d0, andnode --test stage_tracker_display.test.jspasses 17/17 locally. - Docs row in
streaming-the-activity-monitor.md:203now matches the builder.
Scope matches #15983; nothing unrelated in the diff.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #15983
An operator who opened a wall screen with
?display=1&density=tv&shift=1lost both flags when using the π Copy link control, because the link builder only carried display, am.* and theme.density=tvandshift=1are rendering-only flags (liketheme), so carrying them is safe: they are copied only when present and valid.stageTrackerDisplayLinkUrlnow keepsdensity=tvandshift=1Note: the committed
static/index.htmlwas edited with the identical change by hand (tests/build not run locally); ifmakestale-check fails in CI, regenerate withcd src && go run ./pkg/dashboard/webstatic/gen -src pkg/dashboard/static-src -out pkg/dashboard/static/index.html.β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88