Repository navigation
✨ dashboard: onboarding and GitHub App errors point to the Getting Started guide - #15774
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:build-and-test |
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
There was a problem hiding this comment.
One concrete blocker, plus a note on the other red checks.
src/pkg/dashboard/static/index.html is generated, and this PR edits it directly. TestIndexHTMLIsGenerated (src/pkg/dashboard/webstatic/indexgen_test.go:20-29) rebuilds index.html from static-src/ via ConcatIndex and fails if the committed file differs. The diff touches static/index.html but no file under static-src/, so the test fails deterministically — it did on test (rest 3/4) three times in run 41068242534 with: "static/index.html differs from the concatenation of static-src/ … Edit the per-area sources in static-src/, then run make dashboard-gen (go generate ./pkg/dashboard/webstatic/) and commit both." Fix: move the WELCOME_STEPS/onboarding edits into the owning static-src/ file(s), run make dashboard-gen, and commit both. The Go side (onboarding.go ClassifyOnboardingMessage / onboardingKindGuideStep) is unaffected by this.
Not this diff's fault: golangci-lint died fetching the action (Unexpected HTTP response: 500) and coverage fails downstream of the test shard, so both should clear once the shard is green. The conflicts-with-open-pr label is a separate rebase question for whoever lands first.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
The Go side reads correctly to me — onboardingIssuesFor is pure and runs after the GitHub App / repo-target fields are final in UpdateStatusIfFresh (server.go:2696-2702), and the body matches the diff. Two things in the diff itself break CI, and one red check is not yours:
static/index.htmlis generated (src/pkg/dashboard/webstatic/indexgen_test.go:15-29):TestIndexHTMLIsGeneratedconcatenatesstatic-src/and compares byte-for-byte. This PR edits the output (src/pkg/dashboard/static/index.html, +105/-?) and touches nothing understatic-src/, sotest (rest 3/4)fails with "first difference at line 1193, byte 7". Move the SPA edits into the matchingstatic-src/area, runmake dashboard-gen, commit both.- Style ratchet (
style_ratchet_test.go:88): your change drops inlinestyle=attributes on the operator page from 1427 to 1425, which is good, but the ratchet requires loweringstyleRatchetBaselines["operator static/index.html"].inlineStylesto 1425 so it keeps biting. golangci-lintis an infrastructure failure (action download returned HTTP 500 atgolangci-lint-actionsetup, job 124106209522) — re-run, not a diff problem.coverageis only red because the rest shard failed.
Open question, not a finding: onboardingIssuesFor emits no-agents whenever cfg != nil && len(status.Agents) == 0 (onboarding.go:171). If any status update can arrive before the agent list is populated, a fresh hive would briefly show the "add an agent" tip; worth a glance at the first-publish path if that matters to you.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
hive/ci-report (scanner): three distinct causes at ccb4968.
No push from the hive on an author-owned branch; a new head re-runs everything. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
ccb4968 to
637277a
Compare
|
stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#15748:2/9:0/0:main.go,main_sweeps.go,auth.md,dashboard-misc.md,+14 |
|
stage 080-awaiting-merge-admission → 050-review-pending: check-pending |
|
stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:Sign-off survives the squash |
|
stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:build-and-test |
|
@clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
…arted guide Server classifies setup problems (GitHub App not installed / wrong installation / permissions / credentials, GHES base URL, repo target, no projects, no agents, proxy token) as onboardingIssues[] on the status payload, onboarding/guideStep on system alerts and deep-health checks. The SPA appends a 'New hive? Open the 🧭 Guide → step …' link to every surface rendering them, openWelcomeDialog(stepId) jumps to the step, the Guide chip stays visible while any onboarding issue is active, and the guide's GitHub App step prints the concrete GHES-aware install URL. Closes #15772 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…ml is generated) Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
bced805 to
1c471a3
Compare
|
stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:coverage |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #15772
A new GHE operator saw
GitHub App permission issue: GitHub App 5686 has no installation for this org — install it …and had to ask Slack for next steps, the install URL, and where the welcome checklist / Governor Config were. The dashboard now answers that itself.What changes
Server (
pkg/dashboard/onboarding.go)ClassifyOnboardingMessage(msg)— table of message →kind+guideStep(GitHub App not installed / wrong installation / permissions / credentials, GHES base URL, repo target, no projects, no agents, proxy token). Message text is never altered.StatusPayload.onboardingIssues[] {kind, guideStep, message}derived after the GitHub App / repo-target fields are final;SystemAlert.onboarding/guideStepset inAddSystemAlert;deepHealthchecksgithub_auth/repo_target(and/health) carryonboarding: true, guideStep.SPA
readrole), onboarding system-alert rows, and the health-pill tooltip lines.openWelcomeDialog(stepId)expands + scrolls to a step; the tip link uses it.onboardingIssuesis active, even after the checklist was dismissed (read-only role stays gated).githubAppInstallURL, GHES-aware); on an enterprise host with no slug it says what to configure instead of pointing at github.com.github_app_changedrows get the same pointer.Governor Config missing for the operator: not a bug — the Guide, its entry points and the settings gear all require a non-
readrole from/api/role. The tip and docs now say so.Tests:
onboarding_test.go(classifier table, kind→step,onboardingIssuesForstates, status payload + deep-health JSON, system-alert classification). Docs: operator-reference, getting-started; changelog fragment.Screenshots (local run against the hive spoke with a faked not-installed GHE state)
GitHub App banner + system alert with the guide tip; Guide chip visible in the navbar:
Clicking the tip opens the guide at the GitHub App step with the concrete github.ibm.com install URL: