Skip to content

feat(extensions): save browser-local extension favorites - #3848

Closed
tang-vu wants to merge 5 commits into
Osmantic:public-betafrom
tang-vu:feat/extension-favorites-20260908
Closed

tang-vu wants to merge 5 commits into
Osmantic:public-betafrom
tang-vu:feat/extension-favorites-20260908

Conversation

@tang-vu

@tang-vu tang-vu commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Why this matters

Operators can save frequently used extensions and filter their library without installing or enabling a service. Favorites are browser-local, not server configuration.

Current public-beta integration

Updated this original PR instead of opening a duplicate. Reconciled the compact portal and library tabs introduced since the original branch. Favorites now work in compact and full views, intersect installed/available/status/category/search filters, and do not hide starter collections. Pagination resets when the favorites filter changes. Storage denial retains usable session favorites with an explicit notice.

Overlap check

Searched open and closed upstream PRs for extension favorites and the changed Extensions.jsx/useExtensionFavorites paths. This is the canonical favorites PR. Existing #5238 (ports), #5067 (console), #5065 (update confirmation), #4982 (credentials), #4961 (Aider) and #4207 (portal layout) cover different behavior and their beta changes are retained.

Validation

  • npm test -- --maxWorkers=2 src/pages/Extensions.test.jsx src/pages/Extensions.updateConfirmation.test.jsx src/pages/Extensions.credentials.test.jsx src/pages/ServiceLaunchPorts.test.jsx: 35 passed.
  • Public page regressions cover persistence/remount, blocked storage, compact tabs/collections, and absence of lifecycle requests.
  • Focused ESLint: zero errors; existing JSX unused-variable warnings remain. Focused pre-commit and git diff upstream/public-beta --check: passed.
  • Batch baseline: dashboard 1,232 tests, lint and production build passed. Linux smoke and installer simulation passed. Full make gate/BATS have existing environment/fixture failures; this is not a clean full-gate claim. No live browser or hardware qualification is claimed.

Tradeoffs and rollback

Saved IDs may outlive removed catalog entries; they do not create services. Browser-local state is deliberately not synchronized. Revert the feature to remove controls; the inert localStorage key may be cleared independently. No service restart or data migration required. Ready for independent review, not approval to merge.

Follow-up regression receipt

At b2c4e2d20aeeca49f5eb087d2a5f5ef4f9aef7f0, rendered-page cases additionally cover malformed JSON, null and wrong-shaped stored favorites. npm test -- --maxWorkers=2 src/pages/Extensions: 33 passed. This narrower command omits ServiceLaunchPorts, so its count is not directly comparable to the earlier 35-test command. Focused hooks and ESLint passed.

Final beta-batch receipt — 2026-09-16

Candidate: b2c4e2d20aeeca49f5eb087d2a5f5ef4f9aef7f0. GitHub check audit at 11:07:47 UTC: 37 successful, 4 skipped, 0 failed, 0 pending, matching this exact head; OPEN, public-beta base, Ready (not Draft). Skipped checks are not counted as passed tests.

The combined integration head, 5b9877184ceab0751c6c9fe3564c73303e78f0a3, contains all 30 exact candidate heads on public-beta 3c186f3f12ba21dad7b7266ec5449393529abb00. At this exact final SHA: full dashboard 171 files / 1,274 tests passed; full dashboard API 3,124 passed, 2 skipped; advice boundary suite 23 passed; Bark request/legacy-empty cases 9 passed; changed-file secret/key/size hooks and diff check passed. Shell-only hooks had no matching changed files.

Additional combined checks ran at predecessor 28adf1aa5c0710d3c0de13df7870629e24977fec: Token Spy 130 passed, 1 skipped; CLI contracts 16 passed; real backup/restore round trip passed; Open Interpreter HTTP/runner cases 4 passed; make lint smoke simulate, frontend lint (zero errors, 624 warnings) and production build passed. The only final-head differences are two test files (advice dialog fixtures and Bark's empty-text expectation); production files are identical. These results are not live GPU/model or service rollout qualification.

Qualified merge order: #5490 → #5494 → #5495 → #3848 → #3846 → #3845 → #3844 → #3843 → #3841 → #3838 → #3837 → #3836 → #3835 → #3834 → #3809 → #3808 → #3807 → #3806 → #3804 → #3803 → #3802 → #3801 → #3800 → #3712 → #3711 → #3710 → #3709 → #3708 → #3852 → #3849. Branches are independently useful. Shared-file merging required only preserving the union of four adjacent Makefile registrations: provider-probe redirects, healthcheck error-body, Milvus persistence and healthcheck latency. Production code in these 30 merged without manual conflict resolution. External advice/Bark overlaps have separate pairwise receipts in #5494/#3808. Recheck the combined tree if other shared-file PRs land first; do not drop test registrations.

Full release qualification remains not green: baseline make gate fails a no-sudo Docker fallback fixture; 5 of 428 BATS cases fail in this environment; all-files private-key scanning flags two pre-existing dummy-key fixtures. No checks were disabled. CI success and Ready status do not replace independent human review, especially for auth backups and Milvus data migration. No upstream merge or deployment was performed.

@tang-vu
tang-vu changed the base branch from main to public-beta September 16, 2026 10:18
This was referenced Sep 16, 2026
This was referenced Sep 16, 2026
@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants