Skip to content

feat(dashboard): focus GPU topology links - #3712

Closed
tang-vu wants to merge 2 commits into
Osmantic:public-betafrom
tang-vu:feat/gpu-topology-focus
Closed

tang-vu wants to merge 2 commits into
Osmantic:public-betafrom
tang-vu:feat/gpu-topology-focus

Conversation

@tang-vu

@tang-vu tang-vu commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Why this matters

In a multi-GPU topology matrix, operators need to trace one device's links without losing the surrounding matrix or changing assignments.

Feature and overlap check

Native GPU chip buttons highlight the selected row/column links, dim unrelated cells and toggle back to the full view. Focus state is local and validates against the current device count. Updated the original PR onto beta. Searched all-state topology-focus and TopologyView/GPUMonitor paths. #4947 improves narrow layouts; this adds selection, not another layout variant. GPUMonitor's production Topology tab renders this component.

Validation

npm test -- --maxWorkers=2 src/components/TopologyView.test.jsx: 2 passed, covering link emphasis/reset and keyboard Enter with focus retention. Focused ESLint/pre-commit/diff check passed. Synthetic GPU topology only, not a live NVLink/MIG test. Baseline dashboard tests/build and smoke/simulation passed; full gate/BATS have known failures.

Rollback

No host call, reassignment or persistence. Unknown links stay unknown; emphasis is not a performance claim. Revert removes the focus controls. Ready for independent review.

Final beta-batch receipt — 2026-09-16

Candidate: 16f2b5909597c0b8e0b5e8af9a34bf6e4fc5849c. GitHub check audit at 11:07:47 UTC: 37 successful, 4 skipped, 0 failed, 0 pending, matching this exact head; OPEN, public-beta base, Ready (not Draft). Skipped checks are not counted as passed tests.

The combined integration head, 5b9877184ceab0751c6c9fe3564c73303e78f0a3, contains all 30 exact candidate heads on public-beta 3c186f3f12ba21dad7b7266ec5449393529abb00. At this exact final SHA: full dashboard 171 files / 1,274 tests passed; full dashboard API 3,124 passed, 2 skipped; advice boundary suite 23 passed; Bark request/legacy-empty cases 9 passed; changed-file secret/key/size hooks and diff check passed. Shell-only hooks had no matching changed files.

Additional combined checks ran at predecessor 28adf1aa5c0710d3c0de13df7870629e24977fec: Token Spy 130 passed, 1 skipped; CLI contracts 16 passed; real backup/restore round trip passed; Open Interpreter HTTP/runner cases 4 passed; make lint smoke simulate, frontend lint (zero errors, 624 warnings) and production build passed. The only final-head differences are two test files (advice dialog fixtures and Bark's empty-text expectation); production files are identical. These results are not live GPU/model or service rollout qualification.

Qualified merge order: #5490 → #5494 → #5495 → #3848 → #3846 → #3845 → #3844 → #3843 → #3841 → #3838 → #3837 → #3836 → #3835 → #3834 → #3809 → #3808 → #3807 → #3806 → #3804 → #3803 → #3802 → #3801 → #3800 → #3712 → #3711 → #3710 → #3709 → #3708 → #3852 → #3849. Branches are independently useful. Shared-file merging required only preserving the union of four adjacent Makefile registrations: provider-probe redirects, healthcheck error-body, Milvus persistence and healthcheck latency. Production code in these 30 merged without manual conflict resolution. External advice/Bark overlaps have separate pairwise receipts in #5494/#3808. Recheck the combined tree if other shared-file PRs land first; do not drop test registrations.

Full release qualification remains not green: baseline make gate fails a no-sudo Docker fallback fixture; 5 of 428 BATS cases fail in this environment; all-files private-key scanning flags two pre-existing dummy-key fixtures. No checks were disabled. CI success and Ready status do not replace independent human review, especially for auth backups and Milvus data migration. No upstream merge or deployment was performed.

@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants