Skip to content

fix(downloads): report accurate progress without overlapping polls - #3040

Closed
tang-vu wants to merge 4 commits into
Osmantic:public-betafrom
tang-vu:fix/download-progress-reported-percent
Closed

tang-vu wants to merge 4 commits into
Osmantic:public-betafrom
tang-vu:fix/download-progress-reported-percent

Conversation

@tang-vu

@tang-vu tang-vu commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Report backend progress for unknown-size downloads and serialize bounded progress observations.

Why this matters

Unknown-size model transfers currently remain at 0% despite a verified backend percentage, while slow status reads can stack overlapping polls.

Root cause: The hook derives percentage solely from byte totals and starts every scheduled/manual request without admission or a full-body deadline.

Behavioral invariant: Known byte totals take precedence; otherwise finite backend percent is clamped to 0–100. One owned observation runs at a time, and a stalled or disposed body cannot block recovery or overwrite fresh progress.

Implementation and compatibility

Use a per-request controller as the synchronous owner, race headers plus JSON against a 15-second deadline, cancel on cleanup and release only the current owner. Preserve cancellation acknowledgement behavior and terminal transfer receipts.

This updates the original canonical PR onto public-beta at 3c186f3f12ba21dad7b7266ec5449393529abb00; it does not create a competing replacement. The shared browser code applies to Linux, macOS and Windows installations. There is no persisted schema migration. Rollback is a revert/rebuild of the dashboard; server lifecycle and authorization remain backend-owned.

Overlap check

Searched open and closed upstream PRs by semantic keywords and inspected the complete 1,010-entry public-beta changed-file index on 2026-09-16. Searched production paths: ods/extensions/services/dashboard/src/hooks/useDownloadProgress.js.

Relevant same-file results: #3803 (open: fix(dashboard): keep dismissed download errors dismissed across polling), #4873 (merged: fix(downloads): bound cancellation acknowledgements), #4267 (merged: fix(dashboard-api): sanitize throughput metric samples in agent monitor), #4266 (merged: fix(dashboard-api): guard null nodes payload in cluster status refresh)

#3316 supplies visible status errors; this PR supplies serialization/progress calculation. #4873 owns cancellation acknowledgement deadlines and #3803 owns dismissed terminal errors. The combined integration preserves each contract with an explicit merge recipe.

Regression and validation

Candidate commit: 13b8144a8bc3dd18dcbb9777c3b5fe49fbe8952f.

  • From ods/extensions/services/dashboard: npx vitest run src/hooks/__tests__/useDownloadProgress — 18 passed.
  • Four baseline failures demonstrate unknown-size percentage, duplicate manual/interval observations and stalled-body recovery. All 18 candidate progress and cancellation tests pass.
  • Changed-file ESLint, git diff --check, and pre-commit secret/private-key/large-file checks pass. Existing lint warnings are not errors.
  • Clean beta baseline: full dashboard 1,232 tests passed, lint and production build passed on Windows Node 24.14.1. CI uses Node 20 and validates Linux/macOS/Windows. No browser-on-hardware or live GPU/model-service claim is made by these mocked HTTP/UI tests.
  • Broad make gate on a Linux-native clean beta checkout stops at the existing no-sudo Docker fallback contract (2 failures under the root test environment). The Windows-mounted copy additionally exposed CRLF-sensitive Hermes fixture assertions. Full-tree pre-commit finds existing dummy private-key test fixtures and Windows lacks awk for the heredoc hook; the candidate's scoped secret/key/size hooks pass. These limitations are not represented as successful runtime validation.

Review readiness and batch integration

Implementation and focused checks are complete; this PR is Ready for independent review. CI limits below remain visible and no upstream merge or deployment has been performed.

Exact-head CI at 2026-09-16T13:33:01.8060875Z for 13b8144a8bc3dd18dcbb9777c3b5fe49fbe8952f: 37 successful checks; 0 failed; 0 pending; 4 skipped review/security jobs (not counted as passes).

All 37 executed current-head checks completed successfully; four review/security jobs were skipped. This establishes automated review readiness, not live hardware validation, an independent human review, or approval to merge.

All 20 exact candidate commits were merged into synthetic integration d3c05b74ddfa from beta 3c186f3f12ba21dad7b7266ec5449393529abb00. That exact head passed 1,279 tests across 167 files, full ESLint (0 errors; 618 existing warnings), production build, scoped secret/private-key/large-file hooks and git diff --check on Windows Node 24.14.1. These are mocked browser/HTTP checks, not live GPU or deployment evidence.

Verified merge order: #3044 → #3046 → #3025 → #3038 → #3043 → #3050 → #3312 → #3313 → #3315 → #3316 → #3376 → #3041 → #3042 → #3051 → #3065 → #3062 → #3039 → #3040 → #3049 → #2780.

Merge guidance for this scope: With #3316, retain the controller-owned deadline/cleanup and percentage calculation, add its decoded status-error receipt inside the same race, and publish only for the current controller. Preserve both test sets and its Models statusError surface. External #3803 conflicts only in the progress test file; preserve dismissal coverage on integration.

The only textual conflicts inside the selected batch were #3316/#3040 (download hook plus tests) and #3046/#2780 (tests only). Use the linked integration commit as the reviewed resolution reference. Each PR remains independently based on beta; if merging them separately or squashing, reapply the relevant resolution and rerun affected suites. Outside-batch checks used git merge-tree only: #3846/#3848/#3841/#3843 merged textually, while #3803/#4356/#5276/#5125 conflicted. Textual compatibility alone does not establish runtime compatibility.

Additional clean-beta Linux checks: make lint, make smoke, and make simulate pass. make bats has five baseline environment failures (WSL classification, root permissions/preflight, and a 15 GB free-space boundary), in addition to the full-gate limitations described above. Installer/backend sources are unchanged by this batch. Rollback remains a revert and dashboard rebuild; no stored schema or backend lifecycle migration was introduced.

@tang-vu tang-vu changed the title fix(downloads): honor reported progress percent fix(downloads): report accurate progress without overlapping polls Aug 23, 2026
@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants