Repository navigation
Conversation
This was referenced Sep 7, 2026
This was referenced Sep 16, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report backend progress for unknown-size downloads and serialize bounded progress observations.
Why this matters
Unknown-size model transfers currently remain at 0% despite a verified backend percentage, while slow status reads can stack overlapping polls.
Root cause: The hook derives percentage solely from byte totals and starts every scheduled/manual request without admission or a full-body deadline.
Behavioral invariant: Known byte totals take precedence; otherwise finite backend percent is clamped to 0–100. One owned observation runs at a time, and a stalled or disposed body cannot block recovery or overwrite fresh progress.
Implementation and compatibility
Use a per-request controller as the synchronous owner, race headers plus JSON against a 15-second deadline, cancel on cleanup and release only the current owner. Preserve cancellation acknowledgement behavior and terminal transfer receipts.
This updates the original canonical PR onto
public-betaat3c186f3f12ba21dad7b7266ec5449393529abb00; it does not create a competing replacement. The shared browser code applies to Linux, macOS and Windows installations. There is no persisted schema migration. Rollback is a revert/rebuild of the dashboard; server lifecycle and authorization remain backend-owned.Overlap check
Searched open and closed upstream PRs by semantic keywords and inspected the complete 1,010-entry public-beta changed-file index on 2026-09-16. Searched production paths:
ods/extensions/services/dashboard/src/hooks/useDownloadProgress.js.Relevant same-file results: #3803 (open: fix(dashboard): keep dismissed download errors dismissed across polling), #4873 (merged: fix(downloads): bound cancellation acknowledgements), #4267 (merged: fix(dashboard-api): sanitize throughput metric samples in agent monitor), #4266 (merged: fix(dashboard-api): guard null nodes payload in cluster status refresh)
#3316 supplies visible status errors; this PR supplies serialization/progress calculation. #4873 owns cancellation acknowledgement deadlines and #3803 owns dismissed terminal errors. The combined integration preserves each contract with an explicit merge recipe.
Regression and validation
Candidate commit:
13b8144a8bc3dd18dcbb9777c3b5fe49fbe8952f.ods/extensions/services/dashboard:npx vitest run src/hooks/__tests__/useDownloadProgress— 18 passed.git diff --check, and pre-commit secret/private-key/large-file checks pass. Existing lint warnings are not errors.make gateon a Linux-native clean beta checkout stops at the existing no-sudo Docker fallback contract (2 failures under the root test environment). The Windows-mounted copy additionally exposed CRLF-sensitive Hermes fixture assertions. Full-tree pre-commit finds existing dummy private-key test fixtures and Windows lacks awk for the heredoc hook; the candidate's scoped secret/key/size hooks pass. These limitations are not represented as successful runtime validation.Review readiness and batch integration
Implementation and focused checks are complete; this PR is Ready for independent review. CI limits below remain visible and no upstream merge or deployment has been performed.
Exact-head CI at
2026-09-16T13:33:01.8060875Zfor13b8144a8bc3dd18dcbb9777c3b5fe49fbe8952f: 37 successful checks; 0 failed; 0 pending; 4 skipped review/security jobs (not counted as passes).All 37 executed current-head checks completed successfully; four review/security jobs were skipped. This establishes automated review readiness, not live hardware validation, an independent human review, or approval to merge.
All 20 exact candidate commits were merged into synthetic integration
d3c05b74ddfafrom beta3c186f3f12ba21dad7b7266ec5449393529abb00. That exact head passed 1,279 tests across 167 files, full ESLint (0 errors; 618 existing warnings), production build, scoped secret/private-key/large-file hooks andgit diff --checkon Windows Node 24.14.1. These are mocked browser/HTTP checks, not live GPU or deployment evidence.Verified merge order: #3044 → #3046 → #3025 → #3038 → #3043 → #3050 → #3312 → #3313 → #3315 → #3316 → #3376 → #3041 → #3042 → #3051 → #3065 → #3062 → #3039 → #3040 → #3049 → #2780.
Merge guidance for this scope: With #3316, retain the controller-owned deadline/cleanup and percentage calculation, add its decoded status-error receipt inside the same race, and publish only for the current controller. Preserve both test sets and its Models statusError surface. External #3803 conflicts only in the progress test file; preserve dismissal coverage on integration.
The only textual conflicts inside the selected batch were #3316/#3040 (download hook plus tests) and #3046/#2780 (tests only). Use the linked integration commit as the reviewed resolution reference. Each PR remains independently based on beta; if merging them separately or squashing, reapply the relevant resolution and rerun affected suites. Outside-batch checks used
git merge-treeonly: #3846/#3848/#3841/#3843 merged textually, while #3803/#4356/#5276/#5125 conflicted. Textual compatibility alone does not establish runtime compatibility.Additional clean-beta Linux checks:
make lint,make smoke, andmake simulatepass.make batshas five baseline environment failures (WSL classification, root permissions/preflight, and a 15 GB free-space boundary), in addition to the full-gate limitations described above. Installer/backend sources are unchanged by this batch. Rollback remains a revert and dashboard rebuild; no stored schema or backend lifecycle migration was introduced.