[tang-vu]

Why this matters

Sandboxed/private browser contexts can throw when evaluating the localStorage or sessionStorage property itself. Passing that property into a safe helper evaluated it before the helper's error boundary, so mounting the install banner could crash the dashboard.

Root cause and invariant

Resolve the storage property inside the existing I/O helper. Only DOM storage exceptions use the in-memory behavior; unrelated programming errors still propagate. Updated this original PR onto current public-beta and retained fresh-install-offer handling from #4981, including its newly added installed-marker write.

Overlap check

Searched open/closed PWA/storage PRs and usePwaInstallPrompt.js. #3841 is the canonical getter-boundary fix. #4981 handles reinstall offers, #3042 prompt deduplication, #4110 workspace storage and #4354 crash recovery address different callers/contracts. No replacement PR was opened.

Validation

• npm test -- --maxWorkers=2 src/hooks/__tests__/usePwaInstallPrompt.test.js src/components/InstallPromptBanner.reinstall.test.jsx: 18 passed.
• Rendered banner regressions exercise denied session-storage access through accepting an install, and denied local-storage access through install events. Follow-up dddef6815e4a46b7cdc8bcdf4b29dc5a7a9d699a also exercises denied writes while preserving a fresh native install offer. Existing reinstall, dismissal and standalone tests remain green.
• Focused ESLint: zero errors (one existing JSX warning). Focused pre-commit and diff check passed.
• Baseline dashboard tests/build and Linux smoke/simulation passed; full-gate/BATS environment/fixture failures are pre-existing. Browser denial is simulated; real OS installation was not performed.

Tradeoffs and rollback

When storage is denied, preferences cannot persist beyond in-memory state. No key/schema change or forced prompt is introduced. Reverting restores the old getter crash risk without migration. Ready for independent review; not approval to merge.

Final beta-batch receipt — 2026-09-16

Candidate: dddef6815e4a46b7cdc8bcdf4b29dc5a7a9d699a. GitHub check audit at 11:07:47 UTC: 37 successful, 4 skipped, 0 failed, 0 pending, matching this exact head; OPEN, public-beta base, Ready (not Draft). Skipped checks are not counted as passed tests.

The combined integration head, 5b9877184ceab0751c6c9fe3564c73303e78f0a3, contains all 30 exact candidate heads on public-beta 3c186f3f12ba21dad7b7266ec5449393529abb00. At this exact final SHA: full dashboard 171 files / 1,274 tests passed; full dashboard API 3,124 passed, 2 skipped; advice boundary suite 23 passed; Bark request/legacy-empty cases 9 passed; changed-file secret/key/size hooks and diff check passed. Shell-only hooks had no matching changed files.

Additional combined checks ran at predecessor 28adf1aa5c0710d3c0de13df7870629e24977fec: Token Spy 130 passed, 1 skipped; CLI contracts 16 passed; real backup/restore round trip passed; Open Interpreter HTTP/runner cases 4 passed; make lint smoke simulate, frontend lint (zero errors, 624 warnings) and production build passed. The only final-head differences are two test files (advice dialog fixtures and Bark's empty-text expectation); production files are identical. These results are not live GPU/model or service rollout qualification.

Qualified merge order: #5490 → #5494 → #5495 → #3848 → #3846 → #3845 → #3844 → #3843 → #3841 → #3838 → #3837 → #3836 → #3835 → #3834 → #3809 → #3808 → #3807 → #3806 → #3804 → #3803 → #3802 → #3801 → #3800 → #3712 → #3711 → #3710 → #3709 → #3708 → #3852 → #3849. Branches are independently useful. Shared-file merging required only preserving the union of four adjacent Makefile registrations: provider-probe redirects, healthcheck error-body, Milvus persistence and healthcheck latency. Production code in these 30 merged without manual conflict resolution. External advice/Bark overlaps have separate pairwise receipts in #5494/#3808. Recheck the combined tree if other shared-file PRs land first; do not drop test registrations.

Full release qualification remains not green: baseline make gate fails a no-sudo Docker fallback fixture; 5 of 428 BATS cases fail in this environment; all-files private-key scanning flags two pre-existing dummy-key fixtures. No checks were disabled. CI success and Ready status do not replace independent human review, especially for auth backups and Milvus data migration. No upstream merge or deployment was performed.

[Lightheartdevs]

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.