Skip to content

fix(dashboard): complete initial GPU status load - #3313

Closed
tang-vu wants to merge 2 commits into
Osmantic:public-betafrom
tang-vu:fix/gpu-detail-initial-fetch
Closed

tang-vu wants to merge 2 commits into
Osmantic:public-betafrom
tang-vu:fix/gpu-detail-initial-fetch

Conversation

@tang-vu

@tang-vu tang-vu commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Allow the GPU Monitor's initial snapshot to load when its tab starts hidden, then pause background polling after data arrives.

Why this matters

A restored dashboard tab or background window currently stays on its initial loading skeleton until a visibility event occurs.

Root cause: The hidden-tab guard suppresses the first fetch as well as subsequent polls.

Behavioral invariant: Initial data may load in a hidden tab; later hidden polls pause, and visibility restoration triggers an immediate refresh.

Implementation and compatibility

Track the first completed snapshot inside each effect lifetime. Retain beta's 15-second body deadline and effect-local cancellation. Use a separate initial-load test file so the HTTP failure PR composes cleanly.

This updates the original canonical PR onto public-beta at 3c186f3f12ba21dad7b7266ec5449393529abb00; it does not create a competing replacement. The shared browser code applies to Linux, macOS and Windows installations. There is no persisted schema migration. Rollback is a revert/rebuild of the dashboard; server lifecycle and authorization remain backend-owned.

Overlap check

Searched open and closed upstream PRs by semantic keywords and inspected the complete 1,010-entry public-beta changed-file index on 2026-09-16. Searched production paths: ods/extensions/services/dashboard/src/hooks/useGPUDetailed.js.

Relevant same-file results: #4444 (merged: fix(gpu): recover monitoring after stalled response bodies)

Compared earlier #3025 with this PR: keep detail HTTP validation and its outage/recovery tests in the earlier canonical PR, and narrow #3313 to its independent hidden-initial-load advantage. #4444's timeout work is retained, not replaced.

Regression and validation

Candidate commit: 5dafa7e7d7e1fb5be134c10fdda8d8fd6c20accf.

  • From ods/extensions/services/dashboard: npx vitest run src/hooks/__tests__/useGPUDetailed — 6 passed.
  • Both hidden-load and pause/resume tests fail on unchanged beta; all 6 candidate initial-load and bounded-poll tests pass.
  • Changed-file ESLint, git diff --check, and pre-commit secret/private-key/large-file checks pass. Existing lint warnings are not errors.
  • Clean beta baseline: full dashboard 1,232 tests passed, lint and production build passed on Windows Node 24.14.1. CI uses Node 20 and validates Linux/macOS/Windows. No browser-on-hardware or live GPU/model-service claim is made by these mocked HTTP/UI tests.
  • Broad make gate on a Linux-native clean beta checkout stops at the existing no-sudo Docker fallback contract (2 failures under the root test environment). The Windows-mounted copy additionally exposed CRLF-sensitive Hermes fixture assertions. Full-tree pre-commit finds existing dummy private-key test fixtures and Windows lacks awk for the heredoc hook; the candidate's scoped secret/key/size hooks pass. These limitations are not represented as successful runtime validation.

Review readiness and batch integration

Implementation and focused checks are complete; this PR is Ready for independent review. CI limits below remain visible and no upstream merge or deployment has been performed.

Exact-head CI at 2026-09-16T13:33:01.8060875Z for 5dafa7e7d7e1fb5be134c10fdda8d8fd6c20accf: 36 successful checks; 1 failed; 0 pending; 4 skipped review/security jobs (not counted as passes). frontend (ubuntu-latest).

The Linux frontend job failed the unchanged PortalIdentityContext unsaved-name/refresh test (expected “My draft”, received “Other”); the new GPU tests passed. The identity component, test, package lock and Vite configuration are identical to beta. The identity suite passed locally on Node 24 and Node 20 (11 tests each), and the full combined dashboard suite passed. This is a suspected baseline timing failure, not a proven fix or a green CI result. GitHub refused the failed-run rerun with “Must have admin rights to Repository.” Maintainer rerun/investigation remains required.

All 20 exact candidate commits were merged into synthetic integration d3c05b74ddfa from beta 3c186f3f12ba21dad7b7266ec5449393529abb00. That exact head passed 1,279 tests across 167 files, full ESLint (0 errors; 618 existing warnings), production build, scoped secret/private-key/large-file hooks and git diff --check on Windows Node 24.14.1. These are mocked browser/HTTP checks, not live GPU or deployment evidence.

Verified merge order: #3044 → #3046 → #3025 → #3038 → #3043 → #3050 → #3312 → #3313 → #3315 → #3316 → #3376 → #3041 → #3042 → #3051 → #3065 → #3062 → #3039 → #3040 → #3049 → #2780.

Merge guidance for this scope: The separate initial-load tests and effect-local initial snapshot flag merge cleanly with #3025 HTTP validation; combined tests preserve both.

The only textual conflicts inside the selected batch were #3316/#3040 (download hook plus tests) and #3046/#2780 (tests only). Use the linked integration commit as the reviewed resolution reference. Each PR remains independently based on beta; if merging them separately or squashing, reapply the relevant resolution and rerun affected suites. Outside-batch checks used git merge-tree only: #3846/#3848/#3841/#3843 merged textually, while #3803/#4356/#5276/#5125 conflicted. Textual compatibility alone does not establish runtime compatibility.

Additional clean-beta Linux checks: make lint, make smoke, and make simulate pass. make bats has five baseline environment failures (WSL classification, root permissions/preflight, and a 15 GB free-space boundary), in addition to the full-gate limitations described above. Installer/backend sources are unchanged by this batch. Rollback remains a revert and dashboard rebuild; no stored schema or backend lifecycle migration was introduced.

@tang-vu
tang-vu force-pushed the fix/gpu-detail-initial-fetch branch from 5dafa7e to 3adfa2a Compare September 17, 2026 14:02
@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard: useGPUDetailed never loads when tab backgrounded and silently ignores HTTP errors

2 participants