Repository navigation
Conversation
This was referenced Sep 8, 2026
This was referenced Sep 16, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use dedicated recovery actions for stopped, unhealthy and failed extensions instead of also offering a misleading enable/disable toggle.
Why this matters
Operators currently see a switch implying enablement state for runtime failures, alongside Start, Retry or Check Logs. Those controls represent different operations and can conflict.
Root cause: isToggleable includes runtime-health statuses, although toggle direction is based on enabled/disabled state.
Behavioral invariant: The state toggle represents enabled, CLI-installed or disabled state; runtime failures expose their existing specific recovery action.
Implementation and compatibility
Restrict toggle eligibility while retaining recovery buttons and existing enabled/disabled behavior. No backend action or auth boundary changes.
This updates the original canonical PR onto
public-betaat3c186f3f12ba21dad7b7266ec5449393529abb00; it does not create a competing replacement. The shared browser code applies to Linux, macOS and Windows installations. There is no persisted schema migration. Rollback is a revert/rebuild of the dashboard; server lifecycle and authorization remain backend-owned.Overlap check
Searched open and closed upstream PRs by semantic keywords and inspected the complete 1,010-entry public-beta changed-file index on 2026-09-16. Searched production paths:
ods/extensions/services/dashboard/src/pages/Extensions.jsx.Relevant same-file results: #5009 (open: feat(extensions): add local text-to-diagram rendering API), #5003 (open: feat(extensions): add offline spelling and grammar API), #4961 (open: fix(aider): make the advertised CLI launch reach Aider), #3848 (open: feat(extensions): save browser-local extension favorites), #5238 (merged: fix(dashboard): preserve internal-only service port declarations), #5067 (merged: fix(dashboard): serialize manual and automatic console log reads), #5065 (merged: fix(dashboard): honor extension update confirmation states), #4982 (merged: fix(extensions): show credentials from the installation config), #4207 (merged: feat(beta): workspace UX, Portal mascot and Settings refinement)
#5065 governs update confirmation, #5067 governs console requests, #3848 adds favorites, and #4961 fixes CLI launch routing. This canonical toggle-contract change is independent of those workflows.
Regression and validation
Candidate commit:
47aae9b57898b501bf22b280ff244dfd6824006f.ods/extensions/services/dashboard:npx vitest run src/pages/Extensions— 29 passed.git diff --check, and pre-commit secret/private-key/large-file checks pass. Existing lint warnings are not errors.make gateon a Linux-native clean beta checkout stops at the existing no-sudo Docker fallback contract (2 failures under the root test environment). The Windows-mounted copy additionally exposed CRLF-sensitive Hermes fixture assertions. Full-tree pre-commit finds existing dummy private-key test fixtures and Windows lacks awk for the heredoc hook; the candidate's scoped secret/key/size hooks pass. These limitations are not represented as successful runtime validation.Review readiness and batch integration
Implementation and focused checks are complete; this PR is Ready for independent review. CI limits below remain visible and no upstream merge or deployment has been performed.
Exact-head CI at
2026-09-16T13:33:01.8060875Zfor47aae9b57898b501bf22b280ff244dfd6824006f: 37 successful checks; 0 failed; 0 pending; 4 skipped review/security jobs (not counted as passes).All 37 executed current-head checks completed successfully; four review/security jobs were skipped. This establishes automated review readiness, not live hardware validation, an independent human review, or approval to merge.
All 20 exact candidate commits were merged into synthetic integration
d3c05b74ddfafrom beta3c186f3f12ba21dad7b7266ec5449393529abb00. That exact head passed 1,279 tests across 167 files, full ESLint (0 errors; 618 existing warnings), production build, scoped secret/private-key/large-file hooks andgit diff --checkon Windows Node 24.14.1. These are mocked browser/HTTP checks, not live GPU or deployment evidence.Verified merge order: #3044 → #3046 → #3025 → #3038 → #3043 → #3050 → #3312 → #3313 → #3315 → #3316 → #3376 → #3041 → #3042 → #3051 → #3065 → #3062 → #3039 → #3040 → #3049 → #2780.
Merge guidance for this scope: With #3065, production and test changes merge cleanly. External #3848 favorites has a clean textual merge only; its runtime behavior was not included in the combined test run.
The only textual conflicts inside the selected batch were #3316/#3040 (download hook plus tests) and #3046/#2780 (tests only). Use the linked integration commit as the reviewed resolution reference. Each PR remains independently based on beta; if merging them separately or squashing, reapply the relevant resolution and rerun affected suites. Outside-batch checks used
git merge-treeonly: #3846/#3848/#3841/#3843 merged textually, while #3803/#4356/#5276/#5125 conflicted. Textual compatibility alone does not establish runtime compatibility.Additional clean-beta Linux checks:
make lint,make smoke, andmake simulatepass.make batshas five baseline environment failures (WSL classification, root permissions/preflight, and a 15 GB free-space boundary), in addition to the full-gate limitations described above. Installer/backend sources are unchanged by this batch. Rollback remains a revert and dashboard rebuild; no stored schema or backend lifecycle migration was introduced.