Repository navigation
Conversation
…uest-validation-20260907
This was referenced Sep 16, 2026
This was referenced Sep 16, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
Bark accepted empty/whitespace text and explicit null output_format, then failed or scheduled needless synthesis instead of rejecting the unusable HTTP request.
Fix and overlap check
Require nonblank text and a nonnullable output format while preserving the default WAV format, meaningful text whitespace and optional voice. Updated the original canonical request-validation PR onto public-beta. Searched all-state Bark validation and bark/server.py PRs. #5204 bounds generation admission, a different lifecycle contract; this patch rejects invalid requests before synthesis. No duplicate was created.
Validation
pytest -q test_request_validation.py test_server.py::test_tts_text_empty: 9 passed on Linux Python3.10.21/FastAPI0.111.0/soundfile0.12.1/numpy1.26.4, matching the declared version families. Both /tts and /tts/stream reject three invalid payloads with 422 and zero synthesis calls; defaults/null voice remain valid. The synthesis backend is replaced with a fixture: no Torch model, GPU or audio-quality validation is claimed. Focused pre-commit/diff check passed.Baseline smoke/simulation passed; full make gate/BATS retain known environment/fixture failures.
Compatibility and rollback
Clients sending null output_format must omit it for WAV or supply a supported string. No model format or persisted state changes. Revert restores invalid-input acceptance. Ready for independent review.
Follow-up and shared-file compatibility
Follow-up
797cc0b5799ee61b19f5451b107589bd13e1661dupdates the legacy empty-text expectation from 200 to the intended 422 response and validates the error location. Production code merges cleanly with #5204 at02d0dd5809819fbc2ed2fe0a463308e50b749cc2. Pair branch integration/beta-bark-pair-20260916 passed 20 tests at that exact SHA: request validation, the legacy empty case and generation-admission regressions.The broader legacy
test_server.pysuite was also attempted, but is not green in the fixture-only environment: 11 setup errors require the unavailable Bark package; old validation assertions assume string-shaped Pydantic errors, and a model-boundary case also requires that package. The empty-text mismatch is fixed here; #3974's separate legacy assertion/timeout scope is not duplicated. No Bark weights, live synthesis or GPU qualification is claimed. Independent human review remains required.Final beta-batch receipt — 2026-09-16
Candidate:
797cc0b5799ee61b19f5451b107589bd13e1661d. GitHub check audit at 11:07:47 UTC: 37 successful, 4 skipped, 0 failed, 0 pending, matching this exact head; OPEN, public-beta base, Ready (not Draft). Skipped checks are not counted as passed tests.The combined integration head,
5b9877184ceab0751c6c9fe3564c73303e78f0a3, contains all 30 exact candidate heads on public-beta3c186f3f12ba21dad7b7266ec5449393529abb00. At this exact final SHA: full dashboard 171 files / 1,274 tests passed; full dashboard API 3,124 passed, 2 skipped; advice boundary suite 23 passed; Bark request/legacy-empty cases 9 passed; changed-file secret/key/size hooks and diff check passed. Shell-only hooks had no matching changed files.Additional combined checks ran at predecessor
28adf1aa5c0710d3c0de13df7870629e24977fec: Token Spy 130 passed, 1 skipped; CLI contracts 16 passed; real backup/restore round trip passed; Open Interpreter HTTP/runner cases 4 passed;make lint smoke simulate, frontend lint (zero errors, 624 warnings) and production build passed. The only final-head differences are two test files (advice dialog fixtures and Bark's empty-text expectation); production files are identical. These results are not live GPU/model or service rollout qualification.Qualified merge order: #5490 → #5494 → #5495 → #3848 → #3846 → #3845 → #3844 → #3843 → #3841 → #3838 → #3837 → #3836 → #3835 → #3834 → #3809 → #3808 → #3807 → #3806 → #3804 → #3803 → #3802 → #3801 → #3800 → #3712 → #3711 → #3710 → #3709 → #3708 → #3852 → #3849. Branches are independently useful. Shared-file merging required only preserving the union of four adjacent Makefile registrations: provider-probe redirects, healthcheck error-body, Milvus persistence and healthcheck latency. Production code in these 30 merged without manual conflict resolution. External advice/Bark overlaps have separate pairwise receipts in #5494/#3808. Recheck the combined tree if other shared-file PRs land first; do not drop test registrations.
Full release qualification remains not green: baseline
make gatefails a no-sudo Docker fallback fixture; 5 of 428 BATS cases fail in this environment; all-files private-key scanning flags two pre-existing dummy-key fixtures. No checks were disabled. CI success and Ready status do not replace independent human review, especially for auth backups and Milvus data migration. No upstream merge or deployment was performed.