Skip to content

feat(api): batch model route evidence queries - #3709

Closed
tang-vu wants to merge 2 commits into
Osmantic:public-betafrom
tang-vu:feat/model-route-evidence-batch
Closed

tang-vu wants to merge 2 commits into
Osmantic:public-betafrom
tang-vu:feat/model-route-evidence-batch

Conversation

@tang-vu

@tang-vu tang-vu commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Why this matters

Clients collecting several model-route receipts currently need separate authenticated HTTP requests. A bounded batch supports one read operation with explicit per-receipt outcomes.

Feature and overlap check

Add POST /api/models/routes/query with 1–50 unique canonical UUIDs, up to eight concurrent internal reads, preserved input order, per-item found/not_found/error and summary counts. Reuse existing internal-key lookup, evidence sanitization and transport behavior; the POST is read-only and authenticated. Updated the original PR onto beta. Searched all-state model evidence/batch and model_routes.py; #5369 isolates internal credentials, not batch reads. No duplicate was opened.

Validation

Linux Python3.11: pytest -q tests/test_model_routes.py: 13 passed, covering authentication, request bounds/UUIDs, existing GET behavior, sanitized mixed outcomes and batch concurrency. Focused pre-commit/diff check passed. Internal transport is mocked, not a live router qualification. Baseline smoke/simulation passed; known full-gate/BATS failures remain.

Tradeoffs and rollback

Retains existing per-receipt retries/timeouts; no new global batch deadline is claimed. Failed receipts do not discard successful ones. No persisted state. Revert removes the new endpoint and restores the original GET implementation. Ready for independent review.

Final beta-batch receipt — 2026-09-16

Candidate: a8b05c7e9bb0054ce17cfab46e08cfc7170e277d. GitHub check audit at 11:07:47 UTC: 37 successful, 4 skipped, 0 failed, 0 pending, matching this exact head; OPEN, public-beta base, Ready (not Draft). Skipped checks are not counted as passed tests.

The combined integration head, 5b9877184ceab0751c6c9fe3564c73303e78f0a3, contains all 30 exact candidate heads on public-beta 3c186f3f12ba21dad7b7266ec5449393529abb00. At this exact final SHA: full dashboard 171 files / 1,274 tests passed; full dashboard API 3,124 passed, 2 skipped; advice boundary suite 23 passed; Bark request/legacy-empty cases 9 passed; changed-file secret/key/size hooks and diff check passed. Shell-only hooks had no matching changed files.

Additional combined checks ran at predecessor 28adf1aa5c0710d3c0de13df7870629e24977fec: Token Spy 130 passed, 1 skipped; CLI contracts 16 passed; real backup/restore round trip passed; Open Interpreter HTTP/runner cases 4 passed; make lint smoke simulate, frontend lint (zero errors, 624 warnings) and production build passed. The only final-head differences are two test files (advice dialog fixtures and Bark's empty-text expectation); production files are identical. These results are not live GPU/model or service rollout qualification.

Qualified merge order: #5490 → #5494 → #5495 → #3848 → #3846 → #3845 → #3844 → #3843 → #3841 → #3838 → #3837 → #3836 → #3835 → #3834 → #3809 → #3808 → #3807 → #3806 → #3804 → #3803 → #3802 → #3801 → #3800 → #3712 → #3711 → #3710 → #3709 → #3708 → #3852 → #3849. Branches are independently useful. Shared-file merging required only preserving the union of four adjacent Makefile registrations: provider-probe redirects, healthcheck error-body, Milvus persistence and healthcheck latency. Production code in these 30 merged without manual conflict resolution. External advice/Bark overlaps have separate pairwise receipts in #5494/#3808. Recheck the combined tree if other shared-file PRs land first; do not drop test registrations.

Full release qualification remains not green: baseline make gate fails a no-sudo Docker fallback fixture; 5 of 428 BATS cases fail in this environment; all-files private-key scanning flags two pre-existing dummy-key fixtures. No checks were disabled. CI success and Ready status do not replace independent human review, especially for auth backups and Milvus data migration. No upstream merge or deployment was performed.

@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants