Skip to content

fix(dashboard): preserve OpenClaw link queries - #3049

Merged
gabsprogrammer merged 2 commits into
Osmantic:public-betafrom
tang-vu:fix/sidebar-openclaw-token-url
Sep 19, 2026
Merged

gabsprogrammer merged 2 commits into
Osmantic:public-betafrom
tang-vu:fix/sidebar-openclaw-token-url

Conversation

@tang-vu

@tang-vu tang-vu commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Set the OpenClaw authentication token as a URL parameter while preserving the advertised route, query and fragment.

Why this matters

Concatenating /?token= onto an advertised launch URL breaks links that already include routing parameters or fragments, and can leave an obsolete token parameter in place.

Root cause: The sidebar edits URLs with string concatenation instead of preserving their URL components.

Behavioral invariant: Exactly one current token parameter reaches the same advertised route; unrelated parameters and fragments survive and reserved token characters are encoded.

Implementation and compatibility

Use URL/searchParams.set at the actual sidebar anchor boundary, resolving relative advertised routes against the dashboard origin. Preserve beta's navigation, offline links and filtered application list.

This updates the original canonical PR onto public-beta at 3c186f3f12ba21dad7b7266ec5449393529abb00; it does not create a competing replacement. The shared browser code applies to Linux, macOS and Windows installations. There is no persisted schema migration. Rollback is a revert/rebuild of the dashboard; server lifecycle and authorization remain backend-owned.

Overlap check

Searched open and closed upstream PRs by semantic keywords and inspected the complete 1,010-entry public-beta changed-file index on 2026-09-16. Searched production paths: ods/extensions/services/dashboard/src/components/Sidebar.jsx.

Relevant same-file results: #4207 (merged: feat(beta): workspace UX, Portal mascot and Settings refinement), #4115 (merged: fix(beta): clear hidden navigation filters on sidebar collapse)

#4207 rebuilt the sidebar layout and #4115 fixed collapsed filters. This adaptation keeps both and changes only the tokenized launch href. The unrelated raw-IPv6 hostname candidate #3029 was rejected because a reachable browser-host defect was not established.

Regression and validation

Candidate commit: 0eac3a44a647eb914d6325ab6b84cefa82c44351.

  • From ods/extensions/services/dashboard: npx vitest run src/components/__tests__/Sidebar — 10 passed.
  • Three public-anchor tests fail on beta: existing query/fragment, replacement of an old token, and relative routes. All 10 candidate sidebar tests pass.
  • Changed-file ESLint, git diff --check, and pre-commit secret/private-key/large-file checks pass. Existing lint warnings are not errors.
  • Clean beta baseline: full dashboard 1,232 tests passed, lint and production build passed on Windows Node 24.14.1. CI uses Node 20 and validates Linux/macOS/Windows. No browser-on-hardware or live GPU/model-service claim is made by these mocked HTTP/UI tests.
  • Broad make gate on a Linux-native clean beta checkout stops at the existing no-sudo Docker fallback contract (2 failures under the root test environment). The Windows-mounted copy additionally exposed CRLF-sensitive Hermes fixture assertions. Full-tree pre-commit finds existing dummy private-key test fixtures and Windows lacks awk for the heredoc hook; the candidate's scoped secret/key/size hooks pass. These limitations are not represented as successful runtime validation.

Review readiness and batch integration

Implementation and focused checks are complete; this PR is Ready for independent review. CI limits below remain visible and no upstream merge or deployment has been performed.

Exact-head CI at 2026-09-16T13:33:01.8060875Z for 0eac3a44a647eb914d6325ab6b84cefa82c44351: 37 successful checks; 0 failed; 0 pending; 4 skipped review/security jobs (not counted as passes).

All 37 executed current-head checks completed successfully; four review/security jobs were skipped. This establishes automated review readiness, not live hardware validation, an independent human review, or approval to merge.

All 20 exact candidate commits were merged into synthetic integration d3c05b74ddfa from beta 3c186f3f12ba21dad7b7266ec5449393529abb00. That exact head passed 1,279 tests across 167 files, full ESLint (0 errors; 618 existing warnings), production build, scoped secret/private-key/large-file hooks and git diff --check on Windows Node 24.14.1. These are mocked browser/HTTP checks, not live GPU or deployment evidence.

Verified merge order: #3044 → #3046 → #3025 → #3038 → #3043 → #3050 → #3312 → #3313 → #3315 → #3316 → #3376 → #3041 → #3042 → #3051 → #3065 → #3062 → #3039 → #3040 → #3049 → #2780.

Merge guidance for this scope: No other selected PR changes the Sidebar tokenized href.

The only textual conflicts inside the selected batch were #3316/#3040 (download hook plus tests) and #3046/#2780 (tests only). Use the linked integration commit as the reviewed resolution reference. Each PR remains independently based on beta; if merging them separately or squashing, reapply the relevant resolution and rerun affected suites. Outside-batch checks used git merge-tree only: #3846/#3848/#3841/#3843 merged textually, while #3803/#4356/#5276/#5125 conflicted. Textual compatibility alone does not establish runtime compatibility.

Additional clean-beta Linux checks: make lint, make smoke, and make simulate pass. make bats has five baseline environment failures (WSL classification, root permissions/preflight, and a 15 GB free-space boundary), in addition to the full-gate limitations described above. Installer/backend sources are unchanged by this batch. Rollback remains a revert and dashboard rebuild; no stored schema or backend lifecycle migration was introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants