Repository navigation
Conversation
This was referenced Sep 11, 2026
…ace-details-request-cancellation
This was referenced Sep 16, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancel repository-detail requests when their inspection dialog closes or the Hub browser unmounts.
Why this matters
Closing a slow Hugging Face repository inspection currently leaves its network request and body read active; rapid inspection changes can accumulate abandoned work.
Root cause: Request sequence IDs reject stale state but do not release the underlying request.
Behavioral invariant: Only the active repository inspection owns a live request; closing, replacing or unmounting cancels the former owner without showing an abort error.
Implementation and compatibility
Use one AbortController per inspection alongside the existing receipt sequence. Preserve beta's validated artifact shapes, retry UI and search deadlines.
This updates the original canonical PR onto
public-betaat3c186f3f12ba21dad7b7266ec5449393529abb00; it does not create a competing replacement. The shared browser code applies to Linux, macOS and Windows installations. There is no persisted schema migration. Rollback is a revert/rebuild of the dashboard; server lifecycle and authorization remain backend-owned.Overlap check
Searched open and closed upstream PRs by semantic keywords and inspected the complete 1,010-entry public-beta changed-file index on 2026-09-16. Searched production paths:
ods/extensions/services/dashboard/src/components/model-library/HuggingFaceModelBrowser.jsx.Relevant same-file results: #4356 (open: fix(models): use a native modal for artifact inspection), #5247 (merged: fix(models): release stalled Hugging Face searches), #4884 (merged: feat(models): filter Hugging Face artifacts by filename or quantization), #4622 (merged: fix(models): recover from invalid Hub detail responses), #4339 (merged: fix(models): reject obsolete Hub search response bodies), #4267 (merged: fix(dashboard-api): sanitize throughput metric samples in agent monitor), #4266 (merged: fix(dashboard-api): guard null nodes payload in cluster status refresh)
#5247 and #4339 govern search, #4622 governs invalid detail receipts, #4884 adds artifact filtering, and #4356 changes dialog focus. Cancellation releases resources in the original #3050 scope; those behaviors remain intact.
Regression and validation
Candidate commit:
59aef4dd4f240802f672a1806a400358f5249e75.ods/extensions/services/dashboard:npx vitest run src/components/model-library/HuggingFace— 15 passed.git diff --check, and pre-commit secret/private-key/large-file checks pass. Existing lint warnings are not errors.make gateon a Linux-native clean beta checkout stops at the existing no-sudo Docker fallback contract (2 failures under the root test environment). The Windows-mounted copy additionally exposed CRLF-sensitive Hermes fixture assertions. Full-tree pre-commit finds existing dummy private-key test fixtures and Windows lacks awk for the heredoc hook; the candidate's scoped secret/key/size hooks pass. These limitations are not represented as successful runtime validation.Review readiness and batch integration
Implementation and focused checks are complete; this PR is Ready for independent review. CI limits below remain visible and no upstream merge or deployment has been performed.
Exact-head CI at
2026-09-16T13:33:01.8060875Zfor59aef4dd4f240802f672a1806a400358f5249e75: 37 successful checks; 0 failed; 0 pending; 4 skipped review/security jobs (not counted as passes).All 37 executed current-head checks completed successfully; four review/security jobs were skipped. This establishes automated review readiness, not live hardware validation, an independent human review, or approval to merge.
All 20 exact candidate commits were merged into synthetic integration
d3c05b74ddfafrom beta3c186f3f12ba21dad7b7266ec5449393529abb00. That exact head passed 1,279 tests across 167 files, full ESLint (0 errors; 618 existing warnings), production build, scoped secret/private-key/large-file hooks andgit diff --checkon Windows Node 24.14.1. These are mocked browser/HTTP checks, not live GPU or deployment evidence.Verified merge order: #3044 → #3046 → #3025 → #3038 → #3043 → #3050 → #3312 → #3313 → #3315 → #3316 → #3376 → #3041 → #3042 → #3051 → #3065 → #3062 → #3039 → #3040 → #3049 → #2780.
Merge guidance for this scope: External #4356 conflicts in HuggingFaceModelBrowser.jsx. Integrate native-dialog focus with request-controller cleanup explicitly before merging both; that external combination was not runtime-tested.
The only textual conflicts inside the selected batch were #3316/#3040 (download hook plus tests) and #3046/#2780 (tests only). Use the linked integration commit as the reviewed resolution reference. Each PR remains independently based on beta; if merging them separately or squashing, reapply the relevant resolution and rerun affected suites. Outside-batch checks used
git merge-treeonly: #3846/#3848/#3841/#3843 merged textually, while #3803/#4356/#5276/#5125 conflicted. Textual compatibility alone does not establish runtime compatibility.Additional clean-beta Linux checks:
make lint,make smoke, andmake simulatepass.make batshas five baseline environment failures (WSL classification, root permissions/preflight, and a 15 GB free-space boundary), in addition to the full-gate limitations described above. Installer/backend sources are unchanged by this batch. Rollback remains a revert and dashboard rebuild; no stored schema or backend lifecycle migration was introduced.