Skip to content

feat(reports): leftover-map item complete-case coverage on graphic display (v2.39.0) - #813

Draft
seonghobae wants to merge 8 commits into
feat/leftover-map-plot-coverage-v2380from
feat/leftover-map-plot-item-coverage-v2390
Draft

feat(reports): leftover-map item complete-case coverage on graphic display (v2.39.0)#813
seonghobae wants to merge 8 commits into
feat/leftover-map-plot-coverage-v2380from
feat/leftover-map-plot-item-coverage-v2390

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Caption the leftover-map graphic display with persisted item complete-case coverage (ADR 0282 / v2.39.0), distinct from post complete-case coverage (ADR 0281).
  • Preserve persisted-only semantics; do not infer item coverage from criterion markers, post coverage, rank, or unused axes. UI/read-model scope only; no new SQL or measurement authority.

Current parent and product ancestry

Current parent is exact #812 df419c5a2f75782fa883915806d8cada7a78ff78. Current #813 product is 44ace39111664a9b39a81e575a8dbdf06506050f, promoted non-force from workflow-free tree 7e0b86ba2078e542e239458ccffbb70335c181fb after run 34040514634, job 101506289812, completed GREEN. The only inherited moved-parent delta was frontend/src/leftoverMapPlotLayout.test.ts; ADR0282/v2.39 semantics are unchanged. Isolated convergence GREEN does not transfer hosted exact-head GREEN or independent approval.

Descendant authority

#814 is current at bd90a974b72c649c423a7b99ee47dae1d8236b0e, #815 at c02dffc264f70283ff7ff2d07bfe83a47bd13e10, #816 at 4d81c881469496fedeb8d9bb98cd485209df2089, #817 at aa47c96e15084d0b944558b980edef34133f8040, #818 at de3a61988768bcfddcab1dec3dfe3c60f9a89743, and #819 at f37ca315e3c48fa37bbcafe96e46c5d7dab991b7, all through verified non-force current-parent convergence. #820 is the earliest stale descendant; run 34054337875 reconstructs its valid singular-value v2.46 delta from exact #819 while repairing current-parent conflicts and ADR/release state. #821 remains dependent under a distinct future ADR/release identity.

Verification boundary

  • PR: open / Draft / mechanically mergeable
  • exact product head: 44ace39111664a9b39a81e575a8dbdf06506050f
  • exact current parent: df419c5a2f75782fa883915806d8cada7a78ff78
  • current-parent run 34040514634: GREEN
  • exact-product hosted required GREEN, authenticated PostgreSQL/k6, current-head Storybook/browser/a11y, qualifying independent APPROVE, and release evidence: not claimed

Keep Draft. No force-push, self-approval, gate weakening, stale evidence transfer, or invented measurement values.

Caption the leftover-map graphic display with persisted leftover-map
item complete-case coverage (ADR 0282). After make seed, closest and
farthest leftover pairs sit above the member list with a plot caption
that matches leftover-map item complete-case coverage; click a post
marker or a pair button opens that post.

A missing, non-integer, negative-used, non-positive-scored, or
used-greater-than-scored item coverage omits that leftover-map item
coverage caption. Coverage 0 of M is shown when that persisted used
count is a non-negative integer. Do not invent item coverage from
plotted criterion marker count, leftover-map distance, leftover-map
rank, leftover-map post coverage, or the count of unused axes. Never
invent a leftover score or a theta. UI-only; no new columns.

Copy link
Copy Markdown
Contributor Author

Stacked onto leftover-map complete-case coverage on the graphic (#812 @ 64964cb). Independent APPROVE required. Do not self-approve. Do not squash-merge onto the leftover base. After independent review, retarget onto leftover-coordinates (#782) rather than squash-merging here.

Copilot/Devin review is not independent APPROVE. Only collaborator is seonghobae; no independent reviewer can be requested from this token.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Write retry this cycle (2026-08-30 20:12 KST): GitHub comment/close/create-PR/push succeed from this token. Exact head de2a8a8b still has no independent APPROVE (Devin COMMENT is not independent APPROVE). Do not self-approve. Do not squash-merge onto the leftover base. Next buyer increment is leftover-map incomplete post coverage on the graphic (ADR 0283 / v2.40.0), stacked onto this head.

Copy link
Copy Markdown
Contributor Author

Cycle write retry 2026-08-30T20:12+09:00. Head de2a8a8 remains stacked on #812 (feat/leftover-map-plot-coverage-v2380@64964cb6). Do not squash-merge onto an unprotected leftover base. Independent collaborator APPROVE required; Copilot/Devin COMMENT is not independent APPROVE. Next buyer gap ADR 0283 (leftover-map incomplete post coverage on the graphic, v2.40.0) is being stacked locally on this head — not mixed into this PR.

Copy link
Copy Markdown
Contributor Author

Write retry this cycle (2026-08-30 20:26 KST). Exact head de2a8a8b still has no independent APPROVE (Devin COMMENT is not independent APPROVE). Do not self-approve. Do not squash-merge onto the leftover base. Next buyer increment is leftover-map incomplete post coverage on the graphic (ADR 0283 / v2.40.0), stacked onto this head — not mixed into this PR.

Copy link
Copy Markdown
Contributor Author

Stacked #814 (feat/leftover-map-plot-incomplete-v2400 @ 7729287, ADR 0283 / v2.40.0 leftover-map incomplete post coverage on the graphic) onto this head. Leave #813 and #814 open. Do not squash-merge onto this leftover base.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-30T11:26Z write retry: leftover-map item coverage (#813 @ de2a8a8) stays stacked and unmerged. No independent APPROVE exists on this org (only collaborator is seonghobae). Copilot/Devin COMMENT is not independent APPROVE. Do not squash-merge this layer onto leftover-coordinates (#782). Next buyer increment this cycle is leftover-map incomplete post coverage on the graphic (ADR 0283 / v2.40.0) stacked onto this head — UI-only caption from persisted incomplete_post_count / scored_post_count; never invent incomplete as scored−used or from marker count; omit when missing/non-integer/negative/incomplete>scored/scored≤0; show 0 of M. Pair-list note stays post complete-case (ADR 0168). Grouping comparison strip (ADR 0149) does not gain this caption. No new columns. Synthetic fixtures only. NVIDIA_NIM_API_KEY only.

@seonghobae
seonghobae marked this pull request as draft September 5, 2026 09:06

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parent #812 has moved non-force from 64964cb6… to a Draft repair line carrying release-identity, Pages, short-canvas, and Vietnamese-share regression contracts. This v2.39 successor was still Ready on the old parent snapshot and independently repeats the same runtime provenance defect: package/frontend metadata are v2.39.0 while lineageweave.__version__ remains v2.20.0. I returned it to Draft. Preserve ADR 0282, inherit the parent contracts without claiming their RED as GREEN, add the version-sync RED, and align runtime provenance to v2.39.0. Do not flatten the parent’s intentional Vietnamese-copy RED or predecessor evidence.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-parent reconstruction run 34006065556 correctly failed closed on exactly five paths: docs/product-technical-gap-baseline.md, frontend/src/i18n.test.ts, frontend/src/i18n.ts, frontend/src/leftoverMapPlotVietnameseCopy.test.ts, and lineageweave/__init__.py. This is a repairable successor-overlap, not grounds to close the v2.39 item-coverage delta. Semantic resolution is constrained: keep the current #812 baseline authority instead of resurrecting the child’s stale Aug-30 protected-head overlay, then add only a current v2.39 convergence note; preserve the child’s new item-coverage keys/caption while inheriting #812’s repaired Vietnamese explained-share wording (tỷ phần ...); keep the parent Vietnamese regression test that imports LEFTOVER_MAP_PLOT_CAPTION instead of the child’s stale duplicated caption literal; keep v2.39.0 runtime identity. Any conflict outside these five paths must still fail closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant