feat(reports): leftover-map incomplete item coverage on graphic display (v2.41.0) - #815
Conversation
…ay (v2.41.0) Caption the leftover-map graphic display with persisted leftover-map incomplete item coverage (ADR 0284). After make seed, closest and farthest leftover pairs sit above the member list with a plot caption that matches leftover-map incomplete item coverage; click a post marker or a pair button opens that post. A missing, non-integer, or negative dropped count, or a dropped count that contradicts usable item complete-case integers, omits that leftover-map incomplete item caption. Dropped 0 is shown when that persisted dropped count is a non-negative integer. Do not invent dropped criteria from scored minus used, plotted criterion marker count, leftover-map distance, leftover-map rank, leftover-map post coverage, leftover-map item coverage, leftover-map incomplete post coverage, or the count of unused axes. Never invent a leftover score or a theta. UI-only; no new columns.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cycle 2026-08-30T11:42Z: leftover-map incomplete item coverage (#815 @ 63092de) is stacked on #814 ( Frontend oxlint 0/0; vitest leftoverMapCoverage + LeftoverMapPlot + LeftoverPairList + i18n + App leftover bits 306 passed. Next buyer increment after independent review of this layer: leftover-map incomplete coverage on the pair-list note (still post-only today) — not mixed into this PR. Do not persist leftover-map inner product, cosine, or length. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| function leftoverMapDroppedCount( | ||
| dropped: number, | ||
| used: number, | ||
| scored: number, | ||
| ): LeftoverMapIncompleteCount | null { | ||
| if (!Number.isInteger(dropped) || dropped < 0) { | ||
| return null; | ||
| } | ||
| const completeCase = leftoverMapCompleteCaseCounts(used, scored); | ||
| if (completeCase !== null && dropped !== completeCase.scored - completeCase.used) { | ||
| return null; | ||
| } | ||
| return { dropped }; |
There was a problem hiding this comment.
📝 Info: Independent counts remain usable
leftoverMapDroppedCount keeps a valid persisted count when neighboring totals are malformed. It rejects contradictions only when both totals support reconciliation.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Cycle 2026-08-30T21:19 KST: independent APPROVE still required before squash. Do not self-approve. Next buyer gap after v2.41.0 incomplete item coverage will land on a fresh stacked branch (v2.42.x), not mixed into this head. |
|
Cycle 2026-08-30T21:19 KST retry: independent APPROVE still required before squash. Do not self-approve. Next buyer gap after v2.41.0 incomplete item coverage lands on a fresh stacked branch (v2.42.x pair-list item complete-case coverage), not mixed into this head. |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Fresh parent/release-identity finding on exact head 63092ded55a7c7d65b0f6586980b20d0d30f587d: this child still points at predecessor #814 772928722…, while live #814 is d837883c67fa9753f4b0cbf4326d33759bdd98eb and has five non-force repair commits. The parent repair files (docs/index.md, short-canvas regression, Vietnamese explained-share RED, runtime __version__, and tests/test_package_version.py) are disjoint from this PR's original ADR 0284/UI delta except for release identity: this child declares v2.41.0 in pyproject.toml but runtime lineageweave.__version__ is still v2.20.0. Do not choose either whole tree. Add the parent's package-version contract as a realistic RED, causally align this child runtime identity to v2.41.0, adopt the parent's non-overlapping Pages/short-canvas/Vietnamese RED contracts, then join the repaired child to live #814 with a non-force two-parent convergence commit. Preserve the inherited Vietnamese RED intentionally; predecessor GREEN/review evidence does not transfer.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Fresh stack-authority finding: this Draft's body still names #815's predecessor identity 63092de… as if it were the current child state for downstream work, while the live #815 head is c9f864383ebc9222bb3e69008e51b81ce14540cb and its parent #814 repair line is d837883c67fa9753f4b0cbf4326d33759bdd98eb. Because #814 still carries the inherited Vietnamese explained-share RED, predecessor 306-test/oxlint observations do not establish exact-head GREEN for this moved descendant. Preserve ADR 0284/product delta, keep Draft, and make the PR body explicit about current parent/head and non-transfer of predecessor evidence rather than leaving stale stack authority.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head governance finding on c9f864383ebc9222bb3e69008e51b81ce14540cb: Draft PR #815 still declares ADR 0284 Accepted. Preserve the incomplete-item coverage semantics and current v2.41.0 identity, but after #813→#814 convergence rebuilds the parent stack, reconstruct #815 non-force and carry ADR 0284 as Proposed until unchanged-head acceptance evidence exists. Do not create a status-only side fork before the parent changes.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head governance finding: ADR 0284 remains Accepted while #815 is Draft and has no qualifying unchanged-head independent acceptance. Preserve the valid v2.41 incomplete-item-coverage delta, but return ADR 0284 to Proposed when reconstructing this child from the repaired #814 parent. Do not close or flatten the successor.
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Caption the leftover-map graphic display with persisted leftover-map incomplete item coverage (ADR 0284 / v2.41.0). Missing/invalid dropped-item coverage omits only that caption; persisted zero remains valid. Do not derive dropped criteria from scored-minus-used, plotted markers, distance, rank, neighbouring coverage values, or unused axes. UI/read-model only; no SQL or measurement authority.
Current exact ancestry
Exact current parent is #814
bd90a974b72c649c423a7b99ee47dae1d8236b0e. Current #815 product head isc02dffc264f70283ff7ff2d07bfe83a47bd13e10, a non-force two-parent product commit whose first parent is prior #815 and second parent is exact #814. The v2.41 product/release/governance delta remains unchanged; ADR0284 isProposedwhile unmerged and runtime/package/frontend identity remains 2.41.0.Verified convergence and descendant authority
Run
34045864491, job101520673092, completed GREEN and produced workflow-free treef4370740028d43f935f2d85b38e20fcd60ce8bf0, recreated as current productc02dffc...by non-force fast-forward. Its inherited parent delta was limited tofrontend/src/leftoverMapPlotLayout.test.ts; predecessor checks/approval do not transfer.#816 is current at
4d81c881469496fedeb8d9bb98cd485209df2089, #817 ataa47c96e15084d0b944558b980edef34133f8040, #818 atde3a61988768bcfddcab1dec3dfe3c60f9a89743, and #819 atf37ca315e3c48fa37bbcafe96e46c5d7dab991b7, each through verified non-force current-parent convergence. #820 is now the earliest stale descendant; run34054337875reconstructs its valid singular-value v2.46 delta from exact #819 and repairs the observed current-parent conflicts plus ADR/release state. #821 remains dependent under a distinct future ADR/release identity.Keep Draft. Fresh exact-product-head required checks, applicable browser/Storybook/a11y evidence, authenticated acceptance where applicable, and qualifying independent approval remain required. No force-push, destructive rebase, self-approval, gate weakening, predecessor-evidence transfer, or invented measurement values.