feat(reports): leftover-map cross share on grouping comparison graphic (v2.70.0) - #853
Conversation
…c (v2.70.0)
Caption persisted leftover-map cross share x on the grouping
comparison leftover-map graphic from already-named leftover_map_cross_share
(ADR 0313). Comparison copy uses leftover map comparison graphic cross
share {label} so it stays distinct from hyphen leftover-map cross
share {label} and from strip Leftover map comparison cross share.
A missing or non-finite x omits that caption and keeps leftover-map
unexplained leftover share, leftover-map explained leftover share,
leftover-map reconstruction, leftover-map distance, and comparison
graphic coverage notes. Rank-0 origin cells still name 2R̂U/R² 0.00
when that share is finite. Do not caption leftover-map unexplained leftover
this increment. Do not invent x from R̂, U, and R or leftover-map distance.
Never invent a leftover score. Never invent a theta. No new columns.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cycle 2026-08-31 ~07:30 KST: stacked onto #852 @ |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| aria-label={tf( | ||
| variant === "comparison" | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_CROSS_SHARE | ||
| : LEFTOVER_MAP_PLOT_SEGMENT_CROSS_SHARE, | ||
| { label: segment.crossShareLabel }, | ||
| )} |
There was a problem hiding this comment.
📝 Info: Variant switch preserves cross-share semantics
The variant branch changes only accessible copy. Persisted-value formatting, omission rules, visible text, and report labels remain unchanged.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Copilot review requested on exact head |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head Tests 34005567074 is a real inherited foundation RED, not a defect isolated to the v2.70 cross-share delta. The full PostgreSQL/Python job reached 1766 passed / 147 skipped / 1 failed; the only failure is package provenance (lineageweave.__version__ == 2.41.0 while pyproject/frontend ship 2.70.0). The frontend job reproduces the same small-canvas caption-bounds and Vietnamese explained-share/caption-fixture regressions already rooted at #841. Keep ADR0313/v2.70.0 and the cross-share delta Draft. Repair the shared plot/copy foundation at #841, then converge #844→#845→…→#852→this child non-force in order, setting each successor runtime version to its own shipped version as part of reconstruction. Do not duplicate the shared UI/copy patch here or transfer predecessor GREEN.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head governance finding on fab1cfd587bc6495c9d1084e86774b1378b411c6: this PR is still Draft while ADR 0313 is marked Decision status: Accepted. Treat that as a repair finding, not settled authority. Because this plot-composition chain also inherits the shared #840 source drift, do not add another downstream-only governance fork: after #840 is repaired and the intervening stack is reconstructed non-force, carry the #853 cross-share delta forward and set ADR 0313 to Proposed on the reconstructed exact head before any readiness transition.
|
Scheduled review-feedback autofix for this PR head.
|
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Caption persisted leftover-map cross share on the grouping-comparison leftover-map graphic (ADR 0313 / v2.70.0). Read-model/UI composition only: no SQL/new columns, no invented score/theta, and no derivation from geometry, rank, coverage, reconstruction, pair count, or unused-axis count.
Live authority
#852@80b9254aea2177f2bb506acf0370688df424a036fab1cfd587bc6495c9d1084e86774b1378b411c6Repair findings
Required Tests
34005567074fail on inherited small-canvas/Vietnamese/runtime drift rather than the v2.70 cross-share semantics. Current-head review5124396748also verifies ADR 0313 is prematurelyAcceptedwhile this PR remains Draft; it must beProposedon the reconstructed candidate.The earlier description that the shared source repair is owned at #841 is superseded by fresh ancestry inspection. Current #812 already contains the reviewed small-canvas and Vietnamese implementation; the later stack loses it because #813 and descendants are not yet fully reconstructed from the current parent. Runtime identity divergence first appears at #816 when package version becomes 2.42.0 but runtime remains 2.41.0. Therefore finish #813 convergence, rebuild descendants in order with per-release identity repair, then reconstruct #853 from the then-current #852 while preserving this cross-share delta and setting ADR0313 Proposed. Do not create another branch-local copy of the shared source fix.
Product invariants
leftover map comparison graphic cross share {label}, distinct from the period-report and strip names.Keep Draft. Predecessor checks/approval do not transfer. Fresh exact-head required/frontend/browser/a11y evidence and qualifying independent approval remain required after reconstruction.