feat(reports): fail-close leftover-map pair-list post coverage (v2.45.0) - #819
Conversation
Caption leftover-map post complete-case coverage on the pair list only when leftoverMapCoverageCounts returns usable complete-case integers (ADR 0288). A used-greater-than-scored, negative, or non-integer payload omits that note. UI-only; no SQL; no new columns. Never invent a leftover score. Never invent a theta.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| aria-label={openedGroupingLabel ? "Opened grouping report" : "Period report groups"} | ||
| > | ||
| {orderedReports.map((report) => { | ||
| const coverageCounts = leftoverMapCoverageCounts(report.leftover_map_coverage); |
There was a problem hiding this comment.
📝 Info: Shared validation preserves coverage semantics
leftoverMapCoverageCounts rejects malformed persisted counts while preserving valid zero-used coverage. It never derives post coverage from neighboring display data.
Was this helpful? React with 👍 or 👎 to provide feedback.
| export const LEFTOVER_MAP_LIST_COVERAGE_LABEL = "Leftover map coverage"; | ||
|
|
||
| export const LEFTOVER_MAP_PLOT_COVERAGE = | ||
| "Leftover map used {used} of {scored} scored posts (complete-case)"; |
There was a problem hiding this comment.
📝 Info: Shared text keeps labels distinct
The list and plot intentionally share translated coverage text. LEFTOVER_MAP_LIST_COVERAGE_LABEL keeps their accessible names independently addressable.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Write-retry this cycle (seonghobae MCP). #819 is leftover-map v2.45 fail-close pair-list post coverage at This cycle stacks leftover-map graphic axis singular values ( |
|
Write-retry this cycle (seonghobae MCP). #819 remains leftover-map v2.45 fail-close pair-list post coverage at This cycle stacks leftover-map complete-case coverage on the grouping comparison strip as v2.46 / ADR 0289 on this head (include persisted leftover_map_coverage on GET /api/reports/compare/{period}; caption each strip row through leftoverMapCoverageCounts; distinct aria-label |
|
Stacked leftover-map graphic axis singular values ( |
|
Stacked #821 ( |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Parent-first finding: Ready is premature while base #818 and the upstream leftover-map stack remain unmerged. Preserve this fail-closed coverage delta and return the dependent PR to Draft.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head repair finding: this Draft successor still has two inherited governance/provenance defects that must be repaired during reconstruction after #818 is cleanly promoted. ADR 0288 is Accepted while unmerged/Draft; keep the valid v2.45 fail-close post-coverage delta but require an executable governance RED and restore ADR 0288 to Proposed. Separately, pyproject.toml declares 2.45.0 while lineageweave.__version__ remains 2.41.0, so the existing release-synchronization contract should reproduce a RED before the minimal runtime correction to 2.45.0. Do not replay the historical #818 convergence commit or recreate the already-repaired Vietnamese/small-canvas authority locally; reconstruct from the future exact #818 parent and regenerate evidence.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head repair finding: the valid v2.45 UI delta is separable from the historical docs/product-technical-gap-baseline.md overlay. That overlay still asserts an Aug-30 protected-main SHA/state and old open-stack inventory, so replaying the feature commit wholesale onto the newly promoted #818 parent would regress code-current authority. Reconstruct from exact #818, preserve the product delta, restore the current parent baseline, then add only a current #819 reconstruction note. The same candidate must reproduce release/governance REDs before changing runtime to 2.45.0 and ADR0288 to Proposed. Do not replay the historical convergence merge or stale scheduler-era baseline text.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Upstream-authority correction after this lane completed: #811 subsequently advanced non-force to 4dcd789385f67c76a4e479194f566f35bb5d2d76, while #812 product head still remains aea06ad7c70f4542a1413b6003d414c0c42d59a7 and its current-parent convergence run 34036103266 is queued. The promoted #819 tree is valid evidence for its local v2.45 repair, but it is not yet final stack authority because #812→#818 will have to converge on the moved #811 foundation. Do not advance #820/#821 product promotion from this provisional ancestry. Preserve #819's valid delta and reconstruct/converge it non-force after the upstream chain has absorbed the #811 test-boundary delta.
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Fail-close leftover-map post complete-case coverage on the pair list through
leftoverMapCoverageCounts(ADR0288 / v2.45.0). Missing, invalid, negative, non-positive-denominator, or used-greater-than-scored coverage omits only that note; valid persisted0 of Mremains visible. UI/read-model only; no SQL or measurement authority changes.Current exact ancestry
Current product head
f37ca315e3c48fa37bbcafe96e46c5d7dab991b7preserves prior #819e6e3c5d0bad22292005f49c07b1c97944b0442d6as first parent and exact #818de3a61988768bcfddcab1dec3dfe3c60f9a89743as second parent. Workflow-free product tree is2d0fb56144e67d0f4b0d8a52aa4faaa866bd6939. Run34053742534completed current-parent GREEN; predecessor checks/approval do not transfer.Descendant boundary
#820 is current exact
503d043e165e0ae4c6b5c8cca4366c114c74ef2d(ADR0289/v2.46.0) and #821 is current exact93eaa40f34098678fd53da4dbdccb1782dfd41a7(ADR0290/v2.47.0). #821's authorization repair omits persisted grouping coverage whenever ABAC hides any persisted grouping member, preventing hidden denominator disclosure without recalculating psychometric coverage.#822 now bases on exact #821 as ADR0291/v2.48.0. Current reconstruction r9
34066701457restores the repository-authoritative pinned Rust + frozen uv + Corepack/pnpm dependency contract after r7/r8 isolated an incorrect npm frontend-install harness. #823/#824/#825 are explicitly serialized after #822 as ADR0292/v2.49.0, ADR0293/v2.50.0, and ADR0294/v2.51.0 respectively; their historical identities are evidence only until reconstruction.Keep Draft. Fresh exact-product-head required checks, applicable Storybook/browser/a11y evidence, authenticated acceptance where applicable, and qualifying independent approval remain required. No self-approval, protection bypass, force-push, destructive rebase, stale evidence transfer, or invented measurement values.
Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.