feat(reports): leftover-map singular values on graphic axes (v2.46.0) - #820
Conversation
Caption leftover-map graphic axes with persisted leftover-map singular values σ_k when finite and non-negative (ADR 0289). Share and singular value omit independently. Do not invent σ_k from leftover-map axis share. UI-only; no SQL; no new columns. Never invent a leftover score. Never invent a theta.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Write-retry this cycle (seonghobae MCP). #820 is leftover-map v2.46 graphic axis singular values at |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Write-retry this cycle (seonghobae MCP). GitHub writes succeed. #96 remains closed. #820 is leftover-map v2.46 graphic axis singular values at |
|
Stacked leftover-map singular values on leftover-axis badges as #823 ( |
|
Scheduled review-feedback autofix for this PR head.
|
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head topology/governance finding: this Draft sibling and #821 both claim ADR 0289 and release identity v2.46.0 for different product decisions, while their immediate parent #819 is itself pending reconstruction. That duplicate ADR/release authority cannot be promoted as-is. Preserve this singular-value delta, but do not retarget around #819 to #782 as the current body proposes. After #818→#819 current-parent convergence, resolve the #820/#821 sibling ordering and assign unique ADR/release identities in that reconstructed ancestry; keep decisions Proposed until independent acceptance. No historical checks or convergence merge should transfer.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-parent reconstruction finding after #819 promotion: exact #820 b7222713a69acdf3d32bbce992001a2433946d21 is now structurally diverged from #819 e6e3c5d0bad22292005f49c07b1c97944b0442d6. The valid singular-value delta declares package/frontend v2.46.0 and Draft ADR0289 as Accepted; historical runtime is stale. Reconstruct only the singular-value delta on exact #819, restore the parent gap-baseline authority instead of replaying its scheduler-era overlay, add an executable Draft-governance regression, demonstrate package/runtime and governance REDs, then minimally set runtime 2.46.0 and ADR0289 Proposed. Keep this lane first in the duplicate sibling topology; #821 must not reuse ADR0289/v2.46 after #820 promotion.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-parent repair finding: #819 has now moved non-force to f37ca315e3c48fa37bbcafe96e46c5d7dab991b7, so this historical single-commit v2.46 delta must be reconstructed on that exact parent. The prior diagnostic run 34037319178 is a real RED but not a product RED: git cherry-pick --no-commit b7222713... stopped on two integration conflicts (docs/product-technical-gap-baseline.md and frontend/src/components/LeftoverMapPlot.test.tsx) before governance/release tests ran. Repair must keep current-parent baseline authority, preserve the parent-only rounded-tick regression, and retain the singular-value rendering tests rather than choosing one side wholesale. ADR0289 remains Proposed while Draft and runtime/package/frontend must converge at 2.46.0. #821 still cannot reuse ADR0289/v2.46.0 for its distinct decision.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
r3 34055722596 exposed a second valid reconstruction-harness defect after release/governance GREEN: it copied current-parent axis-share tests verbatim into the v2.46 singular-value feature. Those parent tests intentionally exercised share captions before singular-value badges existed, so their fixtures carry finite leftover_singular_value; under the v2.46 contract the resulting axis labels must include σ, making the pre-v2.46 text expectations stale. This is not a product regression and the singular-value source must not be weakened. r4 34059089708 keeps the three parent regressions but semantically isolates the two share-only cases by making singular value unavailable in those fixtures; the rounded-tick regression is copied unchanged. It then repeats release/governance RED→minimal fix, frontend contracts, lint/build/Storybook and only on full GREEN creates a workflow-free two-parent product commit with first parent exact historical #820 and second parent exact current #819.
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Caption leftover-map graphic axes with persisted leftover-map singular values
σ_k(ADR0289 / v2.46.0). Missing, non-finite, or negative singular values omit only theσbadge; rank-0 unused axes may name persistedσ 0.00. Share and singular-value omission remain independent. UI/read-model only; no SQL, new columns, invented theta/leftover score, or derivedσ.Current product ancestry
#820 is reconstructed on exact #819. Product head
503d043e165e0ae4c6b5c8cca4366c114c74ef2d, tree4cfaffc087f9f6ce593d1ba44b05e384401b2799, has historical #820b7222713a69acdf3d32bbce992001a2433946d21as first parent and exact #819f37ca315e3c48fa37bbcafe96e46c5d7dab991b7as second parent. The branch advanced non-force; temporary reconstruction files are absent.Run
34059616051/ job101557680373completed exact-input verification, realistic release/governance RED, TypeScript RED, minimal causal fixes, Python/TypeScript/frontend GREEN, oxlint, Vite build, Storybook, and workflow-free promotion. ADR0289 remains Proposed while Draft and package/frontend/runtime identity is 2.46.0. Isolated reconstruction evidence is not hosted exact-head acceptance.Descendant authority
#821 is cleanly promoted as exact child
93eaa40f34098678fd53da4dbdccb1782dfd41a7, ADR0290/v2.47.0. Its RED→fix closes the partial-visibility denominator leak by omitting persisted grouping coverage whenever caller-visible persisted membership is incomplete.#822 now bases on exact #821 and owns ADR0291/v2.48.0 item complete-case coverage. Its r7/r8 harnesses proved the frozen Python
dev+backendinstallation succeeds and isolated failure to an incorrect npm frontend installation path; exact repository CI uses Corepack + frozen pnpm. Current r934066701457restores the repository-authoritative Rust/uv/Corepack/pnpm dependency contract and splits every GREEN dimension before any workflow-free promotion.#823 has been retargeted after #822 for ADR0292/v2.49.0, #824 after #823 for ADR0293/v2.50.0, and #825 remains after #824 for ADR0294/v2.51.0. Valid descendant deltas remain Draft; collided historical identities are evidence only.
Keep Draft until fresh exact-product-head required checks, applicable browser/Storybook/a11y evidence, and qualifying independent approval exist. No close, force-push, destructive rebase, self-approval, gate weakening, parent bypass, or invented measurement values.
Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.