Skip to content

feat(reports): leftover-map unexplained leftover on grouping comparison graphic (v2.71.0) - #854

Draft
seonghobae wants to merge 2 commits into
feat/leftover-map-compare-plot-cross-share-v2700from
feat/leftover-map-compare-plot-unexplained-leftover-v2710
Draft

feat(reports): leftover-map unexplained leftover on grouping comparison graphic (v2.71.0)#854
seonghobae wants to merge 2 commits into
feat/leftover-map-compare-plot-cross-share-v2700from
feat/leftover-map-compare-plot-unexplained-leftover-v2710

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Caption persisted leftover-map unexplained leftover U on the grouping-comparison graphic (ADR 0314 / v2.71.0). Missing/non-finite U omits only that caption; finite negative and zero values remain visible. Do not derive U from R, , coordinates, rank, coverage, pair counts, or unused-axis counts. No SQL/new columns or new measurement authority.

Live stack authority

Repair findings

Current-head review 5124397105 records two repair requirements: reconstruct this valid unexplained-leftover delta after #853 itself is rebuilt from repaired ancestry, and change ADR 0314 from premature Accepted to Proposed while the PR remains Draft.

The structural order begins earlier: current #812 already contains the reviewed small-canvas/Vietnamese source truth; #813 and later descendants must be reconstructed in order, and runtime release identity must be synchronized from the first v2.42 mismatch at #816 onward. Accordingly, do not create a new #854-only source fork now. After #853 is reconstructed onto its repaired parent, rebuild #854 non-force, preserve this branch's U semantics, resolve only reviewed overlaps, set ADR0314 Proposed, and rerun exact-head contracts.

Keep Draft. Predecessor checks/approval do not transfer. Fresh exact-head backend/frontend/browser/a11y evidence and qualifying independent approval remain required.

…on graphic (v2.71.0)

Caption persisted leftover-map unexplained leftover U on the grouping
comparison leftover-map graphic from already-named leftover_map_unexplained
(ADR 0314). Comparison copy uses leftover map comparison graphic unexplained
leftover {label} so it stays distinct from hyphen leftover-map unexplained
leftover {label} and from strip Leftover map comparison unexplained leftover.
A missing or non-finite U omits that caption and keeps leftover-map
cross share, leftover-map unexplained leftover share, leftover-map explained
leftover share, leftover-map reconstruction, leftover-map distance, and
comparison graphic coverage notes. Rank-0 origin cells still name U 0.00
when that leftover is finite. Do not caption leftover residual this increment.
Do not invent U from R and R̂ or leftover-map distance. Never invent a leftover
score. Never invent a theta. No new columns.

Copy link
Copy Markdown
Contributor Author

Copilot review requested on exact head 935cdea (v2.71.0 leftover-map unexplained leftover on grouping comparison graphic, ADR 0314). Independent APPROVE required. Copilot/Devin COMMENT is not independent APPROVE. Do not self-approve. Do not squash-merge onto the unprotected leftover base. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240 / #782). Next deferred caption is leftover residual R on the comparison graphic (strip already ADR 0298). Issues #79 and #87 stay open.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Queue retry 2026-08-31T08:01 KST: Full test suite green; Frontend lint/test/build green; Devin Review commented with no issues. Independent APPROVE still required on exact head 935cdea. Do not self-approve. Do not squash onto the unprotected leftover base. Next buyer gap is leftover residual on the grouping comparison leftover-map graphic (distinct comparison-graphic name; residual already on the strip via ADR 0298).

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31 08:19 KST: exact head 935cdea has Frontend lint/test/build + Full test suite success. Devin COMMENT only — no independent APPROVE on this head. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Next buyer gap is leftover residual on the grouping comparison leftover-map graphic (distinct comparison-graphic name; residual already sits on the strip via ADR 0298). Stacked PR will open onto this head after the increment lands.

Copy link
Copy Markdown
Contributor Author

Writes work this cycle. #855 (feat/leftover-map-compare-plot-residual-v2720 @ 4ffed4a, ADR 0315 / v2.72.0) is stacked on this exact head. Caption leftover residual R on the grouping comparison leftover-map graphic with distinct accessible name leftover map comparison graphic residual {label}. Leave both PRs open for independent review. Do not self-approve. Do not squash-merge.

Copy link
Copy Markdown
Contributor Author

Independent APPROVE still required on this exact head 935cdea (v2.71.0). #855 leftover residual (v2.72.0) is stacked here at 1087b16. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open.

@seonghobae
seonghobae marked this pull request as draft September 4, 2026 08:06
Adopt the conflict-free GitHub test-merge tree for exact parent #853 11fc346 while preserving existing #854 product head 935cdea as first-parent ancestry. No force push and no product delta is dropped.
seonghobae added a commit that referenced this pull request Sep 6, 2026
Adopt the conflict-free GitHub test-merge tree for exact parent #854 eb4ffef while preserving existing #855 product head 1087b16 as first-parent ancestry. No force push and no product delta is dropped.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-head finding on eb4ffef04677d6e1d67fe1325cfdf1bbb2db2245: this Draft PR still points to old #853 snapshot 11fc346299f9d4a96e4ba397ba373e275af2fce1, while current #853 is fab1cfd587bc6495c9d1084e86774b1378b411c6; the current compare is diverged and #854 is 22 commits behind. ADR 0314 is also marked Accepted although the PR is Draft. After the #840 foundation repair and #853 current-parent reconstruction, rebuild #854 from the current #853 while preserving its unexplained-leftover delta, and set ADR 0314 to Proposed before readiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant