feat(reports): leftover-map incomplete post coverage on pair list (v2.43.0) - #817
Conversation
….43.0) Caption the leftover pair list with persisted leftover-map incomplete post coverage (ADR 0286). After make seed, closest and farthest leftover pairs sit above the member list with a pair-list note that matches leftover-map incomplete post coverage; click a post marker or a pair button opens that post. A missing, non-integer, or negative dropped count, or a dropped count that contradicts usable complete-case integers, omits that leftover-map incomplete post note. Dropped 0 is shown when that persisted dropped count is a non-negative integer. Do not invent dropped posts from scored minus used, plotted marker count, leftover-map distance, leftover-map rank, leftover-map post coverage, leftover-map item coverage, or the count of unused axes. Never invent a leftover score or a theta. UI-only; no new columns.
|
Cycle 2026-08-30T21:37 KST: stacked v2.43.0 pair-list incomplete post coverage (ADR 0286) @ ef30930 onto #816. Independent APPROVE required before squash. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Copilot/Devin review is not independent APPROVE. Next buyer gap after this head is pair-list incomplete item coverage (v2.44.x), not mixed into this PR. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| > | ||
| {orderedReports.map((report) => { | ||
| const itemCoverageCounts = leftoverMapItemCoverageCounts(report.leftover_map_coverage); | ||
| const incompletePostCount = leftoverMapIncompletePostCount(report.leftover_map_coverage); |
There was a problem hiding this comment.
| {incompletePostCount !== null ? ( | ||
| <p className="post-meta" role="note" aria-label={t(LEFTOVER_MAP_LIST_INCOMPLETE_POST_LABEL)}> | ||
| {tf(LEFTOVER_MAP_PLOT_INCOMPLETE_POST, incompletePostCount)} | ||
| </p> | ||
| ) : null} |
|
Cycle retry 2026-08-30T13:38Z: write-path probe. Independent APPROVE still required on exact head; no self-approve. |
|
Stacked leftover-map incomplete item coverage on the pair list as #818 ( |
seonghobae
left a comment
There was a problem hiding this comment.
Fresh stack-authority finding: this body still names predecessor #816@1e3d13e…, while live #816 has advanced to 326a2f016f7bbf1f01bffdffa8b96a9b1451b6c0. #817 remains exact head ef30930271a729044af2f690df04f0b89f751ffd, Draft, with the upstream Vietnamese explained-share RED still inherited. Preserve ADR 0286/incomplete-post pair-list semantics, but refresh the live parent/evidence boundary and do not transfer the predecessor 316-test/oxlint observations to current-stack acceptance.
seonghobae
left a comment
There was a problem hiding this comment.
Descendant-convergence follow-up after repairing #816: parent #816 is now non-force head 7e8653d89c77c3cb6771dcf592517baf691eeebc, while this child remains ef30930271a729044af2f690df04f0b89f751ffd. Fresh compare is diverged (ahead_by=1, behind_by=11, merge base 1e3d13e…) and GitHub now reports this PR conflicting. Do not manufacture a two-parent tree by choosing one side wholesale: ADR 0286 changes several of the same App/i18n/coverage/version files as repaired parent #816. Keep the valid child delta and Draft state, record the exact conflict boundary, and reconstruct only with a content-preserving three-way merge/test rather than force-push or destructive rebase.
seonghobae
left a comment
There was a problem hiding this comment.
Fresh verification after retargeting the PR base to current #816: the PR base now resolves to 7e8653d89c77c3cb6771dcf592517baf691eeebc, but refs/pull/817/merge still points to 59faf55056c801d7755321aa6463e3d570a46ce4, whose parents are the stale #816 head 326a2f0… and this child ef30930…. Therefore a transient normalized mergeable=true must not be treated as a current-parent merge tree. No descendant reconstruction should promote that stale test-merge tree. Keep Draft and require a merge/reconstruction artifact whose parent is current #816@7e8653d…, with content verification across the overlapping App/i18n/coverage/version files.
seonghobae
left a comment
There was a problem hiding this comment.
Current-head governance finding: docs/adr/0286-leftover-map-list-incomplete-post.md declares **Decision status:** Accepted while #817 is still Draft and has no qualifying unchanged-head independent acceptance. Preserve the v2.43 incomplete-post pair-list delta, but when #816's repaired ancestry is promoted and this child is reconstructed, add an executable governance regression and keep ADR 0286 Proposed. Do not close or bypass this child; the valid feature delta remains required.
seonghobae
left a comment
There was a problem hiding this comment.
Fresh current-head review after #816 promotion found two repair blockers that must converge with the parent reconstruction rather than be deferred downstream. First, ADR 0286 is Accepted while this PR is still Draft and has no qualifying unchanged-head independent acceptance; the reconstructed candidate needs an executable governance RED and Proposed. Second, this v2.43 child declares package/frontend 2.43.0 while lineageweave.__version__ is still 2.41.0 on the historical product head, so the existing package-version contract must fail before the causal runtime fix to 2.43.0. Preserve the valid incomplete-post pair-list delta, reconstruct non-force from exact #816 8ac4f2677ac90bbcc7609d87135f4efcae28d506, and do not replay the historical convergence merge or transfer predecessor checks/approvals.
seonghobae
left a comment
There was a problem hiding this comment.
Current-parent verification found the expected structural drift after #816 advanced non-force to 4d81c881469496fedeb8d9bb98cd485209df2089: #817 remains at 9604ace428681de963519d058e39c01e41e3c73f on the prior #816 ancestry. The inherited delta from prior #816 to current #816 is limited to frontend/src/leftoverMapPlotLayout.test.ts. Repair is executing in automation/817-current-816-convergence-20260907@b9a54ddc409e5b57ad26015b829fa40f8c4a9d49 / run 34052935980; no GREEN or product promotion is claimed until the workflow-free candidate is terminal and re-inspected.
Summary
Caption the leftover pair list with persisted leftover-map incomplete-post coverage (ADR 0286 / v2.43.0). Missing, non-integer, negative, or complete-case-inconsistent dropped-post count omits only that note; persisted dropped
0remains visible. Do not derive dropped posts from scored-used, plotted markers, distance, rank, other coverage values, or unused axes. UI/read-model only; no SQL, theta/score authority, or persisted vector-derived score.Valid local repair and current ancestry
The v2.43 reconstruction reproduced release/governance REDs, changed only runtime to 2.43.0 plus ADR0286
Proposed, and produced the valid v2.43 tree. Current-parent run34052935980then converged prior #817 non-force onto exact #8164d81c881469496fedeb8d9bb98cd485209df2089, admitting only the inheritedfrontend/src/leftoverMapPlotLayout.test.tsrank-boundary delta and re-running ADR0286/package-version plus inherited presentation contracts. The workflow-free tree was recreated as current productaa47c96e15084d0b944558b980edef34133f8040. Predecessor checks/approval do not transfer.Descendant authority
#818 is current at
de3a61988768bcfddcab1dec3dfe3c60f9a89743and #819 atf37ca315e3c48fa37bbcafe96e46c5d7dab991b7, both through verified non-force current-parent convergence. #820 is now the earliest stale descendant; run34054337875reconstructs its singular-value v2.46 delta from exact #819 while preserving current-parent tests/docs and repairing ADR/release state. #821 stays dependent under a distinct future ADR/release identity. Do not replay old convergence commits or transfer predecessor evidence.Keep Draft. Fresh exact-product-head required checks, applicable Storybook/browser/a11y evidence, authenticated acceptance where applicable, and qualifying independent approval remain required. No force-push, destructive rebase, self-approval, gate weakening, or invented measurement values.
Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.