feat(reports): leftover-map incomplete item coverage on pair list (v2.44.0) - #818
Conversation
….44.0) Caption the leftover pair list with persisted leftover-map incomplete item coverage (ADR 0287). Dropped 0 is shown. Do not invent dropped criteria from scored minus used or plotted criterion markers. UI-only; no SQL; no new columns. Never invent a leftover score. Never invent a theta.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
📝 Info: Persisted count remains authoritative
leftoverMapIncompleteItemCount rejects contradictory usable coverage but never derives a replacement. Invalid companion counts leave a valid persisted dropped count intact.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
| {incompleteItemCount !== null ? ( | ||
| <p className="post-meta" role="note" aria-label={t(LEFTOVER_MAP_LIST_INCOMPLETE_ITEM_LABEL)}> | ||
| {tf(LEFTOVER_MAP_PLOT_INCOMPLETE_ITEM, incompleteItemCount)} | ||
| </p> | ||
| ) : null} |
There was a problem hiding this comment.
📝 Info: List and plot labels stay distinct
The pair list uses its new accessible label while sharing the translated count message. The plot retains its separate label.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Cycle retry 2026-08-30T13:48Z: write path works. Independent APPROVE still required on exact head |
|
Stacked leftover-map pair-list post complete-case fail-close (ADR 0288 / v2.45.0) is #819 @ |
|
Cycle retry 2026-08-30T13:55Z: GitHub writes work (comment/close/create-PR/push). Independent APPROVE still required on exact head |
|
Write-retry this cycle (seonghobae MCP). #818 remains stacked leftover-map v2.44 incomplete-item pair-list coverage at Parallel cycle already shipped |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head governance finding: ADR 0287 is Accepted while #818 remains Draft without qualifying unchanged-head independent acceptance. Keep the v2.44 incomplete-item pair-list delta, but when repaired #817 ancestry reaches this child, add an executable governance regression and set ADR 0287 to Proposed on the reconstructed candidate. This is a repair finding, not grounds to close or bypass the dependent PR.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Fresh descendant review adds one release-provenance blocker to the existing ADR0287 Draft-governance finding. This v2.44 child declares package version 2.44.0 while the historical runtime still reports lineageweave.__version__ = "2.41.0". Do not defer that drift farther down the stack. After #817 is cleanly promoted, reconstruct #818 non-force from the new exact parent, preserve only its valid incomplete-item pair-list product delta, require the existing release-synchronization contract to reproduce a RED, then apply the minimal runtime 2.44.0 correction together with ADR0287 Proposed. The old Vietnamese-source-blocker wording is stale; preserve the repaired parent authority instead of recreating it here.
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Caption the leftover pair list with persisted leftover-map incomplete-item coverage (ADR 0287 / v2.44.0). Missing, non-integer, negative, or complete-case-inconsistent dropped-item counts omit only that note; persisted dropped
0remains visible. Do not derive dropped items from scored-used, marker counts, distance, rank, other coverage values, or unused axes. UI/read-model only; no SQL, theta/score authority, or persisted vector-derived score.Valid local reconstruction evidence
The v2.44 reconstruction replayed only valid product delta
aa3208959950637b52001457e7d4dfc1ef1764eb, reproduced release/governance REDs, changed only runtime to 2.44.0 and ADR0287 toProposed, verified inherited contracts, and promoted workflow-free productbc971a402ef9faecb2f0b4ffd743092f4779d76b. This remains valid local repair evidence; predecessor checks/approval are not transferable.Verified current-parent convergence
#817 is current at exact
aa47c96e15084d0b944558b980edef34133f8040. Run34053512204, job101541202170, completed GREEN on exact prior #818 plus exact #817. It admitted onlyfrontend/src/leftoverMapPlotLayout.test.ts, passed rank-boundary, frozen Python, ADR0287/package-version, layout/small-canvas/Vietnamese/coverage/i18n/LeftoverMapPlot/LeftoverPairList and oxlint contracts, and produced workflow-free tree7d6ac8291e79f42f54de67a01c3bb0460741b6a8. That tree was recreated as productde3a61988768bcfddcab1dec3dfe3c60f9a89743with first parent prior #818 and second parent exact #817, then advanced withforce=false.Isolated convergence GREEN proves the current-parent tree only; it does not transfer hosted exact-product-head checks or approval.
Descendant boundary
#819 has now converged non-force onto this exact #818 and is current at
f37ca315e3c48fa37bbcafe96e46c5d7dab991b7. #820 is the earliest stale descendant. Its exact-current-parent reconstruction run34054337875preserves the singular-value v2.46 delta while repairing the two observed current-parent conflicts and ADR/release state. #821 remains dependent and must receive a distinct ADR/release identity after #820 converges. Do not replay historical convergence wholesale or transfer predecessor evidence.Keep Draft. Fresh exact-product-head required checks, applicable Storybook/browser/a11y evidence, authenticated acceptance where applicable, and qualifying independent approval remain required. No self-approval, protection bypass, force-push, destructive rebase, or invented measurement values.
Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.