feat(reports): leftover-map complete-case coverage on graphic display (v2.38.0) - #812
Conversation
Caption the leftover-map graphic display with persisted leftover-map complete-case coverage (ADR 0281). After make seed, closest and farthest leftover pairs sit above the member list with a plot caption that matches leftover-map complete-case coverage above the pair list; click a post marker or a pair button opens that post. A missing, non-integer, negative-used, non-positive-scored, or used-greater-than-scored coverage omits that leftover-map coverage caption. Coverage 0 of M is shown when that persisted used count is a non-negative integer. Do not invent coverage from plotted marker count, leftover-map distance, leftover-map rank, or the count of unused axes. Never invent a leftover score or a theta. UI-only; no new columns.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Stacked onto leftover-map rank (#811 @ Copilot/Devin review is not independent APPROVE. Only collaborator is seonghobae; no independent reviewer can be requested from this token. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Stacked successor is #813 ( Leave #812 and #813 open. Independent APPROVE required on the leftover stack. Do not self-approve. Do not squash-merge onto the leftover base. After independent review, retarget onto leftover-coordinates (#782) rather than squash-merging here. |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Fresh parent-chain read found a valid inherited release-provenance defect before this successor can remain Ready. This v2.38 branch declares 2.38.0 in both Python package metadata and the frontend, but runtime lineageweave.__version__ is still 2.20.0, and the parent release-identity contract test is absent. Because reconstruction provenance persists this runtime value, this is not documentation drift. The PR has been returned to Draft. Preserve the ADR 0281 coverage delta, add the parent synchronization contract as RED, then align runtime provenance to v2.38.0. No predecessor GREEN/approval transfers; the parent #811 itself is currently Draft/RED and must remain the delivery prerequisite.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Fresh exact-parent convergence produced an additional expected conflict in lineageweave/__init__.py, not only the two shared i18n files. This is a real successor-release identity boundary: #811 is v2.37.0 while #812 intentionally owns v2.38.0 and already carries tests/test_package_version.py plus the causal runtime-version repair. Treating the third conflict as unexpected correctly failed closed, but the convergence lane must preserve #812's v2.38.0 runtime identity while adopting #811's repaired Vietnamese terminology. The isolated workflow has been causally repaired on staging head 79f577b7acfe57bf2f6c34e39160b9a933ff5a2e to admit exactly those three conflicts, keep the child's lineageweave/__init__.py, assert pyproject/frontend/runtime are all exactly 2.38.0, and continue to remove the temporary workflow before any clean merge-tree commit. No product GREEN or ancestry convergence is claimed until that rerun succeeds and the clean tree is re-created as a non-force two-parent product commit.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head convergence finding: frontend/src/leftoverMapPlotVietnameseCopy.test.ts hard-codes the pre-v2.38 graphic caption key from #811, while #812 intentionally extends LEFTOVER_MAP_PLOT_CAPTION with persisted complete-case coverage. After resolving #811/#812 i18n conflicts in favor of the v2.38 successor dictionary and applying the corrected Vietnamese explained-share wording, the inherited test still queries that dead pre-coverage key and falls back to English. This is not a reason to re-add a stale translation alias. Repair the regression to consume the production LEFTOVER_MAP_PLOT_CAPTION constant, retain #812's coverage caption and v2.38 release identity, and require the existing Vietnamese test plus i18n/coverage/plot suites to pass on the converged two-parent tree.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Fresh parent sweep found #811 advanced non-force from e0fad9af... to 4dcd789385f67c76a4e479194f566f35bb5d2d76 with a rank-caption boundary regression in frontend/src/leftoverMapPlotLayout.test.ts. #812 is now based on that branch tip but its product ancestry still converges only the previous #811 head, so it is structurally stale even though the new parent delta is test-only. Repair by reconstructing #812 on exact current #811, preserving the v2.38 product tree and inheriting the new rank boundary contract; do not rewrite or drop the parent test to regain mergeability. Descendant #813 must not inherit the old #812 snapshot after this parent move.
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Current parent convergence
Authoritative parent #811 is
4dcd789385f67c76a4e479194f566f35bb5d2d76. Run34036103266completed GREEN and workflow-free tree8d7bcdc82cd35d1a5d823fbd8bcfd9ada711eab1was recreated as current productdf419c5a2f75782fa883915806d8cada7a78ff78with first parent prior #812 and second parent exact #811, advanced by non-force fast-forward. The only inherited delta wasfrontend/src/leftoverMapPlotLayout.test.ts; v2.38 package/frontend/runtime identity remains synchronized. Isolated convergence GREEN is not transferable hosted exact-head GREEN or approval.Descendant authority
#813 is current at
44ace39111664a9b39a81e575a8dbdf06506050f, #814 atbd90a974b72c649c423a7b99ee47dae1d8236b0e, #815 atc02dffc264f70283ff7ff2d07bfe83a47bd13e10, #816 at4d81c881469496fedeb8d9bb98cd485209df2089, #817 ataa47c96e15084d0b944558b980edef34133f8040, #818 atde3a61988768bcfddcab1dec3dfe3c60f9a89743, and #819 atf37ca315e3c48fa37bbcafe96e46c5d7dab991b7, all through verified non-force current-parent convergence. #820 is the earliest stale descendant; run34054337875reconstructs its valid singular-value v2.46 delta from exact #819 while repairing current-parent conflicts and ADR/release state. #821 remains dependent under a distinct future ADR/release identity.Verification boundary
df419c5a2f75782fa883915806d8cada7a78ff784dcd789385f67c76a4e479194f566f35bb5d2d7634036103266: GREEN and clean tree promotedJeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.
Keep Draft until fresh exact-head required checks, applicable rendered browser/a11y evidence, and qualifying independent approval are complete. No force-push, self-approval, protection bypass, predecessor-evidence transfer, or invented measurement values.