feat(reports): leftover residual on grouping comparison graphic (v2.72.0) - #855
Conversation
…2.0) Name leftover residual R on grouping comparison leftover-map pair segments (ADR 0315). After make seed, closest and farthest leftover pairs sit above the member list with leftover residual R next to leftover-map unexplained leftover U on that comparison graphic; click opens that post. Rank-0 unused axes still name R 0.00 when that persisted leftover residual is finite. A missing or non-finite R omits that leftover-map comparison graphic residual caption and keeps leftover-map unexplained leftover U. Never invent a leftover score. Never invent a theta.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Cycle 2026-08-31 08:35 KST: exact head |
|
Stacking leftover observed |
Keep leftover map comparison graphic leftover residual {label} distinct
from leftover residual {label} on the period-report graphic and from
strip Leftover map comparison residual (ADR 0315). Vietnamese copy
names the leftover map. Do not invent R. Never invent a leftover score.
Never invent a theta. No new columns.
|
Exact head now |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head governance finding: this Draft PR introduces ADR 0315 as Decision status: Accepted. That is the same premature authority defect now being repaired downstream in #856/#857. Preserve the residual-caption product delta and keep ADR 0315, but its decision state must remain Proposed until qualifying independent acceptance/normal merge. Because the shared source foundation is still #841's exact-head RED/repair lane, do not churn descendants or promote downstream governance staging ahead of that foundation; this finding must be carried when the chain is reconstructed non-force. No close, force-push, self-approval, or gate weakening.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head governance finding: this PR is Draft, but docs/adr/0315-leftover-map-compare-plot-residual.md declares **Decision status:** Accepted. The product/ADR delta is valid and should remain open, but acceptance is premature until the unchanged release-ready head has qualifying independent approval and required exact-head evidence. Add an executable governance regression requiring ADR 0315 to remain Proposed, then minimally change only the decision status; preserve the residual semantics, v2.72.0 identity, and descendant stack. Do not close, force-push, self-approve, or transfer predecessor approval.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
RCA for ADR0315 repair run 34012808279: the temporary lane changed the ADR marker to Proposed, then failed before executing the governing test because the harness invoked python -m pytest without installing the repository's locked dev dependencies (No module named pytest). This is a harness failure, not evidence that the ADR repair is product-red. Separately, #855 remains downstream of the stale #840→…→#854 chain, so even a corrected harness result must not be promoted until that parent stack is reconstructed. Re-run the governance test with the normal frozen uv dev environment on the reconstructed exact head.
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Ron the grouping-comparison leftover-map graphic (ADR 0315 / v2.72.0).Romits only this caption; finite negative and zero values remain visible; do not deriveRfrom Y/E/U/R̂, coordinates, rank, coverage, pair counts, or unused-axis counts.Live stack authority
feat/leftover-map-compare-plot-unexplained-leftover-v2710@eb4ffef04677d6e1d67fe1325cfdf1bbb2db2245e8f0ca2c10584fad578c4cd7e6493025bd565020f37ca315e3c48fa37bbcafe96e46c5d7dab991b734054337875reconstructs its valid v2.46 singular-value delta from exact feat(reports): fail-close leftover-map pair-list post coverage (v2.45.0) #819 and begins the remaining ordered ancestry/identity repairGovernance RED
Review
5124205805verified that ADR0315 declaresAcceptedeven though this candidate remains Draft and lacks qualifying unchanged-head independent acceptance. Executable REDtests/test_adr_0315_governance.pyone8f0ca2c10584fad578c4cd7e6493025bd565020requiresProposedand rejectsAcceptedwhile unmerged.Diagnostic repair result
Runs
34012808279,34015233049, and34017543725exposed harness-only defects. Follow-up34020213858completed GREEN and produced workflow-free clean commit1be492a003bd4ad7f5c51dbcb7a2b664a362937d, tree003b86e3e54499c41638324d07a494dc3999d434. The isolated evidence confirms the causal ADR0315Accepted → Proposedrepair and governing test are sound.This GREEN remains diagnostic only and must not be promoted ahead of repaired ancestry. Continue #820→#854 in order, preserving valid product/governance/release deltas and repairing duplicate identities, then rebuild this residual delta plus ADR0315
Proposedfrom exact reconstructed #854 and regenerate exact-head evidence before #856.Keep Draft. Do not transfer predecessor checks/approval, force-push, destructively rebase, self-approve, weaken gates, bypass parents, or treat harness failures as product failures. Exact-product-head frontend/full-suite CI, browser/a11y evidence, independent approval, and release evidence remain unclaimed.