-
Notifications
You must be signed in to change notification settings - Fork 0
feat(templates): add CLI project template #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: graphite-base/92
Are you sure you want to change the base?
Conversation
3795598 to
aacdccc
Compare
a0e1203 to
f08e961
Compare
f08e961 to
b561c5a
Compare
aacdccc to
4eb91cd
Compare
Greptile Summary
|
| Filename | Overview |
|---|---|
| templates/cli/tsconfig.json.template | TypeScript config template with conflicting noEmit and declaration options; missing project strictness settings |
| templates/cli/src/program.ts.template | CLI program template using dual logging approach (structured + console) which creates redundant output |
Confidence score: 3/5
- This PR has some configuration issues that should be addressed before merging to ensure proper functionality
- Score reflects conflicting TypeScript compiler options (noEmit with declaration generation) and missing strictness settings that don't align with the monorepo's base configuration standards
- Pay close attention to
templates/cli/tsconfig.json.templatefor compiler option conflicts andtemplates/cli/src/program.ts.templatefor the dual logging approach
Sequence Diagram
sequenceDiagram
participant User
participant CLI as "CLI Entry Point"
participant Program as "CLI Program"
participant Command as "Command Builder"
participant Logger as "Logger"
participant Console as "Console"
User->>CLI: "Execute binary (e.g., hello World)"
CLI->>Program: "createCLI(config)"
Program->>Program: "new Command()"
Program->>CLI: "return CLI instance"
CLI->>Program: "register(command)"
Command->>Command: "command('hello [name]')"
Command->>Command: "description('Say hello')"
Command->>Command: "action(handler)"
Program->>Program: "addCommand(built command)"
CLI->>Program: "parse(process.argv)"
Program->>Program: "parseAsync(argv)"
Program->>Command: "execute action handler"
Command->>Logger: "logger.info`Hello, ${name}!`"
Command->>Console: "console.log(`Hello, ${name}!`)"
Console->>User: "Hello, World!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 files reviewed, 3 comments
b561c5a to
590e6df
Compare
4eb91cd to
dae8a2d
Compare
|
Addressed greptile notes: aligned CLI tsconfig with the basic template (schema, lib/types, stricter options; removed conflicting noEmit) and removed the extra console.log in program template to avoid duplicate output. Restacked and resubmitted. |
dae8a2d to
f419d98
Compare
f419d98 to
cd95af5
Compare
|
templates/cli/tsconfig.json.template now includes exactOptionalPropertyTypes and noPropertyAccessFromIndexSignature; console/log duplication has already been removed from the CLI program template. |
Merge activity
|

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com