feat(daemon): add errors, platform, and locking module stubs #87

galligan · 2026-01-23T15:31:58Z

Summary

Adds foundation module stubs for the daemon package:

errors.ts - DaemonError taxonomy (ALREADY_RUNNING, NOT_RUNNING, PID_ERROR, etc.)
platform.ts - Platform detection and path utilities
locking.ts - PID-based daemon locking with stale lock detection

Test plan

Stubs compile without errors
Types are exported correctly
Foundation for TDD RED phase (tests branch)

🤖 Generated with Claude Code

Contributes to #56

galligan · 2026-01-23T15:32:38Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps · 2026-01-23T21:08:19Z

Greptile Summary

Scaffolds foundation modules for the daemon package including error taxonomy, platform detection utilities, and PID-based locking mechanisms
Establishes public API surface through comprehensive exports in packages/daemon/src/index.ts with organized section headers and clear documentation
Creates cross-platform abstractions for daemon file paths with XDG compliance and support for both Unix domain sockets and Windows named pipes

Important Files Changed

Filename	Overview
packages/daemon/src/locking.ts	New PID-based locking implementation with critical bugs in process liveness detection and lock file cleanup
packages/daemon/src/errors.ts	New comprehensive error taxonomy using TaggedError pattern for daemon operations
packages/daemon/src/platform.ts	New cross-platform path utilities with XDG compliance for daemon file locations

Confidence score: 2/5

This PR has significant implementation issues that could cause daemon malfunction in production
Score lowered due to incorrect process liveness detection logic treating permission errors as "process doesn't exist" and improper lock cleanup that clears files instead of unlinking them
Pay close attention to packages/daemon/src/locking.ts which needs fixes for isProcessAlive exception handling and releaseDaemonLock file cleanup logic

Sequence Diagram

sequenceDiagram
    participant User
    participant Platform as "Platform Module"
    participant Locking as "Locking Module" 
    participant FileSystem as "File System"
    participant Process as "Process"

    User->>Platform: "getDaemonDir(toolName)"
    Platform->>Platform: "getRuntimeDir()"
    Platform-->>User: "daemonDir"

    User->>Platform: "getLockPath(toolName)"
    Platform-->>User: "lockPath"

    User->>Locking: "acquireDaemonLock(lockPath)"
    Locking->>FileSystem: "check if lock file exists"
    FileSystem-->>Locking: "file status"

    alt Lock file exists
        Locking->>FileSystem: "read PID from lock file"
        FileSystem-->>Locking: "existingPid"
        Locking->>Process: "isProcessAlive(existingPid)"
        Process-->>Locking: "process status"
        
        alt Process is alive
            Locking-->>User: "LockError (daemon already running)"
        else Process is dead
            Locking->>FileSystem: "write current PID to lock file"
            FileSystem-->>Locking: "write success"
            Locking-->>User: "LockHandle"
        end
    else Lock file doesn't exist
        Locking->>FileSystem: "write current PID to lock file"
        FileSystem-->>Locking: "write success"
        Locking-->>User: "LockHandle"
    end

    User->>User: "run daemon operations"

    User->>Locking: "releaseDaemonLock(handle)"
    Locking->>FileSystem: "verify PID matches in lock file"
    FileSystem-->>Locking: "PID verification"
    Locking->>FileSystem: "clear lock file"
    FileSystem-->>Locking: "clear success"
    Locking-->>User: "lock released"

greptile-apps

_{4 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-01-23T21:08:17Z

packages/daemon/src/locking.ts

+	} catch {
+		// ESRCH = no such process, EPERM = exists but no permission
+		// Both mean process exists or doesn't - EPERM means it exists
+		return false;
+	}


logic: Logic error: EPERM means process exists but no permission to signal it, so should return true, not false

Suggested change

} catch {

// ESRCH = no such process, EPERM = exists but no permission

// Both mean process exists or doesn't - EPERM means it exists

return false;

}

} catch (error) {

// ESRCH = no such process, EPERM = exists but no permission

// EPERM means process exists but we lack permission - still alive

if (error instanceof Error && 'code' in error && error.code === 'EPERM') {

return true;

}

return false;

}

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/daemon/src/locking.ts Line: 57:61 Comment: **logic:** Logic error: EPERM means process exists but no permission to signal it, so should return true, not false ```suggestion } catch (error) { // ESRCH = no such process, EPERM = exists but no permission // EPERM means process exists but we lack permission - still alive if (error instanceof Error && 'code' in error && error.code === 'EPERM') { return true; } return false; } ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-01-23T21:08:17Z

packages/daemon/src/locking.ts

+			await Bun.write(lockPath, ""); // Clear file
+			// Note: Proper implementation would use unlink
+			// For now, clearing is a stub behavior


logic: Critical issue: clearing file content doesn't release lock properly - other processes will see empty file as invalid PID and may acquire false locks

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/daemon/src/locking.ts Line: 214:216 Comment: **logic:** Critical issue: clearing file content doesn't release lock properly - other processes will see empty file as invalid PID and may acquire false locks How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-01-23T21:08:18Z

packages/daemon/src/platform.ts

+/**
+ * Get the directory containing daemon files for a tool.
+ *
+ * Creates the directory if it doesn't exist (on Unix platforms).


logic: Comment states 'Creates the directory if it doesn't exist' but the function doesn't actually create directories. Either remove this claim from the comment or implement directory creation.

Suggested change

* Creates the directory if it doesn't exist (on Unix platforms).

* Get the directory containing daemon files for a tool.

*

* @param toolName - Name of the tool (e.g., "waymark", "firewatch")

* @returns Absolute path to the daemon directory

Should this function actually create the directory, or should the comment be corrected to reflect that it only returns the path?

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/daemon/src/platform.ts Line: 143:143 Comment: **logic:** Comment states 'Creates the directory if it doesn't exist' but the function doesn't actually create directories. Either remove this claim from the comment or implement directory creation. ```suggestion * Get the directory containing daemon files for a tool. * * @param toolName - Name of the tool (e.g., "waymark", "firewatch") * @returns Absolute path to the daemon directory ``` Should this function actually create the directory, or should the comment be corrected to reflect that it only returns the path? How can I resolve this? If you propose a fix, please make it concise.

galligan · 2026-01-23T22:10:58Z

Restacked this branch with the updated downstack; re-submitted after tests. No additional code changes beyond the rebase.

galligan · 2026-01-23T23:01:01Z

Addressed review items: isProcessAlive now treats EPERM as alive, releaseDaemonLock unlinks the lock file, and clarified getDaemonDir docs (keeps no side effects).

galligan · 2026-01-23T23:10:54Z

Restacked after downstack update (formatRelative test stabilization); no additional changes in this PR.

galligan · 2026-01-24T03:17:14Z

Greptile notes checked: EPERM now treated as alive, lock release unlinks instead of clearing, and daemon dir docstring reflects behavior. Restacked and resubmitted.

This was referenced Jan 23, 2026

chore(outfitter): sync templates on pack #108

Open

chore(changesets): ignore app package #107

Open

fix(errors): avoid TaggedError extends warnings #106

Open

galligan force-pushed the p3-24/outfitter/doctor-cmd branch from a0a54d6 to e067804 Compare January 23, 2026 19:46

galligan force-pushed the p5/daemon/scaffold branch from 6150ed0 to 6a060dd Compare January 23, 2026 19:46

This was referenced Jan 23, 2026

fix(cli): enforce cursor TTL #114

Open

fix(tests): remove placeholder tests #113

Open

greptile-apps bot reviewed Jan 23, 2026

View reviewed changes

galligan mentioned this pull request Jan 23, 2026

chore(gitattributes): prefer ours for bun lockfiles #115

Open

galligan changed the base branch from p3-24/outfitter/doctor-cmd to graphite-base/87 January 23, 2026 22:09

galligan force-pushed the p5/daemon/scaffold branch from 6a060dd to 43ba5e1 Compare January 23, 2026 22:10

galligan force-pushed the graphite-base/87 branch from e067804 to 16edd51 Compare January 23, 2026 22:10

galligan changed the base branch from graphite-base/87 to p3-24/outfitter/doctor-cmd January 23, 2026 22:10

galligan changed the base branch from p3-24/outfitter/doctor-cmd to graphite-base/87 January 23, 2026 22:57

galligan force-pushed the p5/daemon/scaffold branch from 43ba5e1 to ec39151 Compare January 23, 2026 23:00

galligan changed the base branch from graphite-base/87 to p3-24/outfitter/doctor-cmd January 23, 2026 23:00

galligan force-pushed the p5/daemon/scaffold branch from ec39151 to 8c0c488 Compare January 23, 2026 23:09

galligan force-pushed the p3-24/outfitter/doctor-cmd branch from 8d26b54 to aed02b9 Compare January 23, 2026 23:09

galligan added 3 commits January 23, 2026 22:13

feat(daemon): add errors, platform, and locking module stubs

735de87

fix(daemon): harden lock handling

72fbfb2

fix(daemon): harden lock handling

e3558b0

galligan changed the base branch from p3-24/outfitter/doctor-cmd to graphite-base/87 January 24, 2026 03:15

galligan force-pushed the p5/daemon/scaffold branch from 8c0c488 to e3558b0 Compare January 24, 2026 03:17

galligan force-pushed the graphite-base/87 branch from aed02b9 to d0959a5 Compare January 24, 2026 03:17

galligan changed the base branch from graphite-base/87 to p3-24/outfitter/doctor-cmd January 24, 2026 03:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(daemon): add errors, platform, and locking module stubs #87

feat(daemon): add errors, platform, and locking module stubs #87

galligan commented Jan 23, 2026 •

edited

Loading

Uh oh!

galligan commented Jan 23, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Jan 23, 2026

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Jan 23, 2026

Uh oh!

greptile-apps bot Jan 23, 2026

Uh oh!

greptile-apps bot Jan 23, 2026

Uh oh!

galligan commented Jan 23, 2026

Uh oh!

galligan commented Jan 23, 2026

Uh oh!

galligan commented Jan 23, 2026

Uh oh!

galligan commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(daemon): add errors, platform, and locking module stubs #87

Are you sure you want to change the base?

feat(daemon): add errors, platform, and locking module stubs #87

Conversation

galligan commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

galligan commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Jan 23, 2026

Greptile Summary

Important Files Changed

Confidence score: 2/5

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

galligan commented Jan 23, 2026

Uh oh!

galligan commented Jan 23, 2026

Uh oh!

galligan commented Jan 23, 2026

Uh oh!

galligan commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

galligan commented Jan 23, 2026 •

edited

Loading

galligan commented Jan 23, 2026 •

edited

Loading