fix(cli): enforce cursor TTL

[galligan]

Summary

• Enforce cursor TTL via maxAgeMs in pagination helpers.
• Add/adjust tests for expiration behavior.
• Document the new option in the CLI README.

Changes

• packages/cli/src/types.ts
• packages/cli/src/pagination.ts
• packages/cli/src/tests/pagination.test.ts
• packages/cli/README.md

Testing

• Not run (not requested).

[galligan]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(outfitter): sync templates on pack #108
• chore(changesets): ignore app package #107
• fix(errors): avoid TaggedError extends warnings #106
• chore(release): align package versions to 0.1.0 #105
• docs: add README and CHANGELOG for testing, kit, outfitter #95
• feat(templates): add daemon project template #94
• feat(templates): add MCP server project template #93
• feat(templates): add CLI project template #92
• fix(cli): implement confirmDestructive prompts #104
• fix(cli): implement createCLI and command builder #103
• feat(kit): add @outfitter/kit meta-package #91
• docs(daemon): add README and CHANGELOG #90
• fix(daemon): fix locking module bugs (GREEN phase) #89
• test(daemon): add locking module tests (RED phase) #88
• feat(daemon): add errors, platform, and locking module stubs #87
• feat(outfitter): add doctor command for environment validation #86
• feat(outfitter): add init command with project scaffolding #85
• feat(daemon): add IPC communication and health checks #84
• feat(daemon): add types and lifecycle management #83
• feat(index): add FTS5 full-text search implementation #82
• feat(index): add types for FTS5 full-text search #81
• feat(testing): add MCP and CLI test harnesses #80
• feat(testing): add test fixture utilities #79
• feat(mcp): add MCP server implementation with typed handlers #78
• feat(mcp): add types and interfaces for MCP server #77
• feat(ui): add Shape discriminated union and render() #76
• feat(ui): add createTokens semantic color layer #75
• feat(state): add pagination helpers #74
• feat(logging): add DEFAULT_PATTERNS for common secret redaction #73
• feat(ui): add formatRelative() for human-readable timestamps #72
• feat(state): add encodeCursor/decodeCursor for pagination #71
• feat(types): add hashId() for deterministic short identifiers #70
• feat(contracts): add Logger.child() and fix AssertionError category #69
• feat(config): centralize environment variable access with Zod validation #42
• fix(logging): enable redaction by default when global rules exist #41
• docs(ui): add README, CHANGELOG, and TSDoc comments #39
• docs(state): add README, CHANGELOG, and TSDoc comments #38
• docs(file-ops): add README, CHANGELOG, and TSDoc comments #37
• docs(logging): add README, CHANGELOG, and TSDoc comments #36
• docs(config): add README, CHANGELOG, and TSDoc comments #35
• fix(cli): enforce cursor TTL #114 👈 (View in Graphite)
• fix(tests): remove placeholder tests #113
• chore(gitattributes): prefer ours for bun lockfiles #115
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[greptile-apps]

Greptile Summary

• Implements cursor TTL (time-to-live) enforcement in the CLI pagination system by adding maxAgeMs option to prevent stale cursors from being used
• Updates the loadPaginationState function to validate cursor age and return undefined for expired cursors, maintaining backward compatibility
• Enables previously skipped TTL tests and adds new test coverage to verify both expired cursor rejection and fresh cursor acceptance

Important Files Changed

Filename	Overview
packages/cli/src/pagination.ts	Core TTL enforcement logic that checks cursor timestamps against maxAgeMs and returns undefined for expired cursors
packages/cli/src/tests/pagination.test.ts	Removes skipped test placeholders and adds comprehensive TTL validation testing for both expired and fresh cursors

Confidence score: 4/5

• This PR is generally safe to merge with minor considerations around edge case handling
• Score reflects solid implementation but deducted one point due to potential edge cases around timestamp handling and lack of validation for maxAgeMs parameter bounds
• Pay close attention to packages/cli/src/pagination.ts for the TTL validation logic and ensure the timestamp comparison is robust

Sequence Diagram

sequenceDiagram
    participant User
    participant CLI
    participant "loadCursor"
    participant FileSystem
    participant "saveCursor"
    participant API
    
    User->>CLI: "command --next"
    CLI->>loadCursor: "Load pagination state"
    loadCursor->>FileSystem: "Check if cursor.json exists"
    FileSystem-->>loadCursor: "File exists"
    loadCursor->>FileSystem: "Read cursor.json content"
    FileSystem-->>loadCursor: "JSON content"
    loadCursor->>loadCursor: "Validate structure & TTL"
    loadCursor-->>CLI: "PaginationState"
    CLI->>API: "Query with cursor"
    API-->>CLI: "Results with new cursor"
    CLI->>saveCursor: "Save new cursor state"
    saveCursor->>FileSystem: "Create directories if needed"
    saveCursor->>FileSystem: "Write new cursor.json"
    CLI->>User: "Output results"

Loading

[galligan]

Checked for new feedback; no changes needed. Stack still up to date.