feat(contracts): add Logger.child() and fix AssertionError category

[galligan]

• Add child(context) method to Logger interface for context inheritance
• Update noopLogger to include child() method
• Change AssertionError category from 'validation' to 'internal'
• Add TSDoc explaining category rationale (invariant violations, not user input)
• Add 8 new tests for Logger.child and AssertionError behavior

Closes #53, #54

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

[galligan]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(outfitter): sync templates on pack #108
• chore(changesets): ignore app package #107
• fix(errors): avoid TaggedError extends warnings #106
• chore(release): align package versions to 0.1.0 #105
• docs: add README and CHANGELOG for testing, kit, outfitter #95
• feat(templates): add daemon project template #94
• feat(templates): add MCP server project template #93
• feat(templates): add CLI project template #92
• fix(cli): implement confirmDestructive prompts #104
• fix(cli): implement createCLI and command builder #103
• feat(kit): add @outfitter/kit meta-package #91
• docs(daemon): add README and CHANGELOG #90
• fix(daemon): fix locking module bugs (GREEN phase) #89
• test(daemon): add locking module tests (RED phase) #88
• feat(daemon): add errors, platform, and locking module stubs #87
• feat(outfitter): add doctor command for environment validation #86
• feat(outfitter): add init command with project scaffolding #85
• feat(daemon): add IPC communication and health checks #84
• feat(daemon): add types and lifecycle management #83
• feat(index): add FTS5 full-text search implementation #82
• feat(index): add types for FTS5 full-text search #81
• feat(testing): add MCP and CLI test harnesses #80
• feat(testing): add test fixture utilities #79
• feat(mcp): add MCP server implementation with typed handlers #78
• feat(mcp): add types and interfaces for MCP server #77
• feat(ui): add Shape discriminated union and render() #76
• feat(ui): add createTokens semantic color layer #75
• feat(state): add pagination helpers #74
• feat(logging): add DEFAULT_PATTERNS for common secret redaction #73
• feat(ui): add formatRelative() for human-readable timestamps #72
• feat(state): add encodeCursor/decodeCursor for pagination #71
• feat(types): add hashId() for deterministic short identifiers #70
• feat(contracts): add Logger.child() and fix AssertionError category #69 👈 (View in Graphite)
• feat(config): centralize environment variable access with Zod validation #42
• fix(logging): enable redaction by default when global rules exist #41
• docs(ui): add README, CHANGELOG, and TSDoc comments #39
• docs(state): add README, CHANGELOG, and TSDoc comments #38
• docs(file-ops): add README, CHANGELOG, and TSDoc comments #37
• docs(logging): add README, CHANGELOG, and TSDoc comments #36
• docs(config): add README, CHANGELOG, and TSDoc comments #35
• fix(cli): enforce cursor TTL #114
• fix(tests): remove placeholder tests #113
• chore(gitattributes): prefer ours for bun lockfiles #115
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62826b82f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[greptile-apps]

Greptile Summary

• Adds Logger.child(context) method to the Logger interface in packages/contracts/src/handler.ts for creating child loggers with inherited context, enabling hierarchical logging patterns required by the project specification
• Updates AssertionError category from 'validation' to 'internal' in packages/contracts/src/errors.ts to correctly reflect that assertion failures are programming bugs rather than user input validation issues
• Adds comprehensive test coverage with 8 new tests across multiple test files to verify both the Logger.child functionality and corrected AssertionError behavior

Important Files Changed

Filename	Overview
packages/contracts/src/handler.ts	Adds child(context) method to Logger interface with comprehensive TSDoc explaining context merging and composability
packages/contracts/src/errors.ts	Changes AssertionError category from 'validation' to 'internal' with detailed rationale for invariant violation handling

Confidence score: 5/5

• This PR is safe to merge with minimal risk as it primarily adds new functionality and corrects error categorization
• Score reflects well-documented changes with comprehensive test coverage and clear adherence to project architecture patterns
• No files require special attention as the changes are straightforward interface additions and error category corrections

Sequence Diagram

sequenceDiagram
    participant User
    participant Logger
    participant ChildLogger
    participant AssertionHandler
    participant ErrorSystem

    User->>Logger: "child({ requestId: 'abc123' })"
    Logger->>ChildLogger: "create with inherited context"
    Logger-->>User: "return ChildLogger"
    
    User->>ChildLogger: "info('Processing request')"
    ChildLogger->>ChildLogger: "merge parent + child context"
    ChildLogger->>ChildLogger: "log with full context"

    User->>ChildLogger: "child({ operation: 'create' })"
    ChildLogger->>ChildLogger: "create nested child"
    ChildLogger-->>User: "return nested ChildLogger"

    User->>AssertionHandler: "invariant violation detected"
    AssertionHandler->>ErrorSystem: "new AssertionError({ message: 'Invariant violated' })"
    ErrorSystem->>ErrorSystem: "set category = 'internal'"
    ErrorSystem->>ErrorSystem: "map to HTTP 500/exit code 8"
    ErrorSystem-->>User: "return AssertionError"

Loading

[galligan]

Aligned contracts Logger interface with logging by adding trace/fatal and updating no-op/test loggers to match.

[galligan]

Resubmitted after restack. Logger.child compatibility is handled upstack in PR #73 (logging adds child to LoggerInstance), so no additional changes were needed in this contracts PR.

[galligan]

Resubmitted after downstack updates; no new feedback found on this PR.