fix(logging): enable redaction by default when global rules exist

[galligan]

Summary

When configureRedaction() is called with patterns or keys, redaction now applies automatically to all loggers — no need to explicitly pass redaction: { enabled: true } to createLogger().

Problem

Previously, redaction was gated on redactionConfig?.enabled:

configureRedaction({ keys: ["apiKey"] });

// This did NOT redact, despite global rules existing
const logger = createLogger({ name: "app" });
logger.info("Data", { apiKey: "secret" }); // "secret" leaked!

Solution

Check if global rules exist before skipping redaction:

const hasGlobalRules =
  (globalRedactionConfig.patterns?.length ?? 0) > 0 ||
  (globalRedactionConfig.keys?.length ?? 0) > 0;

if ((redactionConfig && redactionConfig.enabled !== false) || hasGlobalRules) {
  // Apply redaction
}

Now the same code works as expected:

configureRedaction({ keys: ["apiKey"] });

const logger = createLogger({ name: "app" });
logger.info("Data", { apiKey: "secret" }); // "[REDACTED]" ✓

Test plan

• Added test: "global redaction patterns apply without explicit enabled flag"
• All 42 logging tests pass
• Typecheck passes

Fixes #40

🤖 Generated with Claude Code

[galligan]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(outfitter): sync templates on pack #108
• chore(changesets): ignore app package #107
• fix(errors): avoid TaggedError extends warnings #106
• chore(release): align package versions to 0.1.0 #105
• docs: add README and CHANGELOG for testing, kit, outfitter #95
• feat(templates): add daemon project template #94
• feat(templates): add MCP server project template #93
• feat(templates): add CLI project template #92
• fix(cli): implement confirmDestructive prompts #104
• fix(cli): implement createCLI and command builder #103
• feat(kit): add @outfitter/kit meta-package #91
• docs(daemon): add README and CHANGELOG #90
• fix(daemon): fix locking module bugs (GREEN phase) #89
• test(daemon): add locking module tests (RED phase) #88
• feat(daemon): add errors, platform, and locking module stubs #87
• feat(outfitter): add doctor command for environment validation #86
• feat(outfitter): add init command with project scaffolding #85
• feat(daemon): add IPC communication and health checks #84
• feat(daemon): add types and lifecycle management #83
• feat(index): add FTS5 full-text search implementation #82
• feat(index): add types for FTS5 full-text search #81
• feat(testing): add MCP and CLI test harnesses #80
• feat(testing): add test fixture utilities #79
• feat(mcp): add MCP server implementation with typed handlers #78
• feat(mcp): add types and interfaces for MCP server #77
• feat(ui): add Shape discriminated union and render() #76
• feat(ui): add createTokens semantic color layer #75
• feat(state): add pagination helpers #74
• feat(logging): add DEFAULT_PATTERNS for common secret redaction #73
• feat(ui): add formatRelative() for human-readable timestamps #72
• feat(state): add encodeCursor/decodeCursor for pagination #71
• feat(types): add hashId() for deterministic short identifiers #70
• feat(contracts): add Logger.child() and fix AssertionError category #69
• feat(config): centralize environment variable access with Zod validation #42
• fix(logging): enable redaction by default when global rules exist #41 👈 (View in Graphite)
• docs(ui): add README, CHANGELOG, and TSDoc comments #39
• docs(state): add README, CHANGELOG, and TSDoc comments #38
• docs(file-ops): add README, CHANGELOG, and TSDoc comments #37
• docs(logging): add README, CHANGELOG, and TSDoc comments #36
• docs(config): add README, CHANGELOG, and TSDoc comments #35
• fix(cli): enforce cursor TTL #114
• fix(tests): remove placeholder tests #113
• chore(gitattributes): prefer ours for bun lockfiles #115
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce38317fcb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[greptile-apps]

Greptile Summary

• Fixes critical security issue where global redaction rules weren't automatically applied to loggers, potentially leaking sensitive data when redaction: { enabled: true } was omitted
• Updates packages/logging/src/index.ts to automatically enable redaction when global patterns or keys exist via configureRedaction()
• Adds comprehensive test coverage for automatic redaction behavior and explicit opt-out scenarios

Important Files Changed

Filename	Overview
packages/logging/src/index.ts	Modified redaction logic to automatically apply global rules without requiring explicit enabled: true flag
packages/logging/src/__tests__/logging.test.ts	Added test cases validating automatic redaction and explicit opt-out behaviors

Confidence score: 4/5

• This PR is safe to merge with minimal risk as it fixes a security vulnerability and improves user experience
• Score reflects strong implementation with proper edge case handling and comprehensive test coverage, but slight complexity in the redaction logic could benefit from additional review
• Pay close attention to the redaction logic in packages/logging/src/index.ts to verify the conditional checks are correct

Sequence Diagram

sequenceDiagram
    participant User
    participant Logger as "LoggerInstance"
    participant ProcessMeta as "processMetadata()"
    participant RedactionCheck as "redactValue()"
    participant Sink
    participant Formatter

    User->>Logger: "logger.info(message, metadata)"
    Logger->>Logger: "shouldLog(level, minLevel)"
    Logger->>ProcessMeta: "processMetadata(metadata, redactionConfig)"
    ProcessMeta->>ProcessMeta: "Check explicit enabled: false"
    ProcessMeta->>ProcessMeta: "Check global patterns/keys exist"
    alt Global rules exist OR redaction enabled
        ProcessMeta->>RedactionCheck: "redactValue(metadata, keys, patterns)"
        RedactionCheck-->>ProcessMeta: "redacted metadata"
    end
    ProcessMeta-->>Logger: "processed metadata"
    Logger->>Logger: "Create LogRecord"
    loop For each sink
        Logger->>Formatter: "format(record)"
        Formatter-->>Logger: "formatted string"
        Logger->>Sink: "write(record, formatted)"
    end

Loading

[galligan]

Updated redaction tests to ensure enabled:false still opts out even when global rules are configured after logger creation.

[galligan]

Checked for new feedback; no changes needed. Stack still up to date.