fix(errors): avoid TaggedError extends warnings

[galligan]

Summary

• Refactor error types to avoid TaggedError extends warnings.
• Align error typing across config, contracts, daemon, and MCP.

Changes

• packages/contracts/src/errors.ts
• packages/config/src/index.ts
• packages/daemon/src/errors.ts
• packages/daemon/src/types.ts
• packages/mcp/src/types.ts

Testing

• Not run (not requested).

[galligan]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(outfitter): sync templates on pack #108
• chore(changesets): ignore app package #107
• fix(errors): avoid TaggedError extends warnings #106 👈 (View in Graphite)
• chore(release): align package versions to 0.1.0 #105
• docs: add README and CHANGELOG for testing, kit, outfitter #95
• feat(templates): add daemon project template #94
• feat(templates): add MCP server project template #93
• feat(templates): add CLI project template #92
• fix(cli): implement confirmDestructive prompts #104
• fix(cli): implement createCLI and command builder #103
• feat(kit): add @outfitter/kit meta-package #91
• docs(daemon): add README and CHANGELOG #90
• fix(daemon): fix locking module bugs (GREEN phase) #89
• test(daemon): add locking module tests (RED phase) #88
• feat(daemon): add errors, platform, and locking module stubs #87
• feat(outfitter): add doctor command for environment validation #86
• feat(outfitter): add init command with project scaffolding #85
• feat(daemon): add IPC communication and health checks #84
• feat(daemon): add types and lifecycle management #83
• feat(index): add FTS5 full-text search implementation #82
• feat(index): add types for FTS5 full-text search #81
• feat(testing): add MCP and CLI test harnesses #80
• feat(testing): add test fixture utilities #79
• feat(mcp): add MCP server implementation with typed handlers #78
• feat(mcp): add types and interfaces for MCP server #77
• feat(ui): add Shape discriminated union and render() #76
• feat(ui): add createTokens semantic color layer #75
• feat(state): add pagination helpers #74
• feat(logging): add DEFAULT_PATTERNS for common secret redaction #73
• feat(ui): add formatRelative() for human-readable timestamps #72
• feat(state): add encodeCursor/decodeCursor for pagination #71
• feat(types): add hashId() for deterministic short identifiers #70
• feat(contracts): add Logger.child() and fix AssertionError category #69
• feat(config): centralize environment variable access with Zod validation #42
• fix(logging): enable redaction by default when global rules exist #41
• docs(ui): add README, CHANGELOG, and TSDoc comments #39
• docs(state): add README, CHANGELOG, and TSDoc comments #38
• docs(file-ops): add README, CHANGELOG, and TSDoc comments #37
• docs(logging): add README, CHANGELOG, and TSDoc comments #36
• docs(config): add README, CHANGELOG, and TSDoc comments #35
• fix(cli): enforce cursor TTL #114
• fix(tests): remove placeholder tests #113
• chore(gitattributes): prefer ours for bun lockfiles #115
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[greptile-apps]

Greptile Summary

• Refactors error type definitions across 5 packages to resolve TypeScript TS9021 warnings when extending TaggedError factory functions directly
• Introduces intermediate base class pattern using TaggedErrorClass typing to maintain identical runtime behavior while eliminating compiler warnings
• Adds type-only export for TaggedErrorClass in packages/contracts/src/index.ts to centralize error typing utilities for other packages

Important Files Changed

Filename	Overview
packages/contracts/src/errors.ts	Refactored 3 error classes (ValidationError, AssertionError, NotFoundError) to use intermediate base classes instead of extending TaggedError expressions directly
packages/daemon/src/errors.ts	Refactored 5 daemon-specific error classes to use base class pattern, avoiding TypeScript warnings while preserving API

Confidence score: 5/5

• This PR is extremely safe to merge with virtually no risk of production issues
• Score reflects a purely structural TypeScript refactoring that maintains identical runtime behavior and API compatibility while fixing compiler warnings
• No files require special attention as all changes follow the same safe pattern of extracting TaggedError factory calls into typed base classes

Sequence Diagram

sequenceDiagram
    participant User
    participant Config as "@outfitter/config"
    participant FileSystem as "File System"
    participant Parser as "Config Parser"
    participant Validator as "Schema Validator"
    
    User->>+Config: "loadConfig(appName, schema)"
    Config->>+FileSystem: "Search XDG config paths"
    FileSystem-->>-Config: "Return first matching config file"
    Config->>+FileSystem: "readFileSync(configPath)"
    FileSystem-->>-Config: "Raw config content"
    Config->>+Parser: "parseConfigFile(content, filename)"
    Parser-->>-Config: "Parsed config object"
    Config->>+Validator: "schema.safeParse(config)"
    Validator-->>-Config: "Validated config"
    Config-->>-User: "Result<T, Error>"

Loading

[greptile-apps]

_{6 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

style: redundant type annotation duplicates the exact same properties that are already specified in the TaggedErrorClass type parameter above

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/config/src/index.ts
Line: 68:77

Comment:
**style:** redundant type annotation duplicates the exact same properties that are already specified in the TaggedErrorClass type parameter above

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

[galligan]

Restacked and resubmitted; no additional changes in this PR.