feat(types): add hashId() for deterministic short identifiers #70
+209
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2026
Contributor
Author
This was referenced Jan 23, 2026
galligan
force-pushed
the
p3-7/contracts/logger-child
branch
from
8d043eb to
62826b8
Compare
galligan
force-pushed
the
p3-8/types/hash-id
branch
from
f7beb26 to
501e6c9
Compare
3 tasks
This was referenced Jan 23, 2026
galligan
force-pushed
the
p3-7/contracts/logger-child
branch
from
62826b8 to
71b347d
Compare
galligan
force-pushed
the
p3-8/types/hash-id
branch
from
501e6c9 to
538ae91
Compare
This was referenced Jan 23, 2026
Greptile Summary
|
| Filename | Overview |
|---|---|
| packages/types/src/hash-id.ts | New module implementing hashId() with Bun.hash() and base62 encoding for deterministic short identifiers |
| packages/types/src/tests/hash-id.test.ts | Comprehensive test suite covering determinism, configurability, URL-safety, uniqueness, and edge cases |
Confidence score: 4/5
- This PR is safe to merge with only minor review needed for one implementation assumption
- Score reflects solid test coverage and clean implementation, but one test assumes prefix consistency behavior that may not hold for all hash/encoding combinations
- Pay close attention to the prefix consistency test in
hash-id.test.tsto verify the assumption aligns with actual implementation behavior
Sequence Diagram
sequenceDiagram
participant User
participant hashId
participant Bun
participant toBase62
User->>hashId: "hashId('user-123', 8)"
hashId->>Bun: "Bun.hash('user-123')"
Bun-->>hashId: "64-bit hash number"
hashId->>toBase62: "toBase62(BigInt(hash))"
toBase62-->>hashId: "base62 string"
hashId->>hashId: "padStart(8, '0')"
hashId->>hashId: "slice(0, 8)"
hashId-->>User: "URL-safe hash ID"
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+135
to
+147
| it("same input with different lengths produces consistent prefixes", () => { | ||
| // Longer hashes should be extensions of shorter ones | ||
| // (this tests that the algorithm is consistent) | ||
| const input = "consistent-test"; | ||
| const short = hashId(input, 3); | ||
| const medium = hashId(input, 6); | ||
| const long = hashId(input, 10); | ||
|
|
||
| // The shorter hash should be a prefix of longer ones | ||
| expect(medium.startsWith(short)).toBe(true); | ||
| expect(long.startsWith(short)).toBe(true); | ||
| expect(long.startsWith(medium)).toBe(true); | ||
| }); |
There was a problem hiding this comment.
logic: This test assumes that longer hashes are extensions of shorter ones, but this may not hold true depending on how the base62 encoding is implemented. If the encoding uses modular arithmetic or truncation after encoding, this assumption could fail. Does the hashId implementation guarantee that longer results will always be prefixes of shorter ones for the same input?
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/types/src/__tests__/hash-id.test.ts
Line: 135:147
Comment:
**logic:** This test assumes that longer hashes are extensions of shorter ones, but this may not hold true depending on how the base62 encoding is implemented. If the encoding uses modular arithmetic or truncation after encoding, this assumption could fail. Does the hashId implementation guarantee that longer results will always be prefixes of shorter ones for the same input?
How can I resolve this? If you propose a fix, please make it concise.
Uses Bun.hash() with base62 encoding for URL-safe, collision-resistant short IDs. Configurable length (default 5 chars, ~916M combinations). Closes #46 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
galligan
changed the base branch from
p3-7/contracts/logger-child
to
graphite-base/70
galligan
force-pushed
the
p3-8/types/hash-id
branch
from
538ae91 to
a0c8b3f
Compare
galligan
force-pushed
the
graphite-base/70
branch
from
71b347d to
3820a22
Compare
galligan
changed the base branch from
graphite-base/70
to
p3-7/contracts/logger-child
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Bun.hash() with base62 encoding for URL-safe, collision-resistant
short IDs. Configurable length (default 5 chars, ~916M combinations).
Closes #46
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com