fix(cli): implement createCLI and command builder

[galligan]

Summary

• Add createCLI and command builder primitives for the CLI core.
• Cover core wiring with unit tests.
• Tighten CLI/command composition behavior.

Changes

• packages/cli/src/cli.ts
• packages/cli/src/command.ts
• packages/cli/src/tests/core.test.ts

Testing

• Not run (not requested).

[galligan]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(outfitter): sync templates on pack #108
• chore(changesets): ignore app package #107
• fix(errors): avoid TaggedError extends warnings #106
• chore(release): align package versions to 0.1.0 #105
• docs: add README and CHANGELOG for testing, kit, outfitter #95
• feat(templates): add daemon project template #94
• feat(templates): add MCP server project template #93
• feat(templates): add CLI project template #92
• fix(cli): implement confirmDestructive prompts #104
• fix(cli): implement createCLI and command builder #103 👈 (View in Graphite)
• feat(kit): add @outfitter/kit meta-package #91
• docs(daemon): add README and CHANGELOG #90
• fix(daemon): fix locking module bugs (GREEN phase) #89
• test(daemon): add locking module tests (RED phase) #88
• feat(daemon): add errors, platform, and locking module stubs #87
• feat(outfitter): add doctor command for environment validation #86
• feat(outfitter): add init command with project scaffolding #85
• feat(daemon): add IPC communication and health checks #84
• feat(daemon): add types and lifecycle management #83
• feat(index): add FTS5 full-text search implementation #82
• feat(index): add types for FTS5 full-text search #81
• feat(testing): add MCP and CLI test harnesses #80
• feat(testing): add test fixture utilities #79
• feat(mcp): add MCP server implementation with typed handlers #78
• feat(mcp): add types and interfaces for MCP server #77
• feat(ui): add Shape discriminated union and render() #76
• feat(ui): add createTokens semantic color layer #75
• feat(state): add pagination helpers #74
• feat(logging): add DEFAULT_PATTERNS for common secret redaction #73
• feat(ui): add formatRelative() for human-readable timestamps #72
• feat(state): add encodeCursor/decodeCursor for pagination #71
• feat(types): add hashId() for deterministic short identifiers #70
• feat(contracts): add Logger.child() and fix AssertionError category #69
• feat(config): centralize environment variable access with Zod validation #42
• fix(logging): enable redaction by default when global rules exist #41
• docs(ui): add README, CHANGELOG, and TSDoc comments #39
• docs(state): add README, CHANGELOG, and TSDoc comments #38
• docs(file-ops): add README, CHANGELOG, and TSDoc comments #37
• docs(logging): add README, CHANGELOG, and TSDoc comments #36
• docs(config): add README, CHANGELOG, and TSDoc comments #35
• fix(cli): enforce cursor TTL #114
• fix(tests): remove placeholder tests #113
• chore(gitattributes): prefer ours for bun lockfiles #115
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[greptile-apps]

Greptile Summary

• Implements core CLI functionality by adding createCLI factory and CommandBuilder implementation to replace placeholder stubs with working Commander.js wrappers
• Adds unit tests covering CLI creation, command registration, and basic wiring to establish foundational test coverage for the CLI package
• Introduces error handling, exit override mechanics, and async parsing capabilities to ensure proper CLI lifecycle management

Important Files Changed

Filename	Overview
packages/cli/src/cli.ts	Implements complete createCLI factory with error handling, exit override logic, and async parsing capabilities
packages/cli/src/command.ts	Replaces stub with full CommandBuilderImpl providing fluent API for typed Commander.js command construction

Confidence score: 4/5

• This PR is safe to merge with minimal risk as it implements well-structured foundational CLI functionality
• Score reflects solid implementation with proper error handling, but complex async parsing logic and Commander.js integration could benefit from more comprehensive testing
• Pay close attention to packages/cli/src/cli.ts exit override logic and async error handling paths

Sequence Diagram

sequenceDiagram
    participant User

Loading

[greptile-apps]

_{3 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

logic: Forward reference to cli before it's declared - this should reference the return value after it's created

Suggested change

	return cli;
	program.addCommand(builder.build());
	return { program, register, parse };

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/cli/src/cli.ts
Line: 75:75

Comment:
**logic:** Forward reference to `cli` before it's declared - this should reference the return value after it's created

```suggestion
		program.addCommand(builder.build());
		return { program, register, parse };
```

How can I resolve this? If you propose a fix, please make it concise.

[galligan]

Fixed forward reference in \ by declaring \ before registering , then assigning after . Restacked and resubmitted.

[galligan]

Correction: Fixed forward reference in packages/cli/src/cli.ts by declaring cli before registering onBeforeExit, then assigning after parse. Restacked and resubmitted.