Skip to content

Conversation

@galligan
Copy link
Contributor

@galligan galligan commented Jan 23, 2026

Summary

  • Remove placeholder tests now that real coverage exists elsewhere.

Changes

  • packages/cli/src/tests/placeholder.test.ts
  • packages/contracts/src/tests/placeholder.test.ts
  • packages/types/src/tests/placeholder.test.ts

Testing

  • Not run (not requested).

This was referenced Jan 23, 2026
Copy link
Contributor Author

galligan commented Jan 23, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@galligan galligan added the bug Something isn't working label Jan 23, 2026
@galligan galligan marked this pull request as ready for review January 23, 2026 20:25
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@greptile-apps
Copy link

greptile-apps bot commented Jan 23, 2026

Greptile Summary

  • Removes three placeholder test files that were added as temporary scaffolding to satisfy test runner requirements during initial development
  • Cleans up technical debt by deleting dummy tests from @outfitter/cli, @outfitter/contracts, and @outfitter/types packages
  • Part of transitioning from scaffolding phase to actual implementation with real test coverage existing elsewhere

Important Files Changed

No files require attention - all changes are simple deletions of placeholder content.

Confidence score: 5/5

  • This PR is extremely safe to merge with no risk of introducing issues
  • Score reflects straightforward cleanup of explicitly marked placeholder code with no functional dependencies
  • No files require special attention as all changes are clean deletions of test scaffolding

@galligan galligan changed the base branch from main to graphite-base/113 January 23, 2026 21:18
@galligan galligan force-pushed the fix/tests-remove-placeholders branch from 14dae67 to 9316e72 Compare January 23, 2026 21:19
@galligan galligan changed the base branch from graphite-base/113 to chore/lockfile-merge January 23, 2026 21:19
@galligan
Copy link
Contributor Author

Checked for new feedback; no changes needed. Stack still up to date.

Copy link
Contributor Author

galligan commented Jan 24, 2026

Merge activity

  • Jan 24, 1:54 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 24, 1:55 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jan 24, 1:56 PM UTC: @galligan merged this pull request with Graphite.

@galligan galligan changed the base branch from chore/lockfile-merge to graphite-base/113 January 24, 2026 13:55
@galligan galligan changed the base branch from graphite-base/113 to main January 24, 2026 13:55
@galligan galligan force-pushed the fix/tests-remove-placeholders branch from 9316e72 to 940e80d Compare January 24, 2026 13:55
@galligan galligan merged commit ed1fcee into main Jan 24, 2026
1 check passed
@galligan galligan deleted the fix/tests-remove-placeholders branch January 24, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants