Skip to content

Conversation

@galligan
Copy link
Contributor

@galligan galligan commented Jan 23, 2026

Summary

Adds comprehensive documentation to @outfitter/logging package:

  • README.md — Installation, quick start, log levels, redaction patterns, child loggers, formatters, sinks
  • CHANGELOG.md — Initial 0.1.0 release notes
  • TSDoc comments — All exported functions, types, and interfaces documented with @param, @returns, and @example

Highlights

  • Documents log level hierarchy (trace → fatal → silent)
  • Shows automatic redaction of sensitive keys (password, token, secret, apikey)
  • Covers custom redaction patterns for API keys (OpenAI, GitHub PATs, Bearer tokens)
  • Explains child logger context inheritance

Test plan

  • bun run typecheck passes
  • bun run build succeeds

🤖 Generated with Claude Code

Copy link
Contributor Author

galligan commented Jan 23, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@galligan galligan marked this pull request as ready for review January 23, 2026 03:12
This was referenced Jan 23, 2026
@greptile-apps
Copy link

greptile-apps bot commented Jan 23, 2026

Greptile Summary

  • Adds comprehensive documentation to the @outfitter/logging package including README, CHANGELOG, and TSDoc comments for all exported functions and types
  • Establishes documentation standards with complete API reference, usage examples, and version history following Keep a Changelog format
  • Documents key features like log level hierarchy, automatic sensitive data redaction, child logger context inheritance, and formatter/sink configurations

Important Files Changed

Filename Overview
packages/logging/README.md New comprehensive user documentation with installation guide, API examples, and complete feature coverage; potential API inconsistencies need verification
packages/logging/src/index.ts Enhanced all exports with detailed TSDoc comments including parameter descriptions, return types, and usage examples

Confidence score: 3/5

  • This PR contains mostly documentation changes with minimal risk to production functionality
  • Score reflects potential API inconsistencies between documentation and actual implementation that need verification
  • Pay close attention to packages/logging/README.md to ensure documented API matches the actual exported interface

Sequence Diagram

sequenceDiagram
    participant User
    participant Logger
    participant RedactionEngine
    participant Formatter
    participant Sink

    User->>Logger: "createLogger(config)"
    Logger->>Logger: "initialize internal state"
    User->>Logger: "logger.info(message, metadata)"
    Logger->>Logger: "shouldLog(level, minLevel)"
    Logger->>RedactionEngine: "processMetadata(metadata, redactionConfig)"
    RedactionEngine->>RedactionEngine: "redactValue(value, keys, patterns)"
    RedactionEngine-->>Logger: "processed metadata"
    Logger->>Logger: "create LogRecord"
    loop for each sink
        Logger->>Formatter: "format(record)"
        Formatter-->>Logger: "formatted string"
        Logger->>Sink: "write(record, formatted)"
        Sink->>Sink: "output to destination"
    end
Loading

@galligan
Copy link
Contributor Author

Checked for new feedback; no changes needed. Stack still up to date.

Copy link
Contributor Author

galligan commented Jan 24, 2026

Merge activity

  • Jan 24, 1:54 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 24, 2:01 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jan 24, 2:02 PM UTC: @galligan merged this pull request with Graphite.

@galligan galligan changed the base branch from p3-4/config/docs to graphite-base/36 January 24, 2026 13:59
@galligan galligan changed the base branch from graphite-base/36 to main January 24, 2026 14:00
@galligan galligan merged commit 6ee6b10 into main Jan 24, 2026
1 check passed
@galligan galligan deleted the p3-4/logging/docs branch January 24, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants