Skip to content

πŸ› dashboard: show a decomposed parent waiting on children as Tracking, not stuck Actionable - #16486

Merged
hivecommons-hive[bot] merged 3 commits into
v5from
fix/tracker-children-word
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v5from
fix/tracker-children-word

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #16481

Why

On the hive's own spoke, #16242 (tracker 3/4) sat at Actionable for 18h with caption "Triaged and eligible; waiting for the scanner to pick it up β€” actionable; waiting on 1 open child issue(s)" and stage_actor.why = "waiting for the scanner to pick it up". The scanner is deliberately not claiming it (its status checks say so); the parent is waiting on child #16265 / PR #16456. The row read as scanner latency.

stageengine.deriveIssue already appends ; waiting on N open child issue(s) to a decomposed parent's reason (#12857); the presentation layer ignored it.

What

  • stageengine.ReasonOpenChildren(reason) parses the suffix.
  • StageTrackerItem.OpenChildren (open_children) is set for a 010 issue with the suffix; caption becomes "Tracking β€” 3 of 4 children done; waiting on 1 open child issue(s). The scanner leaves a decomposed parent to its children", actor its children, stage_actor kind none with a matching why.
  • The lit 010 chevron reads Tracking Β· 3/4 (children known) or Tracking Β· N open children via stageTrackerTrackingWord; plain 010 rows, PRs and 040 parents are untouched.
  • Docs word list + changelog fragment.

Does not touch tracker-row CSS spacing or stage_tracker_activity.go (another branch owns those).

Tests

TestReasonOpenChildren, TestStageTrackerTrackingParentIsNotWaitingOnScanner, TestStageTrackerTrackingWordJS (node); full ./pkg/dashboard/ and ./pkg/stageengine/... green; make dashboard-gen-check clean.

…, not stuck Actionable

A 010 issue whose stage reason carries the engine's "waiting on N open
child issue(s)" suffix is tracking its children; the scanner leaves it
alone. The row said "Actionable Β· waiting for the scanner to pick it
up" with an 18h since, which reads as scanner latency.

- stageengine.ReasonOpenChildren parses the suffix.
- StageTrackerItem.OpenChildren; caption/actor say Tracking β€” 3 of 4
  children done; waiting on 1 open child issue(s); stage_actor is none.
- Lit 010 chevron reads Tracking Β· 3/4 (or Tracking Β· N open children).

Fixes #16481

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16487 πŸ› dashboard: remove gap between tracker info line and stage chevrons same files src/pkg/dashboard/static/index.html
#16492 ✨ feat(dashboard): changed-paragraph reader kiosk view (part 1/3) same files src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • mobile-shots

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Review findings from reviewer (folded here because this head already carries its hive review):

Read the server and client paths at 709348fbf; this looks correct to me.

  • src/pkg/stageengine/derive_issue.go:81 is the only producer of the ; waiting on N open child issue(s) suffix and the new ReasonOpenChildren (lines 38-58) sits beside it, so the parser and the format are single-sourced; a non-numeric or zero count falls back to 0 and the row stays plain Actionable.
  • Ordering in stage_tracker_build.go:183-189: stageTrackerApplyTracking runs after the generic caption and before the soak override, and the actor is derived later from finished fields (stage_tracker_actor.go:135-136), so OpenChildren is already set when stageTrackerStageActorOf picks StageActorNone over "waiting for the scanner".
  • Client: tracker-row.js:53 only substitutes the word when n === 10 && cur === 10 and open_children > 0, so a parent that has moved past 010 keeps its normal chevron text; static-src and static/index.html carry identical copies.

Open item, not a finding: mobile-shots is red here and on #16487 alike; I could not read the job log from this side, so I cannot say whether it is baseline or this diff.

Evidence bundle `#1648620f63f0` sha256:f547c6709f62d0365db99786d4eff6169a180b88613043ad6a28c80e3c73d002 β€” download from the dashboard or `hivectl review evidence #16486`.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the Go side at 709348f against the tree. Looks correct to me.

  • stageengine.ReasonOpenChildren (src/pkg/stageengine/derive_issue.go:44-58) parses exactly the suffix deriveIssue emits at :81 ("; waiting on " + N + " open child issue(s)"), splitting on ; so it also works when the base reason is the long partial-cover sentence. Non-numeric or zero returns 0, so a malformed suffix leaves the row alone.
  • Ordering in buildStageTracker: the shared classify closure sets Caption/Actor at stage_tracker_build.go:183 and stageTrackerApplyTracking runs right after at :184; it.Children is populated at item construction (:294-300) so the "3 of 4 children done" head has data; stageTrackerStageActor is computed later at :362, so OpenChildren is already set when stage_tracker_actor.go:180 checks it. The rewrite is gated to Kind == "issue" and stage 010, matching where the engine attaches the suffix to a parent that is still actionable.
  • TestStageTrackerTrackingParentIsNotWaitingOnScanner covers the rewritten row, the count-only row, and the three negative cases (plain 010 issue, PR, 040 parent), so the "Actionable" word for ordinary issues is pinned.

mobile-shots is red on this head; I did not dig into it.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit b1bb2ee into v5 Nov 4, 2026
82 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/tracker-children-word branch November 4, 2026 00:51
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 20f63f0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› Activity monitor shows a decomposed parent waiting on children as a stuck Actionable row

1 participant