Repository navigation
π dashboard: show a decomposed parent waiting on children as Tracking, not stuck Actionable - #16486
Conversation
β¦, not stuck Actionable A 010 issue whose stage reason carries the engine's "waiting on N open child issue(s)" suffix is tracking its children; the scanner leaves it alone. The row said "Actionable Β· waiting for the scanner to pick it up" with an 18h since, which reads as scanner latency. - stageengine.ReasonOpenChildren parses the suffix. - StageTrackerItem.OpenChildren; caption/actor say Tracking β 3 of 4 children done; waiting on 1 open child issue(s); stage_actor is none. - Lit 010 chevron reads Tracking Β· 3/4 (or Tracking Β· N open children). Fixes #16481 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Read the server and client paths at
Open item, not a finding: |
There was a problem hiding this comment.
Read the Go side at 709348f against the tree. Looks correct to me.
stageengine.ReasonOpenChildren(src/pkg/stageengine/derive_issue.go:44-58) parses exactly the suffixderiveIssueemits at:81("; waiting on " + N + " open child issue(s)"), splitting on;so it also works when the base reason is the long partial-cover sentence. Non-numeric or zero returns 0, so a malformed suffix leaves the row alone.- Ordering in
buildStageTracker: the shared classify closure setsCaption/Actoratstage_tracker_build.go:183andstageTrackerApplyTrackingruns right after at:184;it.Childrenis populated at item construction (:294-300) so the "3 of 4 children done" head has data;stageTrackerStageActoris computed later at:362, soOpenChildrenis already set whenstage_tracker_actor.go:180checks it. The rewrite is gated toKind == "issue"and stage 010, matching where the engine attaches the suffix to a parent that is still actionable. TestStageTrackerTrackingParentIsNotWaitingOnScannercovers the rewritten row, the count-only row, and the three negative cases (plain 010 issue, PR, 040 parent), so the "Actionable" word for ordinary issues is pinned.
mobile-shots is red on this head; I did not dig into it.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 20f63f0. |
Fixes #16481
Why
On the hive's own spoke, #16242 (
tracker 3/4) sat at Actionable for 18h with caption "Triaged and eligible; waiting for the scanner to pick it up β actionable; waiting on 1 open child issue(s)" andstage_actor.why = "waiting for the scanner to pick it up". The scanner is deliberately not claiming it (its status checks say so); the parent is waiting on child #16265 / PR #16456. The row read as scanner latency.stageengine.deriveIssuealready appends; waiting on N open child issue(s)to a decomposed parent's reason (#12857); the presentation layer ignored it.What
stageengine.ReasonOpenChildren(reason)parses the suffix.StageTrackerItem.OpenChildren(open_children) is set for a 010 issue with the suffix; caption becomes "Tracking β 3 of 4 children done; waiting on 1 open child issue(s). The scanner leaves a decomposed parent to its children", actorits children,stage_actorkindnonewith a matching why.Tracking Β· 3/4(children known) orTracking Β· N open childrenviastageTrackerTrackingWord; plain 010 rows, PRs and 040 parents are untouched.Does not touch tracker-row CSS spacing or
stage_tracker_activity.go(another branch owns those).Tests
TestReasonOpenChildren,TestStageTrackerTrackingParentIsNotWaitingOnScanner,TestStageTrackerTrackingWordJS(node); full./pkg/dashboard/and./pkg/stageengine/...green;make dashboard-gen-checkclean.