Skip to content

πŸ› dashboard: CI/Review chevrons always carry a state word and name the track the hive waits on - #16488

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/tracker-chevron-state-word
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/tracker-chevron-state-word

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #16484

Problem

Operator screenshot: four Activity Monitor rows at the CI / Review phase, both chevrons amber with only a glyph and no words β€” "I can't tell what's going on with any of these 4 rows."

stageTrackerActivityTrackHtml rendered a bare icon whenever known was false: evidence missing, for another head, state unknown, or observed_at older than 2 min. Server-side observed_at comes from caches (status cache, review-bundle UpdatedAt) that are routinely older than that, so between polls most column-50 tracks collapsed to the glyph even though the payload carried a caption (CI waiting Β· test not observed, Review findings Β· awaiting author). #16473 made the two glyphs distinct but added no words. Both tracks also share the row's current-phase tint, so nothing said which one the hive was waiting on.

Change (confined to tracker-row-strip.js)

  • Chevron always renders glyph + caption. Stale evidence appends Β· seen 14m ago; missing evidence reads CI unknown Β· no evidence for <sha7>. Freshness still gates the pulse (data-motion) and the green done fill β€” only the text changed.
  • New pure stageTrackerTrackLead(item): review findings or red CI β†’ the fixer's turn (the fix); otherwise CI leads until green, then review; newHead when the head was just pushed. Within the current phase the leading CI track appends Β· new head d3c0824, the other track appends Β· waiting on CI | review | the fix (never on a done or finding track). The tooltip repeats it as hive is waiting on … for new head ….
  • The tucked β“˜ note is the 30 s auto-collapse feature, left alone (another PR is making it persist).

Rendering for the four screenshot rows

row CI Review
#16456 CI waiting Β· test not observed Β· seen 14m ago Β· waiting on the fix Review findings Β· awaiting author Β· seen 38m ago
pluk#438 CI failing Β· test (26) Review findings Β· awaiting author Β· adjudicator
#16478 CI unknown Β· required checks not observed Review unknown Β· current-head evidence unavailable Β· waiting on CI
#16268 CI waiting Β· test not observed Β· seen 14m ago Review approved Β· seen 38m ago

Tests

  • stage_tracker_activity.test.js: the three icon-only assertions from πŸ› Restore activity monitor layout and compact chevronsΒ #16454 flipped to glyph + words; two new cases cover the four operator shapes (never a bare glyph) and the lead clause matrix (new head / findings / both findings / CI green / both unknown / outside the phase).
  • node --test src/pkg/dashboard/*.test.js 288 pass; make dashboard-gen && make dashboard-gen-check; go test ./pkg/dashboard/ -run 'Tracker|Activity' ok.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16492 ✨ feat(dashboard): changed-paragraph reader kiosk view (part 1/3) same files src/pkg/dashboard/static/index.html
#16486 πŸ› dashboard: show a decomposed parent waiting on children as Tracking, not stuck Actionable same files src/pkg/dashboard/static/index.html
#16487 πŸ› dashboard: remove gap between tracker info line and stage chevrons same files src/pkg/dashboard/stage_tracker_activity.test.js
src/pkg/dashboard/static/index.html

…e track the hive waits on

A column-50 track whose evidence was unknown, stale (observed_at older
than 2 min, which server caches routinely are) or for another head
rendered as a bare glyph. Both tracks share the row's current-phase
tint, so an operator saw two amber chevrons with no words and no way to
tell which one was live.

stageTrackerActivityTrackHtml now always renders glyph + caption; stale
evidence says how old it is, missing evidence says 'no evidence for
<sha>'. Freshness still gates the pulse and the green fill. A new pure
stageTrackerTrackLead picks the track the hive waits on when both share
the phase (review findings / red CI β†’ the fix; otherwise CI until green,
then review) and the chevron text carries 'Β· new head <sha>' on the
leading CI track or 'Β· waiting on CI|review|the fix' on the other; the
tooltip repeats it as a sentence.

Fixes #16484

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the fix/tracker-chevron-state-word branch from 70f0c3d to bc10654 Compare November 4, 2026 00:33
@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 771862c into v5 Nov 4, 2026
83 of 87 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/tracker-chevron-state-word branch November 4, 2026 00:40
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#1648870f0c3d` sha256:087a14c5a41c0cdd17eb3f86ef858ceb4463d86e6ce8fd7c07e1c615c68d3731 β€” download from the dashboard or `hivectl review evidence #16488`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at bc10654.

hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
…/total, lit while in progress (#16494)

* fix(dashboard): CI/Review chevrons carry pass/total and done/total counts, lit while in progress

Operator steer on #16488: dull current-phase tint with glyph-only chevrons
was unreadable. Every CI/Review chevron in progress or finished on the
current head now reads a count caption (CI p/t, Review d/t) with the full
active fill, done style when complete, error style on a finding, and the
glyph alone only when not started. Server adds checks_passed/total/failed/
failing and perspectives_done/total to StageTrackerActivity.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* test(dashboard): geometry probe expects count words on lit tracks; count captions wrap like peer chevrons

The browser probe's 'unknown track is icon-only' assertion predates the
count captions; a lit unknown track now reads 'CI ?/? Β· no checks
reported yet' and only a not-started (.todo) track is the glyph alone.
Drop the nowrap/ellipsis rule so the count caption honours the strip's
two-line wrap budget instead of truncating mid-count on phones.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› dashboard: active CI/Review chevrons render a glyph with no state word, and dual-active tracks do not say which one the hive waits on

1 participant