Repository navigation
π dashboard: CI/Review chevrons always carry a state word and name the track the hive waits on - #16488
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
β¦e track the hive waits on A column-50 track whose evidence was unknown, stale (observed_at older than 2 min, which server caches routinely are) or for another head rendered as a bare glyph. Both tracks share the row's current-phase tint, so an operator saw two amber chevrons with no words and no way to tell which one was live. stageTrackerActivityTrackHtml now always renders glyph + caption; stale evidence says how old it is, missing evidence says 'no evidence for <sha>'. Freshness still gates the pulse and the green fill. A new pure stageTrackerTrackLead picks the track the hive waits on when both share the phase (review findings / red CI β the fix; otherwise CI until green, then review) and the chevron text carries 'Β· new head <sha>' on the leading CI track or 'Β· waiting on CI|review|the fix' on the other; the tooltip repeats it as a sentence. Fixes #16484 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
70f0c3d to
bc10654
Compare
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at bc10654. |
β¦/total, lit while in progress (#16494) * fix(dashboard): CI/Review chevrons carry pass/total and done/total counts, lit while in progress Operator steer on #16488: dull current-phase tint with glyph-only chevrons was unreadable. Every CI/Review chevron in progress or finished on the current head now reads a count caption (CI p/t, Review d/t) with the full active fill, done style when complete, error style on a finding, and the glyph alone only when not started. Server adds checks_passed/total/failed/ failing and perspectives_done/total to StageTrackerActivity. Signed-off-by: Andrew Anderson <andy@clubanderson.com> * test(dashboard): geometry probe expects count words on lit tracks; count captions wrap like peer chevrons The browser probe's 'unknown track is icon-only' assertion predates the count captions; a lit unknown track now reads 'CI ?/? Β· no checks reported yet' and only a not-started (.todo) track is the glyph alone. Drop the nowrap/ellipsis rule so the count caption honours the strip's two-line wrap budget instead of truncating mid-count on phones. Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Fixes #16484
Problem
Operator screenshot: four Activity Monitor rows at the CI / Review phase, both chevrons amber with only a glyph and no words β "I can't tell what's going on with any of these 4 rows."
stageTrackerActivityTrackHtmlrendered a bare icon wheneverknownwas false: evidence missing, for another head, stateunknown, orobserved_atolder than 2 min. Server-sideobserved_atcomes from caches (status cache, review-bundleUpdatedAt) that are routinely older than that, so between polls most column-50 tracks collapsed to the glyph even though the payload carried a caption (CI waiting Β· test not observed,Review findings Β· awaiting author). #16473 made the two glyphs distinct but added no words. Both tracks also share the row's current-phase tint, so nothing said which one the hive was waiting on.Change (confined to
tracker-row-strip.js)Β· seen 14m ago; missing evidence readsCI unknown Β· no evidence for <sha7>. Freshness still gates the pulse (data-motion) and the greendonefill β only the text changed.stageTrackerTrackLead(item): review findings or red CI β the fixer's turn (the fix); otherwise CI leads until green, then review;newHeadwhen the head was just pushed. Within the current phase the leading CI track appendsΒ· new head d3c0824, the other track appendsΒ· waiting on CI | review | the fix(never on a done or finding track). The tooltip repeats it ashive is waiting on β¦ for new head β¦.Rendering for the four screenshot rows
CI waiting Β· test not observed Β· seen 14m ago Β· waiting on the fixReview findings Β· awaiting author Β· seen 38m agoCI failing Β· test (26)Review findings Β· awaiting author Β· adjudicatorCI unknown Β· required checks not observedReview unknown Β· current-head evidence unavailable Β· waiting on CICI waiting Β· test not observed Β· seen 14m agoReview approved Β· seen 38m agoTests
stage_tracker_activity.test.js: the three icon-only assertions from π Restore activity monitor layout and compact chevronsΒ #16454 flipped to glyph + words; two new cases cover the four operator shapes (never a bare glyph) and the lead clause matrix (new head / findings / both findings / CI green / both unknown / outside the phase).node --test src/pkg/dashboard/*.test.js288 pass;make dashboard-gen && make dashboard-gen-check;go test ./pkg/dashboard/ -run 'Tracker|Activity'ok.