Skip to content

πŸ› dashboard: remove gap between tracker info line and stage chevrons - #16487

Merged
clubanderson merged 2 commits into
v5from
fix/tracker-info-chevron-gap
Nov 4, 2026
Merged

clubanderson merged 2 commits into
v5from
fix/tracker-info-chevron-gap

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #16485

Tracker rows in the Activity Monitor doubled in height after #16454 (layout restore / compact chevrons) and #16461 (acceptance stabilisation). This restores the Nov-2 density while keeping the #16473 CI/Review glyphs and icon+label chevron content.

Root causes (all in static-src/css/tracker.css, plus the head markup in tracker-row-layout.js)

Symptom Rule
30–40px "blank" band between the info line and the chevron strip The row toolbar (Let hive decide / hold pills) was rendered as its own <li class="ham-seg cap"> on grid-row: 2 of the head grid β€” a full-width, right-anchored line that reads as empty space when the pills are off-screen or absent. The pills now trail the PR cell (.ham-head-pr > .ham-badges, margin-left: auto) on the title line; the cap line is gone.
Chevrons 24–48px tall instead of ~20px --ham-chevron-text-lines: 2 + -webkit-line-clamp on .ham-chevron-copy, padding: var(--sp-2) … on .ham-strip[aria-label="Pipeline progress"] > .ham-seg, and a grid-auto-rows: minmax(1.3em + 2*sp-2 + 2*line-width, auto) floor. Now one caption line with ellipsis, sp-1 vertical padding, matching floor β†’ 20px strips. Full text stays in the tooltip / aria-label.
Issue title dropped onto its own line even with half the row free .ham-head-main became flex-wrap: wrap while .ham-title kept a max-content flex basis (flex: 0 1 auto), so a wrapping flex container moves the whole title to the next flex line as soon as it cannot fit entirely. Now flex: 1 1 0; min-width: 0 β€” it fills the rest of the chip line and only wraps its own words. The PR ref (.ham-pr-ref/.ham-pr-line) does the same with a min(100%, 20em) floor so the right-anchored pills share the first line.
Extra space above/below the strip .ham-row { padding: var(--sp-5) var(--sp-2) } β†’ var(--sp-4) (and .ham-row-tools { top } to match).

Measured (1440Γ—1200@1, dark, activity-density fixture)

Row Before After
simple PR-only row (#9001…) 71–99px (head 18–33, chevrons 24–36) 59px (head 18, chevrons 20)
#343 issue + PR 126px (head 73) 91px (head 50)
#16438 with 2 sub-rows 360px 201px
rows visible in a 1200px-tall viewport 8 16

Before / after (same viewport and zoom)

Before:

before: tall rows, blank band under the title, title on its own line

After:

after: compact rows, one-line chevrons directly under the inline title

Tests

  • stage_tracker_header_spans.test.js: chevron-height test retargeted to the one-line contract; new test asserts the kind icon, repo chip, #ref, agent chip and title render in one .ham-head-main flex container with flex: 1 1 0 on the title; toolbar tests retargeted to the inline PR-cell placement.
  • stage_tracker_activity.test.js: --ham-chevron-text-lines: 1, sp-1 padding.
  • webstatic/testdata/tracker-header-geometry.js probe: one-line height contract, clamp coverage (clampedRows) replaces the two-line coverage, chevrons-directly-under-title and toolbar-on-title-line checks.
  • All src/pkg/dashboard/*.test.js pass locally; make dashboard-gen-check passes.
  • dashboard-mobile-shots.mjs --theme dark activity probes pass at 2400 and 1440 (and now also 1110, which failed on origin/v5); 1024 keeps the same pre-existing "row 15 caption centred" failure as baseline.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16492 ✨ feat(dashboard): changed-paragraph reader kiosk view (part 1/3) same files src/pkg/dashboard/static/index.html
#16494 πŸ› dashboard: CI/Review chevrons show pass/total and perspectives done/total, lit while in progress same files src/pkg/dashboard/stage_tracker_activity.test.js
src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • mobile-shots

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Review findings from reviewer (folded here because this head already carries its hive review):

The red test (dashboard 2/4) / test (dashboard shuffle 1/3) / coverage checks are this diff's own doing, not infrastructure: TestStageTrackerRows fails with AssertionError: the chip cell closes the title line, directly above its own strip row at e043554.

  • src/pkg/dashboard/stage_tracker_ui_rows_test.go:35 still asserts the pre-PR head markup <li class="ham-seg cap"><span class="ham-badges">…</span></li></ol><span class="ham-since">. stageTrackerHeadColsHtml (static-src/js/tracker-row-layout.js:14-19) no longer emits a cap segment on the title line β€” the chips now ride <li class="ham-seg ham-head-pr[ ham-head-tools]">…<span class="ham-badges">. The PR updated stage_tracker_header_spans.test.js and stage_tracker_activity.test.js but this Go-embedded fixture was missed.
  • stage_tracker_ui_rows_test.go:523 asserts the same old shape for the no-PR row (…</li><li class="ham-seg cap"><span class="ham-badges"></span></li>) and will fail next once line 35 is fixed; :498 compares positions against <li class="ham-seg cap"> in the head and should be re-read at the same time, since that string is now only present on the strip row (tracker-row-strip.js).

The layout change itself reads as intended β€” one ham-head-pr cell carries refs + right-anchored chips, so the second grid row the toolbar used to occupy is gone β€” but I have not verified the rendered geometry beyond the fixtures. Updating the three assertions to the new ham-head-pr/ham-head-tools markup should turn the dashboard slices green; coverage and test are the aggregators of those slices.

Not a finding: mobile-shots is also red here and on #16486; I could not read its log from this side.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The red test (dashboard 2/4) / dashboard shuffle 1/3 / coverage on e043554 is this PR's own, and it is a one-line test update, not a logic problem.

TestStageTrackerRows fails with the chip cell closes the title line, directly above its own strip row. That assertion is src/pkg/dashboard/stage_tracker_ui_rows_test.go:35:

/<li class="ham-seg cap"><span class="ham-badges">[\s\S]*?<\/span><\/li><\/ol><span class="ham-since"><\/span><\/div>\s*<\/div>\s*<div class="ham-strip-row">/

It pins the pre-PR head markup where the chips lived in their own <li class="ham-seg cap">. This PR's tracker-row-layout.js deliberately moves <span class="ham-badges"> into the ham-head-pr cell (…ham-head-pr${wide ? ' ham-head-tools' : ''}…>${prRefs}<span class="ham-badges">…) and drops the cap li from the head grid β€” that is the fix for the blank band β€” so the regex can no longer match. The new header-spans test (stage_tracker_header_spans.test.js:219) already asserts the new ham-head-tools cell; stage_tracker_ui_rows_test.go:35 is the only remaining assertion on the old location.

Suggested: rewrite that assertion to expect <li class="ham-seg ham-head-pr…"><span class="ham-badges">…</span></li></ol><span class="ham-since"></span></div> immediately followed by the ham-strip-row, so it keeps pinning "chips end the title line, directly above the strip" against the new structure. The comment above it (:31-34) still describes the intended invariant correctly.

I did not review the CSS density changes themselves beyond this; mobile-shots red was not investigated.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

…title)

Tracker rows in the Activity Monitor doubled in height after the layout
restore (#16454) and acceptance stabilisation (#16461):

- the row toolbar (hold / Let hive decide pills) was a separate
  full-width grid line between the title and the chevrons, reading as a
  30-40px blank band; it now trails the PR cell on the title line;
- chevrons carried a two-line caption budget, sp-2 vertical padding and
  a matching grid-auto-rows floor (24-48px); captions are clamped to one
  line with ellipsis and sp-1 padding (~20px), the pre-#16454 density;
- the issue title had a max-content flex basis inside a wrapping
  .ham-head-main, so it dropped to its own line whenever it could not
  fit entirely; it now fills the rest of the chip line (flex: 1 1 0)
  and wraps only its own words. The PR ref does the same with a 20em
  floor so pills stay on the first line;
- row padding sp-5 -> sp-4.

Simple rows measure 59px (was 71-99px) at 1440x1200@1; 16 rows fit in
the viewport where 8 did. Tests and the tracker-header-geometry probe
are retargeted to the one-line contract; a node test pins the inline
title.

Fixes #16485

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…hip cell

TestStageTrackerRows still asserted the pre-PR head markup (a separate
<li class="ham-seg cap"> toolbar line); the chips now trail the PR
cell (ham-head-pr / ham-head-tools) on the title line.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the fix/tracker-info-chevron-gap branch from e043554 to 7381729 Compare November 4, 2026 00:41
@clubanderson
clubanderson merged commit 673f43e into v5 Nov 4, 2026
82 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/tracker-info-chevron-gap branch November 4, 2026 00:57
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
mobile-shots fails tracker-header-geometry on every mobile tier of any
branch rebased onto v5 since #16487: the generic mobile control
min-height inflates one-line tracker chevrons to 44px (expected ~20px)
and shifts the caption off-centre. Override the minimum heights inside
the tracker strip and include display: contents icon wrappers in the
probe's centring measurement.

Hunk authored by @thatguywob in #16503 (be1492a, proven green on
mobile-shots) and dropped before that PR was squash-merged; carried here
so this PR can go green.

Co-authored-by: thatguywob <thatguywob@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
mobile-shots fails tracker-header-geometry on every mobile tier of any
branch rebased onto v5 since #16487: the generic mobile control
min-height inflates one-line tracker chevrons to 44px (expected ~20px)
and shifts the caption off-centre. Override the minimum heights inside
the tracker strip and include display: contents icon wrappers in the
probe's centring measurement.

Hunk authored by @thatguywob in #16503 (be1492a, proven green on
mobile-shots) and dropped before that PR was squash-merged; carried here
so this PR can go green.

Co-authored-by: thatguywob <thatguywob@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
mobile-shots fails tracker-header-geometry on every mobile tier of any
branch rebased onto v5 since #16487: the generic mobile control
min-height inflates one-line tracker chevrons to 44px (expected ~20px)
and shifts the caption off-centre. Override the minimum heights inside
the tracker strip and include display: contents icon wrappers in the
probe's centring measurement.

Hunk authored by @thatguywob in #16503 (be1492a, proven green on
mobile-shots) and dropped before that PR was squash-merged; carried here
so this PR can go green.

Co-authored-by: thatguywob <thatguywob@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
mobile-shots fails tracker-header-geometry on every mobile tier of any
branch rebased onto v5 since #16487: the generic mobile control
min-height inflates one-line tracker chevrons to 44px (expected ~20px)
and shifts the caption off-centre. Override the minimum heights inside
the tracker strip and include display: contents icon wrappers in the
probe's centring measurement.

Hunk authored by @thatguywob in #16503 (be1492a, proven green on
mobile-shots) and dropped before that PR was squash-merged; carried here
so this PR can go green.

Co-authored-by: thatguywob <thatguywob@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
mobile-shots fails tracker-header-geometry on every mobile tier of any
branch rebased onto v5 since #16487: the generic mobile control
min-height inflates one-line tracker chevrons to 44px (expected ~20px)
and shifts the caption off-centre. Override the minimum heights inside
the tracker strip and include display: contents icon wrappers in the
probe's centring measurement.

Hunk authored by @thatguywob in #16503 (be1492a, proven green on
mobile-shots) and dropped before that PR was squash-merged; carried here
so this PR can go green.

Co-authored-by: thatguywob <thatguywob@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
…6492)

* feat(dashboard): add changed-paragraph reader kiosk view

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* fix(dashboard): reader.css uses spacing/radius/font tokens

Keeps the operator index.html style ratchet at its baseline: the reader's
raw font-size, padding and border-radius values become var() tokens.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ› fix(dashboard): preserve compact mobile tracker chevrons

mobile-shots fails tracker-header-geometry on every mobile tier of any
branch rebased onto v5 since #16487: the generic mobile control
min-height inflates one-line tracker chevrons to 44px (expected ~20px)
and shifts the caption off-centre. Override the minimum heights inside
the tracker strip and include display: contents icon wrappers in the
probe's centring measurement.

Hunk authored by @thatguywob in #16503 (be1492a, proven green on
mobile-shots) and dropped before that PR was squash-merged; carried here
so this PR can go green.

Co-authored-by: thatguywob <thatguywob@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ› fix(dashboard): resume reader pulls from the last returned line

The /api/matrix/lines page is capped and its seq reports the newest line
the hive holds, not the last one returned. Storing it as lastSeq skipped
every line past the cap and the contiguity rule then split the region.
Resume from the last returned line, pull again until the page reaches the
newest seq, and hold the reveal while catching up so a region split across
pages still arrives as one paragraph.

Drop the op/pr_url handling: matrixLine carries only accepted added lines
and no PR URL, so the removal branch and URL path were unreachable and the
test pinned a contract the server does not emit.

Review findings for #16492.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* fix(dashboard): render op '-' lines and honour pr_url in reader (review)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: thatguywob <thatguywob@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› dashboard: activity monitor tracker rows twice as tall as before, title dropped to its own line

1 participant