Repository navigation
π dashboard: remove gap between tracker info line and stage chevrons - #16487
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from The red
The layout change itself reads as intended β one Not a finding: |
There was a problem hiding this comment.
The red test (dashboard 2/4) / dashboard shuffle 1/3 / coverage on e043554 is this PR's own, and it is a one-line test update, not a logic problem.
TestStageTrackerRows fails with the chip cell closes the title line, directly above its own strip row. That assertion is src/pkg/dashboard/stage_tracker_ui_rows_test.go:35:
/<li class="ham-seg cap"><span class="ham-badges">[\s\S]*?<\/span><\/li><\/ol><span class="ham-since"><\/span><\/div>\s*<\/div>\s*<div class="ham-strip-row">/
It pins the pre-PR head markup where the chips lived in their own <li class="ham-seg cap">. This PR's tracker-row-layout.js deliberately moves <span class="ham-badges"> into the ham-head-pr cell (β¦ham-head-pr${wide ? ' ham-head-tools' : ''}β¦>${prRefs}<span class="ham-badges">β¦) and drops the cap li from the head grid β that is the fix for the blank band β so the regex can no longer match. The new header-spans test (stage_tracker_header_spans.test.js:219) already asserts the new ham-head-tools cell; stage_tracker_ui_rows_test.go:35 is the only remaining assertion on the old location.
Suggested: rewrite that assertion to expect <li class="ham-seg ham-head-prβ¦"><span class="ham-badges">β¦</span></li></ol><span class="ham-since"></span></div> immediately followed by the ham-strip-row, so it keeps pinning "chips end the title line, directly above the strip" against the new structure. The comment above it (:31-34) still describes the intended invariant correctly.
I did not review the CSS density changes themselves beyond this; mobile-shots red was not investigated.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
β¦title) Tracker rows in the Activity Monitor doubled in height after the layout restore (#16454) and acceptance stabilisation (#16461): - the row toolbar (hold / Let hive decide pills) was a separate full-width grid line between the title and the chevrons, reading as a 30-40px blank band; it now trails the PR cell on the title line; - chevrons carried a two-line caption budget, sp-2 vertical padding and a matching grid-auto-rows floor (24-48px); captions are clamped to one line with ellipsis and sp-1 padding (~20px), the pre-#16454 density; - the issue title had a max-content flex basis inside a wrapping .ham-head-main, so it dropped to its own line whenever it could not fit entirely; it now fills the rest of the chip line (flex: 1 1 0) and wraps only its own words. The PR ref does the same with a 20em floor so pills stay on the first line; - row padding sp-5 -> sp-4. Simple rows measure 59px (was 71-99px) at 1440x1200@1; 16 rows fit in the viewport where 8 did. Tests and the tracker-header-geometry probe are retargeted to the one-line contract; a node test pins the inline title. Fixes #16485 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
β¦hip cell TestStageTrackerRows still asserted the pre-PR head markup (a separate <li class="ham-seg cap"> toolbar line); the chips now trail the PR cell (ham-head-pr / ham-head-tools) on the title line. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
e043554 to
7381729
Compare
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
mobile-shots fails tracker-header-geometry on every mobile tier of any branch rebased onto v5 since #16487: the generic mobile control min-height inflates one-line tracker chevrons to 44px (expected ~20px) and shifts the caption off-centre. Override the minimum heights inside the tracker strip and include display: contents icon wrappers in the probe's centring measurement. Hunk authored by @thatguywob in #16503 (be1492a, proven green on mobile-shots) and dropped before that PR was squash-merged; carried here so this PR can go green. Co-authored-by: thatguywob <thatguywob@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
mobile-shots fails tracker-header-geometry on every mobile tier of any branch rebased onto v5 since #16487: the generic mobile control min-height inflates one-line tracker chevrons to 44px (expected ~20px) and shifts the caption off-centre. Override the minimum heights inside the tracker strip and include display: contents icon wrappers in the probe's centring measurement. Hunk authored by @thatguywob in #16503 (be1492a, proven green on mobile-shots) and dropped before that PR was squash-merged; carried here so this PR can go green. Co-authored-by: thatguywob <thatguywob@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
mobile-shots fails tracker-header-geometry on every mobile tier of any branch rebased onto v5 since #16487: the generic mobile control min-height inflates one-line tracker chevrons to 44px (expected ~20px) and shifts the caption off-centre. Override the minimum heights inside the tracker strip and include display: contents icon wrappers in the probe's centring measurement. Hunk authored by @thatguywob in #16503 (be1492a, proven green on mobile-shots) and dropped before that PR was squash-merged; carried here so this PR can go green. Co-authored-by: thatguywob <thatguywob@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
mobile-shots fails tracker-header-geometry on every mobile tier of any branch rebased onto v5 since #16487: the generic mobile control min-height inflates one-line tracker chevrons to 44px (expected ~20px) and shifts the caption off-centre. Override the minimum heights inside the tracker strip and include display: contents icon wrappers in the probe's centring measurement. Hunk authored by @thatguywob in #16503 (be1492a, proven green on mobile-shots) and dropped before that PR was squash-merged; carried here so this PR can go green. Co-authored-by: thatguywob <thatguywob@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
mobile-shots fails tracker-header-geometry on every mobile tier of any branch rebased onto v5 since #16487: the generic mobile control min-height inflates one-line tracker chevrons to 44px (expected ~20px) and shifts the caption off-centre. Override the minimum heights inside the tracker strip and include display: contents icon wrappers in the probe's centring measurement. Hunk authored by @thatguywob in #16503 (be1492a, proven green on mobile-shots) and dropped before that PR was squash-merged; carried here so this PR can go green. Co-authored-by: thatguywob <thatguywob@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
β¦6492) * feat(dashboard): add changed-paragraph reader kiosk view Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * fix(dashboard): reader.css uses spacing/radius/font tokens Keeps the operator index.html style ratchet at its baseline: the reader's raw font-size, padding and border-radius values become var() tokens. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π fix(dashboard): preserve compact mobile tracker chevrons mobile-shots fails tracker-header-geometry on every mobile tier of any branch rebased onto v5 since #16487: the generic mobile control min-height inflates one-line tracker chevrons to 44px (expected ~20px) and shifts the caption off-centre. Override the minimum heights inside the tracker strip and include display: contents icon wrappers in the probe's centring measurement. Hunk authored by @thatguywob in #16503 (be1492a, proven green on mobile-shots) and dropped before that PR was squash-merged; carried here so this PR can go green. Co-authored-by: thatguywob <thatguywob@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π fix(dashboard): resume reader pulls from the last returned line The /api/matrix/lines page is capped and its seq reports the newest line the hive holds, not the last one returned. Storing it as lastSeq skipped every line past the cap and the contiguity rule then split the region. Resume from the last returned line, pull again until the page reaches the newest seq, and hold the reveal while catching up so a region split across pages still arrives as one paragraph. Drop the op/pr_url handling: matrixLine carries only accepted added lines and no PR URL, so the removal branch and URL path were unreachable and the test pinned a contract the server does not emit. Review findings for #16492. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * fix(dashboard): render op '-' lines and honour pr_url in reader (review) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: thatguywob <thatguywob@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes #16485
Tracker rows in the Activity Monitor doubled in height after #16454 (layout restore / compact chevrons) and #16461 (acceptance stabilisation). This restores the Nov-2 density while keeping the #16473 CI/Review glyphs and icon+label chevron content.
Root causes (all in
static-src/css/tracker.css, plus the head markup intracker-row-layout.js)Let hive decide/ hold pills) was rendered as its own<li class="ham-seg cap">ongrid-row: 2of the head grid β a full-width, right-anchored line that reads as empty space when the pills are off-screen or absent. The pills now trail the PR cell (.ham-head-pr > .ham-badges,margin-left: auto) on the title line; thecapline is gone.--ham-chevron-text-lines: 2+-webkit-line-clampon.ham-chevron-copy,padding: var(--sp-2) β¦on.ham-strip[aria-label="Pipeline progress"] > .ham-seg, and agrid-auto-rows: minmax(1.3em + 2*sp-2 + 2*line-width, auto)floor. Now one caption line with ellipsis,sp-1vertical padding, matching floor β 20px strips. Full text stays in the tooltip /aria-label..ham-head-mainbecameflex-wrap: wrapwhile.ham-titlekept a max-content flex basis (flex: 0 1 auto), so a wrapping flex container moves the whole title to the next flex line as soon as it cannot fit entirely. Nowflex: 1 1 0; min-width: 0β it fills the rest of the chip line and only wraps its own words. The PR ref (.ham-pr-ref/.ham-pr-line) does the same with amin(100%, 20em)floor so the right-anchored pills share the first line..ham-row { padding: var(--sp-5) var(--sp-2) }βvar(--sp-4)(and.ham-row-tools { top }to match).Measured (1440Γ1200@1, dark, activity-density fixture)
#9001β¦)#343issue + PR#16438with 2 sub-rowsBefore / after (same viewport and zoom)
Before:
After:
Tests
stage_tracker_header_spans.test.js: chevron-height test retargeted to the one-line contract; new test asserts the kind icon, repo chip,#ref, agent chip and title render in one.ham-head-mainflex container withflex: 1 1 0on the title; toolbar tests retargeted to the inline PR-cell placement.stage_tracker_activity.test.js:--ham-chevron-text-lines: 1,sp-1padding.webstatic/testdata/tracker-header-geometry.jsprobe: one-line height contract, clamp coverage (clampedRows) replaces the two-line coverage, chevrons-directly-under-title and toolbar-on-title-line checks.src/pkg/dashboard/*.test.jspass locally;make dashboard-gen-checkpasses.dashboard-mobile-shots.mjs --theme darkactivity probes pass at 2400 and 1440 (and now also 1110, which failed onorigin/v5); 1024 keeps the same pre-existing "row 15 caption centred" failure as baseline.