Repository navigation
π dashboard: CI/Review chevrons show pass/total and perspectives done/total, lit while in progress - #16494
Conversation
β¦unts, lit while in progress Operator steer on #16488: dull current-phase tint with glyph-only chevrons was unreadable. Every CI/Review chevron in progress or finished on the current head now reads a count caption (CI p/t, Review d/t) with the full active fill, done style when complete, error style on a finding, and the glyph alone only when not started. Server adds checks_passed/total/failed/ failing and perspectives_done/total to StageTrackerActivity. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Evidence bundle `#164948de521c` sha256:9b7844ec5f83915d641d77306a43c0d35384a41d4c87140af54105c591da0618 β download from the dashboard or `hivectl review evidence #16494`.Review findings from Looks correct to me. Read the Go and JS at
One intentional reversal worth a maintainer's nod, not a defect: #16484's "the chevron never shrinks to a bare icon" is replaced by "not started = glyph alone" ( The red checks on the rollup are all |
β¦unt captions wrap like peer chevrons The browser probe's 'unknown track is icon-only' assertion predates the count captions; a lit unknown track now reads 'CI ?/? Β· no checks reported yet' and only a not-started (.todo) track is the glyph alone. Drop the nowrap/ellipsis rule so the count caption honours the strip's two-line wrap budget instead of truncating mid-count on phones. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
β¦ommons/hive into fix/tracker-chevron-counts
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at c997bf1. |
There was a problem hiding this comment.
Go side looks correct to me (read at head c997bf1, not just the diff; I did not deep-read the JS/CSS/index.html changes beyond the shape of the new fields they consume).
stage_tracker_activity.go:70-73, 104-107β both early returns instageTrackerCIActivity(required set unknown, or a required name with no binding) now fall back tostageTrackerCountHeadChecks, soChecksTotalis only0when nothing was observed; the field comment's "0 means no count" contract holds.stage_tracker_activity.go:155-157, 180-189βperNamekeeps the worst-ranked state per required name and the pass/fail tallies iteratea.Required, so a required check with mixed re-runs counts once, as red if any run is red. Consistent with howout.Stateis already chosen.stageTrackerCountHeadChecksβ thecheck.Headfilter is a no-op for commit statuses (only check runs setHead,pkg/github/pr_ci_activity.go:53), so statuses are always counted toward the head; matches the existing "+github-commit-statuses" source handling.stageTrackerCountPerspectivesguardsout == nil, and bothbuildStageTrackercall sites (stage_tracker_build.go:472and the stacked-PR site) pass the same qualifier/expected set;dispatch.Pending[].Decisionandreview.NewPerspectiveSet(...).List()exist with the signatures used.
CI is green across all 86 checks on this head.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Integrates #16478, #16498 and #16505, which landed on v6 after the merge was prepared. tracker.css: kept v5's title-line grid (#16454..#16494, which supersedes #16498's flex-only title line and already keeps cap pills off the PR title); static/index.html regenerated from static-src. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
β¦hen adopted (#16532) A complete review verdict (5/5) parked on a human decision wore the amber in-progress fill and kept saying "awaiting human decision" even after the hive adopted the PR back into PR in progress. - JS: a settled human_decision track is done-style + muted (.decided); amber only while perspectives are running (a.active). CI unchanged: passed is done. - JS/Go: with the hive on the repair (074 adopted, 07x fix stages, no needs-human/hold/085) a human_decision verdict reads "changes requested"; the decision question and provenance ride in detail/source. - Tests: Go per-stage table, node shapes (adopted / parked / approved / both-running #16494), rows fixture; prelude now lifts stageTrackerTrackWord. Fixes #16531 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Fixes #16493
Follow-up to #16488 (#16484) after two operator steers: the dull
ham-current:not(.active)tint with a glyph-only chevron was unreadable, and the operator asked for pass/total on CI and perspectives done/total on Review.Caption grammar
CI 14/14 passedCI 11/14 Β· 1 failing (lint)/CI 10/14 Β· 3 failing (lint, test, β¦)CI 3/14 Β· running(+Β· 1 failing (lint)if any red so far)CI 0/14 Β· queuedCI 13/14 Β· test not reported/CI 0/14 Β· no checks reported yetCI 13/14 Β· build skippedCI ?/? Β· no checks reported yet(Β· no verdict yetwhen head-wide counts exist on an unprotected base)Review 5/5 approvedReview 3/5 Β· changes requestedReview 3/5 Β· awaiting human decisionReview 3/5 Β· reviewer-2 reviewingReview 3/5 Β· reviewer queuedReview 0/5 Β· swarm requestedReview 0/5 Β· re-review pending (new head)Review 3/5 Β· perspectivesdetail) still says which one the hive is waiting on.stale Β· <time>); it no longer dims or blanks the chevron. Only a freshactiveobservation pulses.tracker.css;.failingreuses--status-error;.ham-track-stateis single-line with ellipsis.Server
StageTrackerActivitygainschecks_passed,checks_total,checks_failed,checks_failing[],perspectives_done,perspectives_total(omitempty). CI counts come from required checks per name when branch protection is known, else head-wide check runs (one per name). Review total = configuredreview.perspectivesset (default 5) βͺ observed perspectives for the head; done = verdicts posted for the current head.Tests
stage_tracker_activity.test.jsβ count grammar across every state; the three screenshot rows (β¨ feat(github): enforce pin-only exception in merge-request relayΒ #16456 both lit, π± ci: route FOSSA uploads to the CNCF Hive Commons teamΒ #16491Review 0/5 Β· swarm requested, π fix(acmm): recognize install and boot E2E workflowsΒ #16268CI 13/14 Β· 1 failing (native-queue-policy)+Review 5/5 approved); not-started = glyph only; CSS rules. 289 pass.TestStageTrackerActivityCICheckCounts,TestStageTrackerActivityReviewPerspectiveCounts;go test ./pkg/dashboard/ -run 'Tracker|Activity'ok;make dashboard-gen-checkclean.