Skip to content

πŸ› dashboard: CI/Review chevrons show pass/total and perspectives done/total, lit while in progress - #16494

Merged
hivecommons-hive[bot] merged 5 commits into
v5from
fix/tracker-chevron-counts
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 5 commits into
v5from
fix/tracker-chevron-counts

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #16493

Follow-up to #16488 (#16484) after two operator steers: the dull ham-current:not(.active) tint with a glyph-only chevron was unreadable, and the operator asked for pass/total on CI and perspectives done/total on Review.

Caption grammar

Track State Chevron text Style
CI all required green CI 14/14 passed done
CI red check(s) CI 11/14 Β· 1 failing (lint) / CI 10/14 Β· 3 failing (lint, test, …) failing (error colour)
CI running CI 3/14 Β· running (+ Β· 1 failing (lint) if any red so far) active, pulses when fresh
CI queued CI 0/14 Β· queued active
CI required check silent CI 13/14 Β· test not reported / CI 0/14 Β· no checks reported yet active
CI skipped CI 13/14 Β· build skipped active
CI no evidence for head CI ?/? Β· no checks reported yet (Β· no verdict yet when head-wide counts exist on an unprotected base) active
Review approved Review 5/5 approved done
Review changes requested Review 3/5 Β· changes requested failing
Review human decision Review 3/5 Β· awaiting human decision active
Review reviewer live Review 3/5 Β· reviewer-2 reviewing active, pulses
Review queued Review 3/5 Β· reviewer queued active
Review swarm requested / no bundle Review 0/5 Β· swarm requested active
Review new head, no verdicts yet Review 0/5 Β· re-review pending (new head) active
Review partial verdicts, no aggregate Review 3/5 Β· perspectives active
either not started (not in current phase, no evidence) glyph only todo
  • Both CI and Review may be bright at once when both are in progress β€” truthful; the counts disambiguate, and the tooltip (keeps πŸ› dashboard: plain-language CI track captions with tooltip detailΒ #16480's detail) still says which one the hive is waiting on.
  • Freshness/staleness lives in the tooltip (stale Β· <time>); it no longer dims or blanks the chevron. Only a fresh active observation pulses.
  • The muted current-phase tint rule is removed from tracker.css; .failing reuses --status-error; .ham-track-state is single-line with ellipsis.

Server

StageTrackerActivity gains checks_passed, checks_total, checks_failed, checks_failing[], perspectives_done, perspectives_total (omitempty). CI counts come from required checks per name when branch protection is known, else head-wide check runs (one per name). Review total = configured review.perspectives set (default 5) βˆͺ observed perspectives for the head; done = verdicts posted for the current head.

Tests

…unts, lit while in progress

Operator steer on #16488: dull current-phase tint with glyph-only chevrons
was unreadable. Every CI/Review chevron in progress or finished on the
current head now reads a count caption (CI p/t, Review d/t) with the full
active fill, done style when complete, error style on a finding, and the
glyph alone only when not started. Server adds checks_passed/total/failed/
failing and perspectives_done/total to StageTrackerActivity.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16492 ✨ feat(dashboard): changed-paragraph reader kiosk view (part 1/3) same files src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • mobile-shots

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Evidence bundle `#164948de521c` sha256:9b7844ec5f83915d641d77306a43c0d35384a41d4c87140af54105c591da0618 β€” download from the dashboard or `hivectl review evidence #16494`.

Review findings from reviewer (folded here because this head already carries its hive review):

Looks correct to me. Read the Go and JS at c997bf1 against the tree rather than the diff alone:

  • stage_tracker_activity.go:226-268 (stageTrackerCountHeadChecks) and :286-331 (stageTrackerCountPerspectives) only use fields that exist on github.PRActivityCheck (Head, State, Conclusion, Since *time.Time β€” pkg/github/pr_ci_activity.go:26-37), review.Aggregate.Perspectives map[Perspective]Verdict (review.go:283) and DispatchState.Pending[].Perspective/Decision (dispatch.go:424-427). review.NewPerspectiveSet/List/Len and DefaultPerspectives resolve (perspective_set.go:79,135,143, review.go:38). go build ./pkg/dashboard/ is clean at this head.
  • stageTrackerCountPerspectives guards out == nil, so the stageTrackerReviewActivity(...) nil return at stage_tracker_build.go:471,545 is safe.
  • JSON tags (checks_passed/total/failed/failing, perspectives_done/total) match the keys stageTrackerTrackWord reads in tracker-row-strip.js:49-67, and the inline copy in static/index.html carries the same function.

One intentional reversal worth a maintainer's nod, not a defect: #16484's "the chevron never shrinks to a bare icon" is replaced by "not started = glyph alone" (tracker-row-strip.js:49-50 returns '' when state is unknown and the column is not current). The body states this came from an operator steer, so I am treating it as decided.

The red checks on the rollup are all IN_PROGRESS, not failures, at the time of this read.

hivecommons-hive Bot and others added 4 commits November 4, 2026 00:56
…unt captions wrap like peer chevrons

The browser probe's 'unknown track is icon-only' assertion predates the
count captions; a lit unknown track now reads 'CI ?/? Β· no checks
reported yet' and only a not-started (.todo) track is the glyph alone.
Drop the nowrap/ellipsis rule so the count caption honours the strip's
two-line wrap budget instead of truncating mid-count on phones.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive
hivecommons-hive Bot merged commit 9754607 into v5 Nov 4, 2026
82 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/tracker-chevron-counts branch November 4, 2026 01:17
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at c997bf1.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go side looks correct to me (read at head c997bf1, not just the diff; I did not deep-read the JS/CSS/index.html changes beyond the shape of the new fields they consume).

  • stage_tracker_activity.go:70-73, 104-107 β€” both early returns in stageTrackerCIActivity (required set unknown, or a required name with no binding) now fall back to stageTrackerCountHeadChecks, so ChecksTotal is only 0 when nothing was observed; the field comment's "0 means no count" contract holds.
  • stage_tracker_activity.go:155-157, 180-189 β€” perName keeps the worst-ranked state per required name and the pass/fail tallies iterate a.Required, so a required check with mixed re-runs counts once, as red if any run is red. Consistent with how out.State is already chosen.
  • stageTrackerCountHeadChecks β€” the check.Head filter is a no-op for commit statuses (only check runs set Head, pkg/github/pr_ci_activity.go:53), so statuses are always counted toward the head; matches the existing "+github-commit-statuses" source handling.
  • stageTrackerCountPerspectives guards out == nil, and both buildStageTracker call sites (stage_tracker_build.go:472 and the stacked-PR site) pass the same qualifier/expected set; dispatch.Pending[].Decision and review.NewPerspectiveSet(...).List() exist with the signatures used.

CI is green across all 86 checks on this head.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

clubanderson added a commit that referenced this pull request Nov 4, 2026
Integrates #16478, #16498 and #16505, which landed on v6 after the merge
was prepared. tracker.css: kept v5's title-line grid (#16454..#16494,
which supersedes #16498's flex-only title line and already keeps cap
pills off the PR title); static/index.html regenerated from static-src.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
hivecommons-hive Bot pushed a commit that referenced this pull request Nov 4, 2026
…hen adopted (#16532)

A complete review verdict (5/5) parked on a human decision wore the amber
in-progress fill and kept saying "awaiting human decision" even after the
hive adopted the PR back into PR in progress.

- JS: a settled human_decision track is done-style + muted (.decided); amber
  only while perspectives are running (a.active). CI unchanged: passed is done.
- JS/Go: with the hive on the repair (074 adopted, 07x fix stages, no
  needs-human/hold/085) a human_decision verdict reads "changes requested";
  the decision question and provenance ride in detail/source.
- Tests: Go per-stage table, node shapes (adopted / parked / approved /
  both-running #16494), rows fixture; prelude now lifts stageTrackerTrackWord.

Fixes #16531

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› Activity Monitor CI/Review chevrons are dull-tinted with a glyph only; operator cannot tell what either track is doing

1 participant