Repository navigation
fix(cm): integrate reviewed V2 reliability fixes - #96
Merged
Merged
Conversation
added 30 commits
October 20, 2026 09:02
The client data cache kept every session's transcript and pending rows after its tab closed, and late reads, older pages and later events could bring evicted rows back. createSessionRetention, wired in createServerController, evicts a session family once no open tab, session route, running work or attention request has kept it for one second with no navigation pending. Rows that return after eviction are released at the next deadline. Eviction keeps unacknowledged submissions and sessions still being created, so the policy retries until they settle. Adds data.session.cached, which lists sessions holding transcript or pending rows and notifies only when that set changes. Refs #77
Replace unavailable Blacksmith labels with ubuntu-24.04 and windows-2025 for PR tests and duplicate checks. Preserve every job, matrix entry and command while allowing this fork's queued checks to start.
The virtualizer core's reset-delay fallback ends a scroll with the offset read by the last scroll event. When a history prepend or anchor write moves scrollTop and a long task holds that write's own scroll event past the delay, the stale end delivery resets the core offset. Later prepend compensation then targets the stale offset, so loaded history rows are skipped. End-of-scroll deliveries now report the live scrollTop; scrolling deliveries are unchanged. Refs #89
Pin Chromium's reduced-motion preference so SVG images animate on Windows runners, and give each compared fixture row its own layer so identical rows raster from the same tile origin. Assertions, tolerances and timings are unchanged. Refs #90
4 tasks
added 5 commits
October 20, 2026 21:19
trmosala
marked this pull request as ready for review
October 21, 2026 02:23
This was referenced Oct 21, 2026
Owner
Author
|
The one final verification pass ran after all 36 scoped implementation tickets were confirmed closed. Source: public PR #96, merge
Genuine signed-in WPP capture remains unverified; the installed window returns HTTP 401 and a readiness question is pending. OS sandbox qualification of that capture is not claimed. Exact historical OOM-victim command/installation attribution remains unavailable, as recorded earlier. All 36 scoped implementation issues remain closed; #48 remains explicitly deferred and open. The installed CM/backend were not restarted or updated. The memory watcher remains active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Addresses #76, #77, #78, #79, #80, #81, #82, #83, #84, #85, #89, #90, #91 and #97. Implementation issues are closed individually with final verification explicitly deferred at the user's request. #48 remains deferred.
Type of change
What does this PR do?
Fix CookieMonster V2 session retention, desktop permissions and activation, panel navigation, refresh failures, browser request limits, timeline scrolling, portable SDK skill discovery and early mobile drawer dismissal. Closed-session transcripts are released, permissions survive multiple main windows, activation restores the main UI independently of hidden workers, and open-with requests enforce the native application allowlist.
Give CookieMonster its own Linux executable, launcher, icon and metainfo so it can coexist with OpenCode. Integrate the optional private WPP backend at
8bb2cd4e7d0588c3ef37735453830e7206f5a455. WPP access uses an automatically managed per-user credential. Browser requests have a 64 KiB UTF-8 admission limit and retain native permission grants and the approved trust of the authenticated backend across tasks.The private backend was merged in https://github.com/trmosala/CM-WPP-Bits/pull/28. Its 21 verified issues are closed; genuine signed-in WPP capture remains open as private issue #16. The legacy DOM assertion and viewport-order fix is published separately and is not merged into V2.
How did you verify your code works?
Final source is
68ab9205709350385471eb2d383b3cff3c18e678. The user requested completion and closure of all implementations before one final test pass. Automatic CI is therefore deferred for this update; final platform qualification is outstanding. No cancelled job is counted as a completed pass.Existing evidence from before testing was stopped:
--no-sandbox, so OS sandbox qualification is not claimed.The last completed Mac qualification attempt passed signing, notarization, stapling, mounted-installer validation, initial main-window/lifecycle adoption and hidden-worker setup. It found zero native activation events because AppleScript
activatedid not send the Dock-stylereopenevent. The script now sends nativereopenbeforeactivate, preserving the actual-event, visible-main-window and hidden-worker assertions. The subsequent run was cancelled at the user's request, so the corrected packaged activation remains unverified.The CI cancellation correction changes three
always()build steps to!cancelled(). They continue after failures but stop on explicit cancellation; artifact cleanup remains enabled.Genuine signed-in WPP capture remains unverified because the installed WPP window returned HTTP 401. The exact command and installation for historical kernel OOM victims were not retained, so correlation with the independently reproduced DOM assertion spike is not claimed as proof. The legacy fix remains published separately on
bounded-dom-testsand is not ported into V2.No release was published. The installed CM and backend were not updated or restarted. Issue closure records will distinguish implementation completion from deferred verification.
Screenshots / recordings
No new recording is attached. Verification currently uses automated browser geometry checks, real Electron fixtures and the disposable packaged Linux renderer. Final platform qualification remains pending as described above.
Checklist